Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3, 2.4
-
Fix Version/s: 2.3.2
-
Component/s: Themes
-
Labels:
-
Testing Instructions:
- Change to the formal white theme
- Check any page and make sure the content area contains its normal content
-
Affected Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Fixed Branches:MOODLE_23_STABLE
-
Pull from Repository:
-
Pull Master Branch:
MDL-34494_master -
Pull Master Diff URL:
-
Rank:42914
Description
In checking Formal White theme in order to answer a query today, concerning the report layout, I discovered that theme/formal_white/layout/report.php still uses the old MAIN_CONTENT_TOKEN. This is a regression, as the previous version (Moodle 2.2.4) although that uses general.php for the report layout, nevertheless is uses the correct form of $OUTPUT->main_content().
Activity
Ciao Mary
and thanks for this report.
I made a correction following your suggestion. Can you check it please.
It should really be safe.
Let me know, please.
Ciao.
Happy Olympics games.
Starting Peer Review
Looks good to me. 
I'll set it to start Integration Review.
Hi Daniele,
I have just submitted this for Integration Review.
But could you also fix Moodle 2.3 branch too? Otherwise the fix will not be in the next release.
Mary, I added the fix for m23 too.
Ciao.
Thanks Daniele and Mary, this has been integrated now
This seems to be missing testing instructions. I can click around formal white but I'm not quite sure what I should be doing.
Aha safe to pass then thanks Andrew.
Sorry I should have marked this as tested and passed when I integrated it.
Accurate testing instructions would be.
- Change to the formal white theme
- Check any page and make sure the content area contains its normal stuff.
Had a decent click around. All looks good. Passing.
asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!
Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!
Can you deal with this Danielle of do you want me to fix it?