Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34513

RTL Theme fixes for Moodle 2 (theme/mymobile)

    Details

    • Testing Instructions:
      Hide
      1. Make MyMobile the default theme for both 'Tablet' and 'Mobile' devices in the Theme Selector page of your Moodle site
      2. Using either Mobile or Tablet, login to your Moodle site and select a RTL language (Hebrew or Arabic) from the Lang menu.
      3. TEST to see that all areas work correctly.
        • Right align frontpage course list
        • Right align activity and resource titles
        • Two Columns on/off slider
        • Right align content in Blocks
        • Checkbox question types in quiz
        • Right align titles of fields in Forms
      Show
      Make MyMobile the default theme for both 'Tablet' and 'Mobile' devices in the Theme Selector page of your Moodle site Using either Mobile or Tablet, login to your Moodle site and select a RTL language (Hebrew or Arabic) from the Lang menu. TEST to see that all areas work correctly. Right align frontpage course list Right align activity and resource titles Two Columns on/off slider Right align content in Blocks Checkbox question types in quiz Right align titles of fields in Forms
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34513-WIP-MyMobile_rtl_support

      Description

      Several CSS fixes to theme/mymobile that improve RTL UI support

        Gliffy Diagrams

          Attachments

            Activity

            nadavkav Nadav Kavalerchik created issue -
            nadavkav Nadav Kavalerchik made changes -
            Field Original Value New Value
            Pull Master Diff URL https://github.com/nadavkav/moodle/compare/master...MDL-34513-WIP-MyMobile_rtl_support
            Summary MyMobile RTL support RTL Theme fixes for Moodle 2 (theme/mymobile)
            Pull Master Branch MDL-34513-WIP-MyMobile_rtl_support
            Fix Version/s 2.4 [ 12255 ]
            Fix Version/s 2.3.1 [ 12253 ]
            Description Several CSS fixes to the theme/mymobile that improve the RTL support
            Several CSS fixes to theme/mymobile that improve RTL UI support
            Pull from Repository git://github.com/nadavkav/moodle.git
            Labels mobile rtl theme ui
            Affects Version/s 2.4 [ 12255 ]
            lazydaisy Mary Evans made changes -
            Labels mobile rtl theme ui mobile rtl theme triaged ui
            lazydaisy Mary Evans made changes -
            Status Open [ 1 ] Waiting for integration review [ 10010 ]
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Hi Mary,

            Can you please add some testing instructions here.

            Cheers
            Sam

            Show
            samhemelryk Sam Hemelryk added a comment - Hi Mary, Can you please add some testing instructions here. Cheers Sam
            lazydaisy Mary Evans made changes -
            Testing Instructions # Make MyMobile the default theme for both 'Tablet' and 'Mobile' devices in the Theme Selector page of your Moodle site
            # Using either Mobile or Tablet, login to your Moodle site and select a RTL language (Hebrew or Arabic) from the Lang menu.
            # TEST to see that all areas work correctly.
            Hide
            lazydaisy Mary Evans added a comment - - edited

            @Nadav

            When you login can you Edit the Test Instructions if you want to add more details?
            Use the 'hash' # key to continue the numbered list.
            I don't have a mobile device that uses internet, although I am assured one is on its way for my birthday next month!

            Show
            lazydaisy Mary Evans added a comment - - edited @Nadav When you login can you Edit the Test Instructions if you want to add more details? Use the 'hash' # key to continue the numbered list. I don't have a mobile device that uses internet, although I am assured one is on its way for my birthday next month!
            Hide
            nebgor Aparup Banerjee added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            nebgor Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            nadavkav Nadav Kavalerchik made changes -
            Testing Instructions # Make MyMobile the default theme for both 'Tablet' and 'Mobile' devices in the Theme Selector page of your Moodle site
            # Using either Mobile or Tablet, login to your Moodle site and select a RTL language (Hebrew or Arabic) from the Lang menu.
            # TEST to see that all areas work correctly.
            # Make MyMobile the default theme for both 'Tablet' and 'Mobile' devices in the Theme Selector page of your Moodle site
            # Using either Mobile or Tablet, login to your Moodle site and select a RTL language (Hebrew or Arabic) from the Lang menu.
            # TEST to see that all areas work correctly.
            # Right align frontpage course list
            # right align activity and resource titles
            # Two Columns on/off slider fix
            # Right align content in Blocks
            # Fix checkbox question types in quiz
            # Right align titles of fields in Forms
            # minor ui tweaks
            Hide
            nadavkav Nadav Kavalerchik added a comment -

            @Mary

            1. Just pulled and rebase my github WIP branch (27-7-2012)
            2. Added some more test instructions.

            I was QAing it against "Moodle 2 Features..." course (from MOOCH) and it seems ok.
            I was using Asus Transformer (4.0.3) Chrome, Firefox.
            And also tested it on my desktop Chrome (v22 dev) with the "Chrome UA spoofer" plugin set to emulate UA = "Mobile"

            Thanks you all

            Show
            nadavkav Nadav Kavalerchik added a comment - @Mary Just pulled and rebase my github WIP branch (27-7-2012) Added some more test instructions. I was QAing it against "Moodle 2 Features..." course (from MOOCH) and it seems ok. I was using Asus Transformer (4.0.3) Chrome, Firefox. And also tested it on my desktop Chrome (v22 dev) with the "Chrome UA spoofer" plugin set to emulate UA = "Mobile" Thanks you all
            lazydaisy Mary Evans made changes -
            Testing Instructions # Make MyMobile the default theme for both 'Tablet' and 'Mobile' devices in the Theme Selector page of your Moodle site
            # Using either Mobile or Tablet, login to your Moodle site and select a RTL language (Hebrew or Arabic) from the Lang menu.
            # TEST to see that all areas work correctly.
            # Right align frontpage course list
            # right align activity and resource titles
            # Two Columns on/off slider fix
            # Right align content in Blocks
            # Fix checkbox question types in quiz
            # Right align titles of fields in Forms
            # minor ui tweaks
            # Make MyMobile the default theme for both 'Tablet' and 'Mobile' devices in the Theme Selector page of your Moodle site
            # Using either Mobile or Tablet, login to your Moodle site and select a RTL language (Hebrew or Arabic) from the Lang menu.
            # TEST to see that all areas work correctly.
            -- Right align frontpage course list
            -- Right align activity and resource titles
            -- Two Columns on/off slider
            -- Right align content in Blocks
            -- Checkbox question types in quiz
            -- Right align titles of fields in Forms
            Hide
            lazydaisy Mary Evans added a comment -

            Thanks Nadav!

            Show
            lazydaisy Mary Evans added a comment - Thanks Nadav!
            poltawski Dan Poltawski made changes -
            Currently in integration Yes [ 10041 ]
            poltawski Dan Poltawski made changes -
            Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
            Integrator poltawski
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Mary/Nadav, i've integrated this to 2.3 and master.

            Show
            poltawski Dan Poltawski added a comment - Thanks Mary/Nadav, i've integrated this to 2.3 and master.
            poltawski Dan Poltawski made changes -
            Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
            Fix Version/s 2.3.2 [ 12353 ]
            Fix Version/s 2.3.1 [ 12253 ]
            Fix Version/s 2.4 [ 12255 ]
            salvetore Michael de Raadt made changes -
            Tester andyjdavis
            Hide
            andyjdavis Andrew Davis added a comment -

            I'm setting Dan P to be the tester for this as he already has mobile access set up.

            Show
            andyjdavis Andrew Davis added a comment - I'm setting Dan P to be the tester for this as he already has mobile access set up.
            andyjdavis Andrew Davis made changes -
            Tester andyjdavis poltawski
            poltawski Dan Poltawski made changes -
            Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
            Hide
            poltawski Dan Poltawski added a comment - - edited

            Well, i've tested this and i'm pretty sure its an improvement as a variety of the suggestions seem to be working fine.

            Although as a left-to-right reader, its difficult for me to be exactly sure because a lot of the fields in the mymobile theme seem to be centred.

            Show
            poltawski Dan Poltawski added a comment - - edited Well, i've tested this and i'm pretty sure its an improvement as a variety of the suggestions seem to be working fine. Although as a left-to-right reader, its difficult for me to be exactly sure because a lot of the fields in the mymobile theme seem to be centred.
            poltawski Dan Poltawski made changes -
            Status Testing in progress [ 10011 ] Tested [ 10006 ]
            Hide
            poltawski Dan Poltawski added a comment -

            asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

            Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

            Show
            poltawski Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!
            poltawski Dan Poltawski made changes -
            Status Tested [ 10006 ] Closed [ 6 ]
            Resolution Fixed [ 1 ]
            Integration date 02/Aug/12
            poltawski Dan Poltawski made changes -
            Currently in integration Yes [ 10041 ]

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12