Moodle
  1. Moodle
  2. MDL-34520

Drop lowest grade setting is lost during backup/restore process.

    Details

    • Testing Instructions:
      Hide
      1. Goto a course with a few assignments and quizes and make sure you have a few attempts
      2. Goto gradebook>simple view from drop down
      3. Add a category and set aggregation to "simple weighted mean" and set "drop the lowest" to 1
      4. Backup the course (with users) and include grade history
      5. Restore as a new course and make sure the drop the lowest setting retains its value.
      Show
      Goto a course with a few assignments and quizes and make sure you have a few attempts Goto gradebook>simple view from drop down Add a category and set aggregation to "simple weighted mean" and set "drop the lowest" to 1 Backup the course (with users) and include grade history Restore as a new course and make sure the drop the lowest setting retains its value.
    • Workaround:
      Hide

      After restoring the course, reset the drop lowest grade setting.

      Show
      After restoring the course, reset the drop lowest grade setting.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-34520-master
    • Rank:
      42942

      Description

      In a course containing assignments/quizzes set Gradebook to simple weighted mean of grades, and the main course category to '1' for drop the lowest.
      Backup the course (with users), restore; drop to lowest grade setting for '1' is not found and is reverted to '0'.
      The backup was tested again with 'include grade history', and the restore displayed the same behavior.
      Reported by client, tested and verified on pure Moodle 2.2.3.

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting this.

        Free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.

        Show
        Michael de Raadt added a comment - Thanks for reporting this. Free to help us work on this issue. If you are able to provide a patch or links to your Git repository branch, please add a patch label so we will spot it.
        Hide
        Ankit Agarwal added a comment -

        Sending for peer-review.
        Thanks

        Show
        Ankit Agarwal added a comment - Sending for peer-review. Thanks
        Hide
        Rossiani Wijaya added a comment -

        Hi Ankit,

        The patch looks fine and tested on master.

        [y] Syntax
        [-] Output
        [y] Whitespace
        [-] Language
        [-] Databases
        [y] Testing
        [-] Security
        [-] Documentation
        [y] Git
        [y] Sanity check

        Show
        Rossiani Wijaya added a comment - Hi Ankit, The patch looks fine and tested on master. [y] Syntax [-] Output [y] Whitespace [-] Language [-] Databases [y] Testing [-] Security [-] Documentation [y] Git [y] Sanity check
        Hide
        Ankit Agarwal added a comment -

        Thanks for the review Rosie.
        Sending for integration

        Show
        Ankit Agarwal added a comment - Thanks for the review Rosie. Sending for integration
        Hide
        Dan Poltawski added a comment -

        Thanks Ankit, i've integrated this now (22, 23 and master)

        Show
        Dan Poltawski added a comment - Thanks Ankit, i've integrated this now (22, 23 and master)
        Hide
        Mark Nelson added a comment -

        Value was retained. Passing.

        Show
        Mark Nelson added a comment - Value was retained. Passing.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many, many thanks for your effort!

        Millions of people will enjoy the results of your work, yay!

        Closing as fixed. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Many, many thanks for your effort! Millions of people will enjoy the results of your work, yay! Closing as fixed. Ciao

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: