Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34503 META: Overhaul CANVAS theme
  3. MDL-34526

Add custommenu and block-region classes to CANVAS theme

    XMLWordPrintable

Details

    • Sub-task
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.3.1, 2.4
    • 2.4
    • Themes
    • MOODLE_23_STABLE, MOODLE_24_STABLE
    • MOODLE_24_STABLE
    • Hide

      NB: Please ensure you have a custom menu set in Themes settings prior to testing.

      1. Select CANVAS theme using theme selector. (NOT by URL)
      2. Ensure AJAX & JavaScript are enabled.
      3. Turn editing on and TEST drag-n-drop works when moving blocks.
      4. With editing still enabled TEST docking and un-docking all blocks.
      5. Turn editing off then TEST docking and un-docking all blocks.
      6. TEST 3,4 & 5 in Home page, Course page and Report page for consistency
      7. Test to see that the Custom Menu is displayed and works correctly
      Show
      NB: Please ensure you have a custom menu set in Themes settings prior to testing. Select CANVAS theme using theme selector. (NOT by URL) Ensure AJAX & JavaScript are enabled. Turn editing on and TEST drag-n-drop works when moving blocks. With editing still enabled TEST docking and un-docking all blocks. Turn editing off then TEST docking and un-docking all blocks. TEST 3,4 & 5 in Home page, Course page and Report page for consistency Test to see that the Custom Menu is displayed and works correctly

    Description

      block-region classes are a necessary requirement in layout files for themes to be able to work correctly when using AJAX drag-n-drop. At the moment CANVAS is missing these from region-post and region-pre in canvas/layout files.

      Also, like BASE theme, CANVAS should have the custommenu php in the layout files too, so that if CANVAS is copied to use as a base for new themes all the php is included that needs to be.

      Attachments

        Issue Links

          Activity

            People

              lazydaisy Mary Evans
              lazydaisy Mary Evans
              Sam Hemelryk Sam Hemelryk
              Andrew Davis Andrew Davis
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                3/Dec/12