Moodle

Add custommenu and block-region classes to CANVAS theme

Details

  • Type: Sub-task Sub-task
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.1, 2.4
  • Fix Version/s: 2.4
  • Component/s: Themes
  • Labels:
  • Testing Instructions:
    Hide

    NB: Please ensure you have a custom menu set in Themes settings prior to testing.

    1. Select CANVAS theme using theme selector. (NOT by URL)
    2. Ensure AJAX & JavaScript are enabled.
    3. Turn editing on and TEST drag-n-drop works when moving blocks.
    4. With editing still enabled TEST docking and un-docking all blocks.
    5. Turn editing off then TEST docking and un-docking all blocks.
    6. TEST 3,4 & 5 in Home page, Course page and Report page for consistency
    7. Test to see that the Custom Menu is displayed and works correctly
    Show
    NB: Please ensure you have a custom menu set in Themes settings prior to testing. Select CANVAS theme using theme selector. (NOT by URL) Ensure AJAX & JavaScript are enabled. Turn editing on and TEST drag-n-drop works when moving blocks. With editing still enabled TEST docking and un-docking all blocks. Turn editing off then TEST docking and un-docking all blocks. TEST 3,4 & 5 in Home page, Course page and Report page for consistency Test to see that the Custom Menu is displayed and works correctly
  • Affected Branches:
    MOODLE_23_STABLE, MOODLE_24_STABLE
  • Fixed Branches:
    MOODLE_24_STABLE
  • Pull from Repository:
  • Pull Master Diff URL:

Description

block-region classes are a necessary requirement in layout files for themes to be able to work correctly when using AJAX drag-n-drop. At the moment CANVAS is missing these from region-post and region-pre in canvas/layout files.

Also, like BASE theme, CANVAS should have the custommenu php in the layout files too, so that if CANVAS is copied to use as a base for new themes all the php is included that needs to be.

Issue Links

caused a regression

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35986 Serenity theme on 2.3.3 - custom menu not showing up

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.
has a non-specific relationship to

Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-34528 Remove redundent exclude stylesheet configurations from CANVAS theme

  • Trivial - Cosmetic problem like misspelt words or misaligned text
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Improvement - An enhancement to an existing Moodle feature. MDL-32652 Make block drag-drop work throughout Moodle

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mary Evans added a comment -

I'm working on this now hoping to get it finished soon.

Show
Mary Evans added a comment - I'm working on this now hoping to get it finished soon.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Mary, this has been integrated now

Show
Sam Hemelryk added a comment - Thanks Mary, this has been integrated now
Hide
Permalink
Andrew Davis added a comment -

It all seems to work fine except for being able to drag and drop blocks on the course reports. I tried the participation report and activity completion. The non-ajax block moving works fine and dragging and dropping works fine on the site front page and the course page but I dont seem to be able to grab the blocks and move them around on the course reports.

I'm using the theme "leatherbound" as its based on canvas and I dont seem to be able to select canvas directly.

Show
Andrew Davis added a comment - It all seems to work fine except for being able to drag and drop blocks on the course reports. I tried the participation report and activity completion. The non-ajax block moving works fine and dragging and dropping works fine on the site front page and the course page but I dont seem to be able to grab the blocks and move them around on the course reports. I'm using the theme "leatherbound" as its based on canvas and I dont seem to be able to select canvas directly.
Hide
Permalink
Dan Poltawski added a comment -

Hi Andrew,

This is to be expected - there is an issue somewhere about this, the drag/drop only works on course pages at the moment. I think that means this can be passed.

Show
Dan Poltawski added a comment - Hi Andrew, This is to be expected - there is an issue somewhere about this, the drag/drop only works on course pages at the moment. I think that means this can be passed.
Hide
Permalink
Dan Poltawski added a comment -

The issue is MDL-32652

Show
Dan Poltawski added a comment - The issue is MDL-32652
Hide
Permalink
Dan Poltawski added a comment -

I'm passing this based on your comments Andrew. Please shout if i've got this wrong.

Show
Dan Poltawski added a comment - I'm passing this based on your comments Andrew. Please shout if i've got this wrong.
Hide
Permalink
Dan Poltawski added a comment -

asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

Show
Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: