Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34503 META: Overhaul CANVAS theme
  3. MDL-34526

Add custommenu and block-region classes to CANVAS theme

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4
    • Fix Version/s: 2.4
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      NB: Please ensure you have a custom menu set in Themes settings prior to testing.

      1. Select CANVAS theme using theme selector. (NOT by URL)
      2. Ensure AJAX & JavaScript are enabled.
      3. Turn editing on and TEST drag-n-drop works when moving blocks.
      4. With editing still enabled TEST docking and un-docking all blocks.
      5. Turn editing off then TEST docking and un-docking all blocks.
      6. TEST 3,4 & 5 in Home page, Course page and Report page for consistency
      7. Test to see that the Custom Menu is displayed and works correctly
      Show
      NB: Please ensure you have a custom menu set in Themes settings prior to testing. Select CANVAS theme using theme selector. (NOT by URL) Ensure AJAX & JavaScript are enabled. Turn editing on and TEST drag-n-drop works when moving blocks. With editing still enabled TEST docking and un-docking all blocks. Turn editing off then TEST docking and un-docking all blocks. TEST 3,4 & 5 in Home page, Course page and Report page for consistency Test to see that the Custom Menu is displayed and works correctly
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Diff URL:

      Description

      block-region classes are a necessary requirement in layout files for themes to be able to work correctly when using AJAX drag-n-drop. At the moment CANVAS is missing these from region-post and region-pre in canvas/layout files.

      Also, like BASE theme, CANVAS should have the custommenu php in the layout files too, so that if CANVAS is copied to use as a base for new themes all the php is included that needs to be.

        Attachments

          Issue Links

          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-35986 Serenity theme on 2.3.3 - custom menu not showing up

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Sub-task - Issues are sometimes broken into multiple sub-tasks. MDL-34528 Remove redundent exclude stylesheet configurations from CANVAS theme

          • Trivial - Cosmetic problem like misspelt words or misaligned text
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-32652 Make block drag-drop work throughout Moodle

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              • Assignee:
                lazydaisy Mary Evans
                Reporter:
                lazydaisy Mary Evans
                Integrator:
                Sam Hemelryk
                Tester:
                Andrew Davis
                Participants:
                Component watchers:
                Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Dec/12