Moodle
  1. Moodle
  2. MDL-34503 META: Overhaul CANVAS theme
  3. MDL-34528

Remove redundent exclude stylesheet configurations from CANVAS theme

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2, 2.3
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      No test needed...

      Show
      No test needed...
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Rank:
      42952

      Description

      Two excluded parent CSS files in canvas/config.php do not exist any longer in BASE theme. This configuration setting needs to be removed.

        Issue Links

          Activity

          Hide
          Mary Evans added a comment - - edited

          Note to Integrator:

          I got some conficts with MDL-34528_master so I included these changes in MDL-34526 master branch instead to save time. I did it as a separate commit and labelled it as such. Hope this is OK?

          Show
          Mary Evans added a comment - - edited Note to Integrator: I got some conficts with MDL-34528 _master so I included these changes in MDL-34526 master branch instead to save time. I did it as a separate commit and labelled it as such. Hope this is OK?
          Hide
          Sam Hemelryk added a comment -

          Thanks Mary, this has been integrated now.

          In regards to MDL-34526 what you could do to help make things clearer is link the two issues.
          Either way certainly putting a comment for the integrator is a big help.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Mary, this has been integrated now. In regards to MDL-34526 what you could do to help make things clearer is link the two issues. Either way certainly putting a comment for the integrator is a big help. Cheers Sam
          Hide
          Sam Hemelryk added a comment -

          Confirmed no testing required, code inspection is enough.

          Show
          Sam Hemelryk added a comment - Confirmed no testing required, code inspection is enough.
          Hide
          Mary Evans added a comment -

          Thanks Sam

          Show
          Mary Evans added a comment - Thanks Sam
          Hide
          Dan Poltawski added a comment -

          asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

          Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

          Show
          Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: