Moodle
  1. Moodle
  2. MDL-34534

Backport activity chooser default setting to 2.3

    Details

    • Testing Instructions:
      Hide

      With no user setting set for activity chooser:

      1. Go to course and turn editing on - activity chooser should still be available
      2. Change setting to false
      3. Return to course and turn editing on - activity/resource selects should be available

      With user setting set for activity chooser

      1. Changing admin setting should have no effect
      Show
      With no user setting set for activity chooser: Go to course and turn editing on - activity chooser should still be available Change setting to false Return to course and turn editing on - activity/resource selects should be available With user setting set for activity chooser Changing admin setting should have no effect
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Rank:
      42961

      Description

      MDL-34205 introduces a feature which allows administrators to decide whether users see the new activity chooser by default. As it's a new feature it has only been added to master, but it was mainly intended for 2.3, so it would be good if it could be backported.

      My main motivation for developing the feature was to smooth the changeover from the old activity and resource dropdowns to the new activity chooser. The main scenario I had in mind (because it's the situation we're in at our university!) was this:

      An institution is planning to upgrade to Moodle 2.3 and needs to plan how it is going to roll out new features. For any new feature, all staff supporting Moodle have to be made aware of how it works, and support materials must be created. For most new features, e.g. mod_assign, this can take place after the upgrade as the feature can simply be disabled until the institution is ready to support it. However, this is not currently possible with the activity chooser. More importantly, the change to the activity chooser potentially affects support materials for all other tools, as, for example, a handout on how to use forums will probably need to be redone to show the new way to add a forum to your course.

      There are other similar arguments for being able to retain the "add an activity" dropdowns until ready. For example, there are various mod plugins which have (ab)used the get_types function for various reasons, and these don't display sensibly in the new activity chooser. (We have at least 3 of these and will need to fix them to work nicely with the activity chooser.)

      Obviously, one could argue that an institution SHOULD be fully prepared before upgrading to a new version, but in reality there is often a very small window for technical upgrades (here in the UK this would be the summer holiday period) and it is not necessarily practically possible to support a major new feature immediately. Moodle has generally been very good at supporting this workflow.

      For these reasons, I would hope that this feature can be backported to 2.3.

        Issue Links

          Activity

          Hide
          Michael Aherne added a comment -

          Added pull request.

          Show
          Michael Aherne added a comment - Added pull request.
          Hide
          Michael de Raadt added a comment -

          Thanks for suggesting that. I think this is an appropriate suggestion.

          Show
          Michael de Raadt added a comment - Thanks for suggesting that. I think this is an appropriate suggestion.
          Hide
          Michael de Raadt added a comment -

          Andrew, would you like to review this also?

          Show
          Michael de Raadt added a comment - Andrew, would you like to review this also?
          Hide
          Mary Cooch added a comment -

          Just adding docs_required - and to say I think this is a good idea too

          Show
          Mary Cooch added a comment - Just adding docs_required - and to say I think this is a good idea too
          Hide
          Andrew Nicols added a comment -

          Looks good to me. Feel free to put up for integration whenever you're ready.

          Note to integrator: Version number will need to be incremented for this change.

          Show
          Andrew Nicols added a comment - Looks good to me. Feel free to put up for integration whenever you're ready. Note to integrator: Version number will need to be incremented for this change.
          Hide
          Michael Aherne added a comment -

          Hi Andrew, would you mind putting this up for integration for me please? I wasn't given permission to do this when I asked !

          Show
          Michael Aherne added a comment - Hi Andrew, would you mind putting this up for integration for me please? I wasn't given permission to do this when I asked !
          Hide
          Andrew Nicols added a comment -

          No problem Michael.

          Show
          Andrew Nicols added a comment - No problem Michael.
          Hide
          Michael Aherne added a comment -

          Thanks!

          Show
          Michael Aherne added a comment - Thanks!
          Hide
          Aparup Banerjee added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Michael Aherne added a comment -

          Rebased.

          Show
          Michael Aherne added a comment - Rebased.
          Hide
          Michael de Raadt added a comment -

          +1 from me for this backport. It should probably have been included when it was added to master.

          Show
          Michael de Raadt added a comment - +1 from me for this backport. It should probably have been included when it was added to master.
          Hide
          Dan Poltawski added a comment -

          I think this is safe for back-porting to 2.3, so +1 from me.

          (Disclaimer: i'd prefer we didn't have any of these options at all, i'd like us to REDUCE settings, not increase them )

          Show
          Dan Poltawski added a comment - I think this is safe for back-porting to 2.3, so +1 from me. (Disclaimer: i'd prefer we didn't have any of these options at all, i'd like us to REDUCE settings, not increase them )
          Hide
          Sam Hemelryk added a comment -

          Thanks guys, gets a +1 from me as well and as such has now been backported.
          Big thanks to everyone involved.

          Show
          Sam Hemelryk added a comment - Thanks guys, gets a +1 from me as well and as such has now been backported. Big thanks to everyone involved.
          Hide
          Michael de Raadt added a comment -

          Test result:

          Tested in 2.3 only.

          Show
          Michael de Raadt added a comment - Test result: Tested in 2.3 only.
          Hide
          Michael Aherne added a comment -

          Thanks everyone! I have to say I kind of agree with Dan's comment on increasing settings - I'd hope this setting could be removed again in 2.5 or something, once everyone has made a smooth transition to the new activity chooser

          Show
          Michael Aherne added a comment - Thanks everyone! I have to say I kind of agree with Dan's comment on increasing settings - I'd hope this setting could be removed again in 2.5 or something, once everyone has made a smooth transition to the new activity chooser
          Hide
          Dan Poltawski added a comment -

          asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

          Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

          Show
          Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!
          Hide
          Mary Cooch added a comment -

          removing docs_require label as I've added it to various places in the docs now.

          Show
          Mary Cooch added a comment - removing docs_require label as I've added it to various places in the docs now.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: