[MDL-34535] messagelib is using is_int() on userids, which causes message send to fail sometimes. Needs to be is_numeric(). - Moodle Tracker

XML

Word

Printable

Affected Branches:
MOODLE_23_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/ankitagarwal/moodle.git
Pull Master Branch:
~~MDL-34535~~-master
Pull Master Diff URL:
https://github.com/ankitagarwal/moodle/compare/MDL-34535-master
Testing Instructions:
Hide

Dump the attached test.php in root of your moodle install

Edit test.php and change the $eventdata->userto to a valid user id

Run test.php from browser

make sure you get "Success" echoed

login as the userto user and make sure you get the msg
Show
Dump the attached test.php in root of your moodle install Edit test.php and change the $eventdata->userto to a valid user id Run test.php from browser make sure you get "Success" echoed login as the userto user and make sure you get the msg

Writing a module that send a message like this fails because line 63 of messagelib.php doesn't recognise the userid which comes in as a string.

$eventdata = new stdClass();

$eventdata->component = 'mod_coursework';

$eventdata->name = 'deadlinechanged';

$eventdata->userfrom = $USER;

// $dbrecord is from a standard $DB->get_record() call

$eventdata->userto = $dbrecord->studentid;

// etc

message_send($eventdata);

Participants:: Ankit Agarwal, Dan Poltawski, Eloy Lafuente (stronk7), Frédéric Massart, Matt Gibson, Michael de Raadt, Petr Skoda, Rossiani Wijaya

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)