Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34537

When enrolling the user list in the pop-up window randomly colours the background of user rows

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide
      1. Log in a Admin
      2. Go to a course manual enrolment page (Settings -> Course administration -> Users -> Enrolled users)
      3. Click enrol users
      4. In popup, inspect user rows (by firebug, drangonfly etc) and make sure they have alternate odd and even class.
      Show
      Log in a Admin Go to a course manual enrolment page (Settings -> Course administration -> Users -> Enrolled users) Click enrol users In popup, inspect user rows (by firebug, drangonfly etc) and make sure they have alternate odd and even class.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-34537
    • Pull Master Diff URL:

      Description

      There's CSS in the base theme which is intended to color odd and even rows of the user list different colors by attaching classes called "odd" and "even". The bit of code that adds these classes has a bug, since it adds the class based on the "rel" number (which might be the user id?) rather than on the position in the list. From the perspective of someone using Moodle this is effectively random.

      I've used the following CSS instead:

      .user-enroller-panel .uep-search-results .users .user:nth-child(odd)

      This doesn't work in IE8 but works everywhere else and doesn't require you to add classes to each row.

        Attachments

          Activity

            People

            Assignee:
            rajeshtaneja Rajesh Taneja
            Reporter:
            bawjaws David Scotson
            Peer reviewer:
            Frédéric Massart Frédéric Massart
            Integrator:
            Aparup Banerjee Aparup Banerjee
            Tester:
            Adrian Greeve Adrian Greeve
            Participants:
            Component watchers:
            Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Sep/12