Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34543

New assignment module - Feedback file exists for an assignment but not shown in the Feedback files picker

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a new assignment (mod_assign)
      2. Open assignment
      3. Click on "view/grade all submissions"
      4. For one of the students click on "Grade"
      5. Add a comment in the feedback section.
      6. Add a file in the feedback section.
      7. Go back to view/grade all submissions and file is displayed.
      8. Click on Grade for the same student, go to the feedback area
      9. VERIFY: that the feedback comment and file appears in the filepicker
      Show
      Create a new assignment (mod_assign) Open assignment Click on "view/grade all submissions" For one of the students click on "Grade" Add a comment in the feedback section. Add a file in the feedback section. Go back to view/grade all submissions and file is displayed. Click on Grade for the same student, go to the feedback area VERIFY: that the feedback comment and file appears in the filepicker
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      Upgraded to 2.3.1. Upgraded all assignments to the new type. Overview of assignments show a feedback file for a particular assignment. If you click on 'grade' for this assignment the file is not displayed in the feedback file picker.

      Replication steps:

      1. Create a new assignment
      2. Open assignment
      3. click on "view/grade all submissions"
      4. For one of the students click on "Grade"
      5. Add a comment in the feedback section.
      6. Add a file in the feedback section.
      7. Go back to view/grade all submissions and file is displayed.
      8. Click on Grade for the same student, go to the feedback area

      Expected result: the feedback comment and file appears in the filepicker

      Actual result: no file or comment is shown in the file picker

      So if you save now (or add another file and save) the original file and comment will no longer be visible in view/grade all submissions.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Hi, Paul.

            Can you please clarify that this is only for upgraded assignments that previously had feedback files attached? Have you tried this with newly created assignments?

            If you could create a set of replication steps that would allow us to see the same result, that would be helpful.

            Show
            salvetore Michael de Raadt added a comment - Hi, Paul. Can you please clarify that this is only for upgraded assignments that previously had feedback files attached? Have you tried this with newly created assignments? If you could create a set of replication steps that would allow us to see the same result, that would be helpful.
            Hide
            damyon Damyon Wiese added a comment -

            Hi Paul,

            Can you also please list which submission and feedback types are enabled for one of these assignments (in the assignment settings page)?

            Thanks, Damyon

            Show
            damyon Damyon Wiese added a comment - Hi Paul, Can you also please list which submission and feedback types are enabled for one of these assignments (in the assignment settings page)? Thanks, Damyon
            Hide
            dperry2009 Dave Perry added a comment -

            We have this problem too - both with newly created v2.2 and new type (v2.3) assignments. It's a new use case on the course page we want to do this on so no previous assignments to check.

            Show
            dperry2009 Dave Perry added a comment - We have this problem too - both with newly created v2.2 and new type (v2.3) assignments. It's a new use case on the course page we want to do this on so no previous assignments to check.
            Hide
            paulhague Paul Hague added a comment - - edited

            Hi Michael,
            I've just created a new assignment and just the same ...

            Create a new assignment
            Open assignment
            click on "view/grade all submissions"
            For one of the students click on "Grade"
            Add a file in the feedback section.
            Go back to view/grade all submissions and file is displayed.
            Click on Grade for the same student, go to the feedback files - nothing shown
            So if you save now (or add another file and save) the original file will no longer be visible in view/grade all submissions.

            Show
            paulhague Paul Hague added a comment - - edited Hi Michael, I've just created a new assignment and just the same ... Create a new assignment Open assignment click on "view/grade all submissions" For one of the students click on "Grade" Add a file in the feedback section. Go back to view/grade all submissions and file is displayed. Click on Grade for the same student, go to the feedback files - nothing shown So if you save now (or add another file and save) the original file will no longer be visible in view/grade all submissions.
            Hide
            paulhague Paul Hague added a comment -

            Hi Damyon,

            I enabled all submission types for the test assignment.

            Show
            paulhague Paul Hague added a comment - Hi Damyon, I enabled all submission types for the test assignment.
            Hide
            salvetore Michael de Raadt added a comment -

            Thanks for the additional information.

            I was able to reproduce the problem.

            Show
            salvetore Michael de Raadt added a comment - Thanks for the additional information. I was able to reproduce the problem.
            Hide
            helen2001 Christiana Nolte added a comment -

            I described the same problem: http://moodle.org/mod/forum/discuss.php?d=204996&parent=896404 (31. July 2012, 13:21) Thanks for working on this!

            Show
            helen2001 Christiana Nolte added a comment - I described the same problem: http://moodle.org/mod/forum/discuss.php?d=204996&parent=896404 (31. July 2012, 13:21) Thanks for working on this!
            Hide
            emerrill Eric Merrill added a comment -

            Note this problem is true for feedback comments too, not just the files, as indicated in MDL-34653

            Show
            emerrill Eric Merrill added a comment - Note this problem is true for feedback comments too, not just the files, as indicated in MDL-34653
            Hide
            emerrill Eric Merrill added a comment -

            In mod/assign/locallib.php add_grade_form_elements(), the $grade var starts out as a grade object, but then gets overwritten into the grade value as a string, but below it is passed to add_plugin_grade_elements(), which expects the object.

            I changed the code so the grade string is stored in $gradestring, instead of overwriting $grade.

            Show
            emerrill Eric Merrill added a comment - In mod/assign/locallib.php add_grade_form_elements(), the $grade var starts out as a grade object, but then gets overwritten into the grade value as a string, but below it is passed to add_plugin_grade_elements(), which expects the object. I changed the code so the grade string is stored in $gradestring, instead of overwriting $grade.
            Hide
            emerrill Eric Merrill added a comment -

            Damyon - I added you back to this, do you think you can review my patch, and set for integration if it's up to snuff.

            Thanks

            Show
            emerrill Eric Merrill added a comment - Damyon - I added you back to this, do you think you can review my patch, and set for integration if it's up to snuff. Thanks
            Hide
            damyon Damyon Wiese added a comment -

            This fix looks perfect to me - thanks Eric.

            Show
            damyon Damyon Wiese added a comment - This fix looks perfect to me - thanks Eric.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Thanks Eric - i've integrated this to 23 and master.

            Show
            poltawski Dan Poltawski added a comment - Thanks Eric - i've integrated this to 23 and master.
            Hide
            timb Tim Barker added a comment -

            Tested a per testing instructions, tested a few more combinations of this scenario and every time the file appeared.

            Show
            timb Tim Barker added a comment - Tested a per testing instructions, tested a few more combinations of this scenario and every time the file appeared.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

            Many thanks for your collaboration, yay!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao
            Hide
            paulhague Paul Hague added a comment -

            That's great. Thank you.

            Show
            paulhague Paul Hague added a comment - That's great. Thank you.

              People

              • Votes:
                7 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12