Well, if you want to frame it another way, I don't think these accessors should've been deprecated and should continue to be fully supported.
What would change my mind is if someone could answer this question with something meaningful:
> The benefit of changing every piece of code to use context_module::instance() over get_context_instance(CONTEXT_MODULE,) is?
The way it looks to me is:
- Developer creates newer (slightly nicer) API
- Developer deprecates old way (with no clear benefit, or discussion)
- Whole community has to do a lot of unnecessary work to update to new style
(In the middle of writing this, Damyon and I had a discussion about consistency for new developers, being tied down by legacy, which sure mellowed me whilst posting this )