Moodle
  1. Moodle
  2. MDL-34551

Add label for select and text input elements. (subtasks for MDL-30843, which is itself a subtask)

    Details

    • Testing Instructions:
      Hide

      No testing require. (just make sure there's no noticeable error for select/text input)

      The patch for this issue will be tested through sub-tasks.

      Show
      No testing require. (just make sure there's no noticeable error for select/text input) The patch for this issue will be tested through sub-tasks.
    • Affected Branches:
      MOODLE_22_STABLE
    • Rank:
      42984

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Issue Links

        Progress
        Resolved Sub-Tasks

        Sub-Tasks

        1.
        Add label for select and text input elements in admin Sub-task Closed Rossiani Wijaya
         
        2.
        Add label for select and text input elements in authentication Sub-task Closed Rossiani Wijaya
         
        3.
        Add label for select and text input elements in blocks Sub-task Closed Rossiani Wijaya
         
        4.
        Add label for select and text input elements in calendar Sub-task Closed Rossiani Wijaya
         
        5.
        Add label for select and text input elements in course Sub-task Closed Rossiani Wijaya
         
        6.
        Add label for select and text input elements in enrol Sub-task Closed Rossiani Wijaya
         
        7.
        Add label for select and text input elements in filter Sub-task Closed Rossiani Wijaya
         
        8.
        Add label for select and text input elements in grade Sub-task Closed Rossiani Wijaya
         
        9.
        Add label for select and text input elements in messages Sub-task Closed Rossiani Wijaya
         
        10.
        Add label for select and text input elements in assignment Sub-task Closed Rossiani Wijaya
         
        11.
        Add label for select and text input elements in chat Sub-task Closed Rossiani Wijaya
         
        12.
        Add label for select and text input elements in data Sub-task Closed Rossiani Wijaya
         
        13.
        Add label for select and text input elements in feedback Sub-task Closed Rossiani Wijaya
         
        14.
        Add label for select and text input elements in forum Sub-task Closed Rossiani Wijaya
         
        15.
        Add label for select and text input elements in glossary Sub-task Closed Rossiani Wijaya
         
        16.
        Add label for select and text input elements in lesson Sub-task Closed Rossiani Wijaya
         
        17.
        Add label for select and text input elements in quiz Sub-task Closed Rajesh Taneja
         
        18.
        Add label for select and text input elements in wiki Sub-task Closed Rossiani Wijaya
         
        19.
        Add label for select and text input elements in question Sub-task Closed Frédéric Massart
         
        20.
        Add label for select and text input elements in report Sub-task Closed Rossiani Wijaya
         
        21.
        Add label for select and text input elements in repository Sub-task Closed Rossiani Wijaya
         
        22.
        Add label for select and text input elements in tag Sub-task Closed Rossiani Wijaya
         
        23.
        Add label for select and text input elements in theme Sub-task Closed Rossiani Wijaya
         
        24.
        Add label for select and text input elements in user Sub-task Closed Rossiani Wijaya
         
        25.
        Update lib and language files to add label for select and text input elements Sub-task Closed Rossiani Wijaya
         
        26.
        Add label for select and text input elements in grade v2 Sub-task Closed Rajesh Taneja
         
        27.
        Add label for select and text input elements in enrol v2 Sub-task Closed Rossiani Wijaya
         
        28.
        Add label for select and text input elements in assignment grading page Sub-task Closed Rossiani Wijaya
         

          Activity

          Hide
          Aparup Banerjee added a comment -

          The sub-tasks in this issue needs peer-reviewing it seems. This will help towards better usability of the whole page. Please add comments after peer-review, thanks

          Also note Tim's comment. Tim mentions a valid point about the tests, i think we need to test these changes here with a proper accessibility testing approach and help refine these changes to create a smooth experience for the handicapped user.

          Perhaps we can have one final accessibility test here before closing off this meta-meta issue?

          The patches adding labels with 'accesshide' need to be thought as being added for accessibility reasons. We should not be throwing all possible labels at users needing accessibility with tons of labels.

          Show
          Aparup Banerjee added a comment - The sub-tasks in this issue needs peer-reviewing it seems. This will help towards better usability of the whole page. Please add comments after peer-review, thanks Also note Tim's comment . Tim mentions a valid point about the tests, i think we need to test these changes here with a proper accessibility testing approach and help refine these changes to create a smooth experience for the handicapped user. Perhaps we can have one final accessibility test here before closing off this meta-meta issue? The patches adding labels with 'accesshide' need to be thought as being added for accessibility reasons. We should not be throwing all possible labels at users needing accessibility with tons of labels.
          Hide
          Michael de Raadt added a comment -

          Carrying over to the next sprint.

          Show
          Michael de Raadt added a comment - Carrying over to the next sprint.
          Hide
          Aparup Banerjee added a comment -

          Grr, just noting here these subtasks have been through iterations from this issue : MDL-30843 !

          Show
          Aparup Banerjee added a comment - Grr, just noting here these subtasks have been through iterations from this issue : MDL-30843 !
          Hide
          Aparup Banerjee added a comment -

          I see Tim is watching this already.
          just noting (from discussions in MDL-34570 and SamH in MDL-30843 and elsewhere comments from TimH too) that we need some bigger scale test sessions here to look into how accessibility is being improved through out moodle from these MDLs with screen readers etc.

          I can already hear Tim thinking

          Show
          Aparup Banerjee added a comment - I see Tim is watching this already. just noting (from discussions in MDL-34570 and SamH in MDL-30843 and elsewhere comments from TimH too) that we need some bigger scale test sessions here to look into how accessibility is being improved through out moodle from these MDLs with screen readers etc. I can already hear Tim thinking
          Hide
          Aparup Banerjee added a comment - - edited

          Also, imo the other changes in the primary meta MDL-27843 should go through some test sessions just to wrap that up well.

          Show
          Aparup Banerjee added a comment - - edited Also, imo the other changes in the primary meta MDL-27843 should go through some test sessions just to wrap that up well.
          Hide
          Jason Hardin added a comment -

          assignments 2.3 also has a select box in the grading interface that does not have a label, it doesn't look like there is a sub task for this.

          Show
          Jason Hardin added a comment - assignments 2.3 also has a select box in the grading interface that does not have a label, it doesn't look like there is a sub task for this.
          Hide
          Chetz Colwell added a comment -

          I'm wondering if this issue has got a bit 'stuck' and if there is anything I can do to help test what has already been implemented? If you can provide links/examples I could test with keyboard and screenreader if that would be useful!

          Show
          Chetz Colwell added a comment - I'm wondering if this issue has got a bit 'stuck' and if there is anything I can do to help test what has already been implemented? If you can provide links/examples I could test with keyboard and screenreader if that would be useful!
          Hide
          Rossiani Wijaya added a comment -

          Hi Chetz,

          This issue has been fixed through subtasks.

          Thank you for your willingness to help us.

          Rosie.

          Closing.

          Show
          Rossiani Wijaya added a comment - Hi Chetz, This issue has been fixed through subtasks. Thank you for your willingness to help us. Rosie. Closing.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: