Details

    • Testing Instructions:
      Hide

      Test pre-requisites

      • Enable the config setting grade_report_showcalculations
      • In the course you'll test in, enable Show quick feedback in 'My report preferences > Grade report' In 'Grades'

      Test steps

      1. Navigate to Home ► Courses ► Any Course ► Grade administration ► Grader report and turn editing on
      2. Make sure every <input type='text'> and <select> has a <label> attached
      3. Click on the calculator on the top right of the grid
      4. Make sure every <input type='text'> and <select> has a <label> attached
      1. Back to the grader report
      2. In the dropdown menu select 'Categories and items > Simple view'
      3. Make sure every <input type='text'> and <select> has a <label> attached
      4. In the dropdown menu select 'Categories and items > Full view'
      5. Make sure every <input type='text'> and <select> has a <label> attached
      1. Create an assignment
      2. Go to 'Advanced grading' and select 'Rubric'
      3. Click on 'Define new grading form from scratch'
      4. Make sure every <input type='text'> and <select> has a <label> attached
      1. Create an assignment
      2. Go to 'Advanced grading' and set up a marking guide
      3. Make sure every <input type='text'> and <select> has a <label> attached
      4. Grade a student on the activity
      5. Go back to 'Advanced grading' and edit the guide
      6. Change one of the Mark field and click submit
      7. Make sure every <input type='text'> and <select> has a <label> attached
      Show
      Test pre-requisites Enable the config setting grade_report_showcalculations In the course you'll test in, enable Show quick feedback in 'My report preferences > Grade report' In 'Grades' Test steps Navigate to Home ► Courses ► Any Course ► Grade administration ► Grader report and turn editing on Make sure every <input type='text'> and <select> has a <label> attached Click on the calculator on the top right of the grid Make sure every <input type='text'> and <select> has a <label> attached Back to the grader report In the dropdown menu select 'Categories and items > Simple view' Make sure every <input type='text'> and <select> has a <label> attached In the dropdown menu select 'Categories and items > Full view' Make sure every <input type='text'> and <select> has a <label> attached Create an assignment Go to 'Advanced grading' and select 'Rubric' Click on 'Define new grading form from scratch' Make sure every <input type='text'> and <select> has a <label> attached Create an assignment Go to 'Advanced grading' and set up a marking guide Make sure every <input type='text'> and <select> has a <label> attached Grade a student on the activity Go back to 'Advanced grading' and edit the guide Change one of the Mark field and click submit Make sure every <input type='text'> and <select> has a <label> attached
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34559_accessibility

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Aparup Banerjee added a comment -

            Just noting that
            /grade/edit/tree/index.php
            @@ -342,8 +342,8 - the removed string is being put back atm.

            Show
            Aparup Banerjee added a comment - Just noting that /grade/edit/tree/index.php @@ -342,8 +342,8 - the removed string is being put back atm.
            Hide
            Aparup Banerjee added a comment -

            Thanks Rosie, those have been integrated into 22, 23 and master.

            Show
            Aparup Banerjee added a comment - Thanks Rosie, those have been integrated into 22, 23 and master.
            Hide
            Frédéric Massart added a comment -

            Missing some labels:

            /home/fred/www/testing_master/grade/report/grader/lib.php:1038
            /home/fred/www/testing_master/grade/report/grader/lib.php:1050

            /home/fred/www/testing_master/grade/edit/tree/lib.php:814
            /home/fred/www/testing_master/grade/edit/tree/lib.php:967
            /home/fred/www/testing_master/grade/edit/tree/lib.php:1048
            /home/fred/www/testing_master/grade/edit/tree/lib.php:1090

            I did not check on 2.2 and 2.3.

            Show
            Frédéric Massart added a comment - Missing some labels: /home/fred/www/testing_master/grade/report/grader/lib.php:1038 /home/fred/www/testing_master/grade/report/grader/lib.php:1050 /home/fred/www/testing_master/grade/edit/tree/lib.php:814 /home/fred/www/testing_master/grade/edit/tree/lib.php:967 /home/fred/www/testing_master/grade/edit/tree/lib.php:1048 /home/fred/www/testing_master/grade/edit/tree/lib.php:1090 I did not check on 2.2 and 2.3.
            Hide
            Frédéric Massart added a comment -

            Agreed to open a new issue (MDL-34777) to fix the missing labels. The list I provided is a guide, but there might be others.

            Add this one too:

            /home/fred/www/testing_23/grade/grading/form/guide/renderer.php:601

            Test passed on 2.2, 2.3 and master.

            Show
            Frédéric Massart added a comment - Agreed to open a new issue ( MDL-34777 ) to fix the missing labels. The list I provided is a guide, but there might be others. Add this one too: /home/fred/www/testing_23/grade/grading/form/guide/renderer.php:601 Test passed on 2.2, 2.3 and master.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Fixed STOP Closed STOP Thanks STOP

            Yay, imagination! Ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: