Details

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              poltawski Dan Poltawski added a comment -

              Hi,

              Reopening this - I don't see a lang string 'assignment:grade'

              Show
              poltawski Dan Poltawski added a comment - Hi, Reopening this - I don't see a lang string 'assignment:grade'
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Hi Dan,

              The string is exist in mod/assignment/lang/en/assignment.php file.

              Show
              rwijaya Rossiani Wijaya added a comment - Hi Dan, The string is exist in mod/assignment/lang/en/assignment.php file.
              Hide
              poltawski Dan Poltawski added a comment -

              Whoops, yes. I'm being stupid, sorry!

              Show
              poltawski Dan Poltawski added a comment - Whoops, yes. I'm being stupid, sorry!
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks Rosie, i've integrated this now

              Show
              poltawski Dan Poltawski added a comment - Thanks Rosie, i've integrated this now
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Thanks Dan.

              Show
              rwijaya Rossiani Wijaya added a comment - Thanks Dan.
              Hide
              rwijaya Rossiani Wijaya added a comment -

              Dan's comment on MDL-34567:
              I'm not sure that the ids on these labels are right, it doesn't look the same to me:

              $menu = html_writer::label(get_string('assignment:grade', 'assignment'), 'menumenu'. $auser->id, false, array('class' => ''));
              $menu .= html_writer::select(make_grades_menu($this->assignment->grade), 'menu['.$auser->id.']', $auser->grade, array(-1=>get_string('nograde')), $attributes);

              The ids for those labels are set accordingly to match the html_writer::select id creator.
              Snippet for id creation in html_writer::select:

              if (!isset($attributes['id'])) {
                  $id = 'menu'.$name;
                  // name may contaion [], which would make an invalid id. e.g. numeric question type editing form, assignment quickgrading
                  $id = str_replace('[', '', $id);
                  $id = str_replace(']', '', $id);
                  $attributes['id'] = $id;
              }

              However, I noticed the line is missing 'accesshide' class value

              I updated the patch to add accesshide class.

              Please push the additional patch for integration.

              Thank you.

              Show
              rwijaya Rossiani Wijaya added a comment - Dan's comment on MDL-34567 : I'm not sure that the ids on these labels are right, it doesn't look the same to me: $menu = html_writer::label(get_string('assignment:grade', 'assignment'), 'menumenu'. $auser->id, false, array('class' => '')); $menu .= html_writer::select(make_grades_menu($this->assignment->grade), 'menu['.$auser->id.']', $auser->grade, array(-1=>get_string('nograde')), $attributes); The ids for those labels are set accordingly to match the html_writer::select id creator. Snippet for id creation in html_writer::select: if (!isset($attributes['id'])) { $id = 'menu'.$name; // name may contaion [], which would make an invalid id. e.g. numeric question type editing form, assignment quickgrading $id = str_replace('[', '', $id); $id = str_replace(']', '', $id); $attributes['id'] = $id; } However, I noticed the line is missing 'accesshide' class value I updated the patch to add accesshide class. Please push the additional patch for integration. Thank you.
              Hide
              poltawski Dan Poltawski added a comment -

              Thanks for checking and fixing that Rosie, i've pulled it in.

              Show
              poltawski Dan Poltawski added a comment - Thanks for checking and fixing that Rosie, i've pulled it in.
              Hide
              dmonllao David Monllaó added a comment -

              Tested in master and 22. It passes

              Show
              dmonllao David Monllaó added a comment - Tested in master and 22. It passes
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Fixed STOP Closed STOP Thanks STOP

              Yay, imagination! Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao
              Hide
              jrh18 Jason Hardin added a comment -

              This ticket and possibly the work should be cloned for Assignment 2.3 as well. The same issue occurs in the same grading interface in the choose... select drop box in the upper left.

              Show
              jrh18 Jason Hardin added a comment - This ticket and possibly the work should be cloned for Assignment 2.3 as well. The same issue occurs in the same grading interface in the choose... select drop box in the upper left.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12