Details

    • Testing Instructions:
      Hide
      1. Create a chat in a course, enter messages verifying there are labels with the accesshide class in the enter message input
      2. Change the chat method going to the administration tree -> plugins -> Activity modules -> Chat -> chat_method, and repeat the same process
      Show
      Create a chat in a course, enter messages verifying there are labels with the accesshide class in the enter message input Change the chat method going to the administration tree -> plugins -> Activity modules -> Chat -> chat_method, and repeat the same process
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34562_accessibility
    • Rank:
      42995

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Rosie,

          We can't do this:

          <?php get_string('modulename', 'chat'); ?> . ' ' .<?php strtolower(get_string('messages', 'chat')); ?> 
          

          As its not good for some languages where it may not make sense to order the strings that way. We need to use a single string (and shouldn't use strtolower like that either).

          Show
          Dan Poltawski added a comment - Hi Rosie, We can't do this: <?php get_string('modulename', 'chat'); ?> . ' ' .<?php strtolower(get_string('messages', 'chat')); ?> As its not good for some languages where it may not make sense to order the strings that way. We need to use a single string (and shouldn't use strtolower like that either).
          Hide
          Rossiani Wijaya added a comment -

          Ooops... it slipped away from my filter.

          Thanks for catching that.

          I updated the patch and re-submitting for integration review.

          Show
          Rossiani Wijaya added a comment - Ooops... it slipped away from my filter. Thanks for catching that. I updated the patch and re-submitting for integration review.
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Rosie.

          Show
          Dan Poltawski added a comment - Integrated, thanks Rosie.
          Hide
          David Monllaó added a comment -

          Tested in master and MOODLE_22_STABLE. It passes, removing the accesshide class I can see the messages.

          The chat_daemon method can not be tested in master nor MOODLE_22_STABLE due to other pending issues, I mark it as passes because the code changes are small and correct.

          Show
          David Monllaó added a comment - Tested in master and MOODLE_22_STABLE. It passes, removing the accesshide class I can see the messages. The chat_daemon method can not be tested in master nor MOODLE_22_STABLE due to other pending issues, I mark it as passes because the code changes are small and correct.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: