Details

    • Testing Instructions:
      Hide
      1. Create a database instance in a course, add this types of fields "date", "file", "latlong", "menu", "multimenu", "number", "picture", "radiobutton", "text", "textarea" and "url" verifying there are labels with the accesshide class in the form elements
      Show
      Create a database instance in a course, add this types of fields "date", "file", "latlong", "menu", "multimenu", "number", "picture", "radiobutton", "text", "textarea" and "url" verifying there are labels with the accesshide class in the form elements
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34563_accessibility
    • Rank:
      42996

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Issue Links

          Activity

          Hide
          Aparup Banerjee added a comment -

          Hi Rosie,

          https://github.com/rwijaya/moodle/compare/master...MDL-34563_accessibility#L1R46

          The plural strings have to be used instead. all else looks fine here.

          Show
          Aparup Banerjee added a comment - Hi Rosie, https://github.com/rwijaya/moodle/compare/master...MDL-34563_accessibility#L1R46 The plural strings have to be used instead. all else looks fine here.
          Hide
          Rossiani Wijaya added a comment -

          Patch updated.

          Thanks Apu.

          Show
          Rossiani Wijaya added a comment - Patch updated. Thanks Apu.
          Hide
          Aparup Banerjee added a comment -

          Rosie, MDL-34568 has shed some light so i think i need more time to review this, so its for next week.

          Please reopen if any of Tim's comments apply here too.

          Show
          Aparup Banerjee added a comment - Rosie, MDL-34568 has shed some light so i think i need more time to review this, so its for next week. Please reopen if any of Tim's comments apply here too.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Aparup Banerjee added a comment - - edited

          Hi Rosie,
          I 've had a closer look this time and its all good, just one quick fix needed:

          • multimenu/field.class.php line 41 : we shouldn't have a colon for accesshide labels (don't need to read out colon from reader)
          • last commit needs 'MDL'
          Show
          Aparup Banerjee added a comment - - edited Hi Rosie, I 've had a closer look this time and its all good, just one quick fix needed: multimenu/field.class.php line 41 : we shouldn't have a colon for accesshide labels (don't need to read out colon from reader) last commit needs 'MDL'
          Hide
          Rossiani Wijaya added a comment -

          Patch updated.

          Thanks Apu.

          Show
          Rossiani Wijaya added a comment - Patch updated. Thanks Apu.
          Hide
          Aparup Banerjee added a comment -

          cool, those labels are now integrated into 22, 23 and master.

          Show
          Aparup Banerjee added a comment - cool, those labels are now integrated into 22, 23 and master.
          Hide
          David Monllaó added a comment -

          Commented with Rossiani, waiting for tomorrow to pass or fail it just in case it can be integred with the new patch

          • Search -> Author first name -> No label
          • Search -> Author surname
          • Search -> file field -> Wrong double quote in for attribute
          • New entry -> Date field -> Duplicate labels
          • New entry -> Number field -> No label
          • New entry -> Text field -> No label
          • Add field -> File field -> Maximum size attr -> The for has to point to "param3"
          • Add field -> Picture field -> Maximum size attr -> The for has to point to "param3"
          • Add field -> URL field -> Forced name... attr -> Label pointing to the element name instead of "forcelinkname"
          Show
          David Monllaó added a comment - Commented with Rossiani, waiting for tomorrow to pass or fail it just in case it can be integred with the new patch Search -> Author first name -> No label Search -> Author surname Search -> file field -> Wrong double quote in for attribute New entry -> Date field -> Duplicate labels New entry -> Number field -> No label New entry -> Text field -> No label Add field -> File field -> Maximum size attr -> The for has to point to "param3" Add field -> Picture field -> Maximum size attr -> The for has to point to "param3" Add field -> URL field -> Forced name... attr -> Label pointing to the element name instead of "forcelinkname"
          Hide
          Rossiani Wijaya added a comment -

          Thanks David.

          Patch has been updated to fix the above comments.

          Integrator please integrate the new patch.

          Thanks.

          Show
          Rossiani Wijaya added a comment - Thanks David. Patch has been updated to fix the above comments. Integrator please integrate the new patch. Thanks.
          Hide
          Aparup Banerjee added a comment -

          wowie, good catches David! sorry i missed all that, must've been blind there!

          Show
          Aparup Banerjee added a comment - wowie, good catches David! sorry i missed all that, must've been blind there!
          Hide
          Rossiani Wijaya added a comment -

          Updated the patch.

          Sorry for the hassle Apu.

          Show
          Rossiani Wijaya added a comment - Updated the patch. Sorry for the hassle Apu.
          Hide
          Aparup Banerjee added a comment -

          (github is down here atm )

          Show
          Aparup Banerjee added a comment - (github is down here atm )
          Hide
          Aparup Banerjee added a comment -

          ok

          • ace963d MDL-34563 - change string firstname to lastname and add accesshide class
          • 8f46d48 MDL-34563 - removed double labeling and add label for input text
            (master)
            have been picked across to 22, 23 and master.

          This should've been well tested by now thanks to David's sharp eyes

          ps:
          we do need peer-reviewing here for the next few label ones as these are very intricate changes better seen by many eyes as possible.

          So i'd suggest to peer-review them again even if they were broken down into many issues and evidence is showing it could do with more reviews.

          Show
          Aparup Banerjee added a comment - ok ace963d MDL-34563 - change string firstname to lastname and add accesshide class 8f46d48 MDL-34563 - removed double labeling and add label for input text (master) have been picked across to 22, 23 and master. This should've been well tested by now thanks to David's sharp eyes ps: we do need peer-reviewing here for the next few label ones as these are very intricate changes better seen by many eyes as possible. So i'd suggest to peer-review them again even if they were broken down into many issues and evidence is showing it could do with more reviews.
          Hide
          David Monllaó added a comment -

          Tested in master and 22, it passes now

          Show
          David Monllaó added a comment - Tested in master and 22, it passes now
          Hide
          Eloy Lafuente (stronk7) added a comment -

          For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

          Many thanks for your collaboration, yay!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: