Details

    • Testing Instructions:
      Hide
      1. As an admin / teacher go to a course and replace the URL for /mod/forum/search.php?id=$COURSEID
      2. As an admin / teacher check the form elements, there SHOULD be labels on them
      3. As an admin / teacher go to a course and add a forum instance selecting "A single simple discussion" in the "Forum type" form element (apply MDL-34711 patch if you receive an exception)
      4. As an admin / teacher go to the forum instance and check the "Display replies*" select element, it SHOULD have a label with an accesshide class

      (ps: using a screen reader will make these labels apparent as they should be read out to you)

      Show
      As an admin / teacher go to a course and replace the URL for /mod/forum/search.php?id=$COURSEID As an admin / teacher check the form elements, there SHOULD be labels on them As an admin / teacher go to a course and add a forum instance selecting "A single simple discussion" in the "Forum type" form element (apply MDL-34711 patch if you receive an exception) As an admin / teacher go to the forum instance and check the "Display replies*" select element, it SHOULD have a label with an accesshide class (ps: using a screen reader will make these labels apparent as they should be read out to you)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34565_accessibility

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            nebgor Aparup Banerjee added a comment -

            The plural (month-s) strings have to be used instead : https://github.com/rwijaya/moodle/compare/master...MDL-34565_accessibility#L1R349

            Show
            nebgor Aparup Banerjee added a comment - The plural (month-s) strings have to be used instead : https://github.com/rwijaya/moodle/compare/master...MDL-34565_accessibility#L1R349
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Patch updated.

            Thanks Apu.

            Show
            rwijaya Rossiani Wijaya added a comment - Patch updated. Thanks Apu.
            Hide
            nebgor Aparup Banerjee added a comment -

            Rosie, MDL-34568 has shed some light so i think i need more time to review this, so its for next week.

            Please reopen if any of Tim's comments apply here too.

            Show
            nebgor Aparup Banerjee added a comment - Rosie, MDL-34568 has shed some light so i think i need more time to review this, so its for next week. Please reopen if any of Tim's comments apply here too.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

            This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

            This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

            Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
            Hide
            nebgor Aparup Banerjee added a comment -

            Thanks Rosie, these labels have integrated added now .

            Show
            nebgor Aparup Banerjee added a comment - Thanks Rosie, these labels have integrated added now .
            Hide
            dmonllao David Monllaó added a comment -

            Just a simple problem detected, commented with Rossiani, waiting for tomorrow to pass or fail it just in case it can be integred with the new patch

            1. Search forums -> date elements -> Duplicate, one of them don't work
            Show
            dmonllao David Monllaó added a comment - Just a simple problem detected, commented with Rossiani, waiting for tomorrow to pass or fail it just in case it can be integred with the new patch Search forums -> date elements -> Duplicate, one of them don't work
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Thanks David.

            Patch has been updated to fix the above comments.

            Integrator please integrate the new patch.

            Thanks

            Show
            rwijaya Rossiani Wijaya added a comment - Thanks David. Patch has been updated to fix the above comments. Integrator please integrate the new patch. Thanks
            Hide
            nebgor Aparup Banerjee added a comment -

            not sure which "one of them don't work", please lets clarify whats going on here. It will be a shame to revert this after all the efforts.

            Show
            nebgor Aparup Banerjee added a comment - not sure which "one of them don't work", please lets clarify whats going on here. It will be a shame to revert this after all the efforts.
            Hide
            nebgor Aparup Banerjee added a comment -

            ah ok, sorry, bit of a miscomm here, Rosie helped to clarify the english here , 'one of them don't work" => "Each duplicate label isn't right"

            Show
            nebgor Aparup Banerjee added a comment - ah ok, sorry, bit of a miscomm here, Rosie helped to clarify the english here , 'one of them don't work" => "Each duplicate label isn't right"
            Hide
            dmonllao David Monllaó added a comment -

            It passes. Tested in master and MOODLE_22_STABLE

            Show
            dmonllao David Monllaó added a comment - It passes. Tested in master and MOODLE_22_STABLE
            Hide
            nebgor Aparup Banerjee added a comment -

            note: the further fixes were pulled into 22, 23 and master.

            Show
            nebgor Aparup Banerjee added a comment - note: the further fixes were pulled into 22, 23 and master.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

            Many thanks for your collaboration, yay!

            Closing, ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12