Details

    • Testing Instructions:
      Hide
      1. As an admin or teacher, go to a course and create a lesson instance
      2. As an admin or teacher, go to the lesson and click the "Add a question page" link
      3. As an admin or teacher, select the "Matching" option and click "Add a question page"
      4. As an admin or teacher, fill the form adding a correct and an incorrect answers
      5. As an admin or teacher, go again to the "Edit" tab and click "Add a question page here"
      6. As an admin or teacher, select the "Matching" option and click "Add a question page"
      7. As an admin or teacher, fill the form adding a correct and an incorrect answers
      8. As a student, go to the lesson and answer it
      9. As an admin or teacher, go to the lesson and click on the "Reports" tab
      10. As an admin or teacher, check the "Choose..." button, it should have a label with class "accesshide"
      11. As an admin or teacher, click one student attempt and check the select elements, they SHOULD have a label with class "accesshide"
      Show
      As an admin or teacher, go to a course and create a lesson instance As an admin or teacher, go to the lesson and click the "Add a question page" link As an admin or teacher, select the "Matching" option and click "Add a question page" As an admin or teacher, fill the form adding a correct and an incorrect answers As an admin or teacher, go again to the "Edit" tab and click "Add a question page here" As an admin or teacher, select the "Matching" option and click "Add a question page" As an admin or teacher, fill the form adding a correct and an incorrect answers As a student, go to the lesson and answer it As an admin or teacher, go to the lesson and click on the "Reports" tab As an admin or teacher, check the "Choose..." button, it should have a label with class "accesshide" As an admin or teacher, click one student attempt and check the select elements, they SHOULD have a label with class "accesshide"
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34567_accessibility
    • Rank:
      43000

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Rosie,

          I'm not sure that the ids on these labels are right, it doesn't look the same to me:

          $menu = html_writer::label(get_string('assignment:grade', 'assignment'), 'menumenu'. $auser->id, false, array('class' => ''));
          $menu .= html_writer::select(make_grades_menu($this->assignment->grade), 'menu['.$auser->id.']', $auser->grade, array(-1=>get_string('nograde')), $attributes);
          
          Show
          Dan Poltawski added a comment - Hi Rosie, I'm not sure that the ids on these labels are right, it doesn't look the same to me: $menu = html_writer::label(get_string('assignment:grade', 'assignment'), 'menumenu'. $auser->id, false , array('class' => '')); $menu .= html_writer::select(make_grades_menu($ this ->assignment->grade), 'menu['.$auser->id.']', $auser->grade, array(-1=>get_string('nograde')), $attributes);
          Hide
          Rossiani Wijaya added a comment -

          Hi Dan,

          The pasted code looks like from the assignment issue.

          I'll look into the assignment issue.

          Please let me know if you mean otherwise.

          Show
          Rossiani Wijaya added a comment - Hi Dan, The pasted code looks like from the assignment issue. I'll look into the assignment issue. Please let me know if you mean otherwise.
          Hide
          Dan Poltawski added a comment -

          Wow, i'm having a bad day today, sorry! Yep, could you look at the assignment issue, evne though i've already integrated it.

          Show
          Dan Poltawski added a comment - Wow, i'm having a bad day today, sorry! Yep, could you look at the assignment issue, evne though i've already integrated it.
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks Rosie.

          Show
          Dan Poltawski added a comment - Integrated, thanks Rosie.
          Hide
          David Monllaó added a comment -

          It passes. All the select elements have their corresponding labels. Tested in MOODLE_22_STABLE and master

          Show
          David Monllaó added a comment - It passes. All the select elements have their corresponding labels. Tested in MOODLE_22_STABLE and master
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: