Details

    • Testing Instructions:
      Hide
      1. As an admin or teacher, go to a course an create a wiki activity
      2. As an admin or teacher, go to the wiki and create the first page using the "Creole" format
      3. Select 'Files' tab then click on 'edit wiki files' button.
      4. Add some files and save it.
      5. Select 'edit' tab. The select element with the text "Insert an image" there SHOULD have a label with a "accesshide" class.
      Show
      As an admin or teacher, go to a course an create a wiki activity As an admin or teacher, go to the wiki and create the first page using the "Creole" format Select 'Files' tab then click on 'edit wiki files' button. Add some files and save it. Select 'edit' tab. The select element with the text "Insert an image" there SHOULD have a label with a "accesshide" class.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34569_accessibility
    • Rank:
      43002

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment -

          Hi Rosie,

          This doesn't look right to me. The dropdown says 'Insert an image', but the label says 'Add a tag'?

          I'm not sure that this select is actually going to work for screenreaders anyway. The fact it displays at all when there are no images to add seems silly to me.

          Also, can you add to the testing instructions should include how to add an image an use the dropdown.

          Show
          Dan Poltawski added a comment - Hi Rosie, This doesn't look right to me. The dropdown says 'Insert an image', but the label says 'Add a tag'? I'm not sure that this select is actually going to work for screenreaders anyway. The fact it displays at all when there are no images to add seems silly to me. Also, can you add to the testing instructions should include how to add an image an use the dropdown.
          Hide
          Michael de Raadt added a comment -

          Carrying over to the next sprint.

          Show
          Michael de Raadt added a comment - Carrying over to the next sprint.
          Hide
          David Monllaó added a comment -

          Hi Rossie, looks good, submitting for integration review as we talked

          Show
          David Monllaó added a comment - Hi Rossie, looks good, submitting for integration review as we talked
          Hide
          David Monllaó added a comment -

          Note for integrator: Hi, friday I just check the code changes, but I forgot to check if all the wiki text and select elements has their label, I going to do it know and I comment when it's done, sorry for the inconvenience

          Show
          David Monllaó added a comment - Note for integrator: Hi, friday I just check the code changes, but I forgot to check if all the wiki text and select elements has their label, I going to do it know and I comment when it's done, sorry for the inconvenience
          Hide
          David Monllaó added a comment -

          Note for integrator: I've didn't find more text or select elements without label so it's all ok for me

          Show
          David Monllaó added a comment - Note for integrator: I've didn't find more text or select elements without label so it's all ok for me
          Hide
          Dan Poltawski added a comment -

          Integrated, thanks.

          Show
          Dan Poltawski added a comment - Integrated, thanks.
          Hide
          David Monllaó added a comment -

          It passes in master and 22. One less accessibility issue!

          Show
          David Monllaó added a comment - It passes in master and 22. One less accessibility issue!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          YEAR!*

          CAF*, TOT!*

          • Your effort amazingly resulted. (unbelievable :-P)
          • Closing as fixed.
          • Tons of thanks.
          Show
          Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: