Details

    • Testing Instructions:
      Hide

      Make sure select and input text in the following area contains <label> which make sense:

      • site admin > reports > course overview
      • site admin > reports > logs
      • site admin > reports > statistics (docs for setting up statistic reports: http://docs.moodle.org/23/en/Statistics)
      • course participant list (Navigation > somecourse > reports > course participation)
      • from course participant list above, select an activity, when list of user is displayed, make sure the select input has label.
      Show
      Make sure select and input text in the following area contains <label> which make sense: site admin > reports > course overview site admin > reports > logs site admin > reports > statistics (docs for setting up statistic reports: http://docs.moodle.org/23/en/Statistics ) course participant list (Navigation > somecourse > reports > course participation) from course participant list above, select an activity, when list of user is displayed, make sure the select input has label.
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34571_accessibility

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

            This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

            This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

            Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
            Hide
            poltawski Dan Poltawski added a comment -

            Hi Rosie,

            The testing instructions aren't including all the areas affected by the patch (stats, course overview, participation)

            Show
            poltawski Dan Poltawski added a comment - Hi Rosie, The testing instructions aren't including all the areas affected by the patch (stats, course overview, participation)
            Hide
            cibot CiBoT added a comment -

            Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

            Show
            cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Rebase patch.

            Assigning David as peer reviewer.

            Show
            rwijaya Rossiani Wijaya added a comment - Rebase patch. Assigning David as peer reviewer.
            Hide
            dmonllao David Monllaó added a comment -

            Hi Rossie,

            I "grepped" around all the report/ folder without finding anything to write I've also check the UI of the modified reports (log, courseoverview and stats)

            Show
            dmonllao David Monllaó added a comment - Hi Rossie, I "grepped" around all the report/ folder without finding anything to write I've also check the UI of the modified reports (log, courseoverview and stats)
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Thanks David for reviewing.

            Submitting for integration review.

            Show
            rwijaya Rossiani Wijaya added a comment - Thanks David for reviewing. Submitting for integration review.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

            This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

            This is a bulk-automated message, so if you want to blame some-body/thing/where, don't do it here (use git instead) :-D :-P

            Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame some-body/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

            This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

            This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

            Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
            Hide
            nebgor Aparup Banerjee added a comment -

            As discussed, reopening to ensure use of html_writer as much as possible.

            see report/courseoverview/index.php line 85 in patch.

            Show
            nebgor Aparup Banerjee added a comment - As discussed, reopening to ensure use of html_writer as much as possible. see report/courseoverview/index.php line 85 in patch.
            Hide
            cibot CiBoT added a comment -

            Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

            Show
            cibot CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Update patch for master to use html_writer.

            Show
            rwijaya Rossiani Wijaya added a comment - Update patch for master to use html_writer.
            Hide
            abgreeve Adrian Greeve added a comment -

            Hi Rossie,

            Just a couple of things:

            1. report/participation/index.php line 306 - I think that you have entered in 'formactionselect' twice here and so we have notices that withselectedusers is undefined.
            2. report/stats/locallib.php line 132, 133, 137, 138, 142, 143 and 144 don't have spaces after commas.

            Besides that, everything else looks fine.

            Thanks.

            Show
            abgreeve Adrian Greeve added a comment - Hi Rossie, Just a couple of things: report/participation/index.php line 306 - I think that you have entered in 'formactionselect' twice here and so we have notices that withselectedusers is undefined. report/stats/locallib.php line 132, 133, 137, 138, 142, 143 and 144 don't have spaces after commas. Besides that, everything else looks fine. Thanks.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Thanks Adrian for reviewing.

            Update patch.

            sending for integration review.

            Show
            rwijaya Rossiani Wijaya added a comment - Thanks Adrian for reviewing. Update patch. sending for integration review.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

            This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

            This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

            Apologises for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologises for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
            Hide
            poltawski Dan Poltawski added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            poltawski Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            poltawski Dan Poltawski added a comment -

            I've integrated this now.

            Please ensure that this is well tested on all branches.

            Show
            poltawski Dan Poltawski added a comment - I've integrated this now. Please ensure that this is well tested on all branches.
            Hide
            andyjdavis Andrew Davis added a comment -

            Looks good. I've raised 2 issues which I have linked back to this issue.

            Show
            andyjdavis Andrew Davis added a comment - Looks good. I've raised 2 issues which I have linked back to this issue.
            Hide
            poltawski Dan Poltawski added a comment -

            Congratulations, you've done it!

            Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc

            Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

            Show
            poltawski Dan Poltawski added a comment - Congratulations, you've done it! Nf n erjneq sbe fhpprfshy vagrtengvba vagb guvf jrrxf eryrnfr, V pna abj qvfpybfr gb lbh gur rkvfgnapr bs shapgvba fge_ebg13(), gb tb va lbhe gbbyxvg nybat jvgu uggc://cuc.arg/znahny/ra/shapgvba.tmtrgff.cuc Cyrnfr qb abg nyybj guvf vasbezngvba gb cnff shegure.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  12/Nov/12