Details

    • Testing Instructions:
      Hide

      Make sure select and input text in the following area contains <label>:

      • alfresco - search page
      • draft file
      • file picker

      Test the behaviour and ensure the functionality is still working

      Show
      Make sure select and input text in the following area contains <label>: alfresco - search page draft file file picker Test the behaviour and ensure the functionality is still working
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34572_accessibility
    • Rank:
      43005

      Description

      There are several select input fields that do not have labels explicitly tied to them. Often this is because there is a visual cue as to what information is being asked for but the visual cue is not explicitly linked to the input element.

      Because this problem is sporadic it might be necessary to break this task out into smaller sub-tasks for each instance of the problem.

      Here is a tutorial for methods of labeling text input elements. http://oit.ncsu.edu/itaccess/forms#select

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

          This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody.

          This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P

          Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday. This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P Apologizes for the inconvenient, this will be integrated next week. Thanks for your collaboration & ciao
          Hide
          Dan Poltawski added a comment -

          Hi Rosie,

          I think the 'space' string for alfresco might be a bit ambitious really. Perhaps we could use something more specific.

          Show
          Dan Poltawski added a comment - Hi Rosie, I think the 'space' string for alfresco might be a bit ambitious really. Perhaps we could use something more specific.
          Hide
          CiBoT added a comment -

          Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.

          Show
          CiBoT added a comment - Moving this reopened issue out from current integration. Please, re-submit it for integration once ready.
          Hide
          Rossiani Wijaya added a comment -

          This issue is being block by MDL-35504.

          Show
          Rossiani Wijaya added a comment - This issue is being block by MDL-35504 .
          Hide
          Rossiani Wijaya added a comment -

          Hi Dan,

          I attached a screenshot for Alfresco repo. Perhaps we could use 'Workspace' as the label for it?

          Show
          Rossiani Wijaya added a comment - Hi Dan, I attached a screenshot for Alfresco repo. Perhaps we could use 'Workspace' as the label for it?
          Hide
          Rossiani Wijaya added a comment -

          I talked with Dan and decided that 'Space' is the best label for it.

          Re-submitting this for integration review.

          Show
          Rossiani Wijaya added a comment - I talked with Dan and decided that 'Space' is the best label for it. Re-submitting this for integration review.
          Hide
          Dan Poltawski added a comment -

          Thanks Rosie, i've integrated this now.

          As discussed, only in 2.4 as I do not believe the benefit of adding these labels outweighs the downside of having untranslated strings ppart way through stable release for non-english speakers.

          Show
          Dan Poltawski added a comment - Thanks Rosie, i've integrated this now. As discussed, only in 2.4 as I do not believe the benefit of adding these labels outweighs the downside of having untranslated strings ppart way through stable release for non-english speakers.
          Hide
          Mark Nelson added a comment -

          There were labels present. Passed.

          Show
          Mark Nelson added a comment - There were labels present. Passed.
          Hide
          Mark Nelson added a comment -

          Hi Rossi, after our discussion today I suggest adding the CSS class accesshide to the alfresco 'space' label, as it is not needed for those who can clearly see the select area.

          Show
          Mark Nelson added a comment - Hi Rossi, after our discussion today I suggest adding the CSS class accesshide to the alfresco 'space' label, as it is not needed for those who can clearly see the select area.
          Hide
          Dan Poltawski added a comment -

          MArk, i've pulled in that change.

          Show
          Dan Poltawski added a comment - MArk, i've pulled in that change.
          Hide
          Rossiani Wijaya added a comment -

          Hi Mark,

          Thank you for the feedback.

          I added the patch to Master only.

          Show
          Rossiani Wijaya added a comment - Hi Mark, Thank you for the feedback. I added the patch to Master only.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Amazed. Inspired. Grateful. That’s how your generosity makes me feel.

          (not really)

          Closing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Amazed. Inspired. Grateful. That’s how your generosity makes me feel. (not really) Closing, thanks!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: