Moodle
  1. Moodle
  2. MDL-34583

Feedback lost during assignment (2.2) to assign upgrade

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.4
    • Fix Version/s: 2.3.2
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide
      1. Create an instance of the old offline assignment type (Assignment 2.2).
      2. Grade a student and provide a feedback comment
      3. Upgrade the assignment using the upgrade tool
      4. Check that feedback comments are enabled and the feedback comment for the student has been retained in the new assignment
      5. Create an instance of the old online assignment type (Assignment 2.2). Enable "comment inline"
      6. Grade a student and provide a feedback comment
      7. Upgrade the assignment using the upgrade tool
      8. Check that feedback comments are enabled and the feedback comment for the student has been retained in the new assignment
      Show
      Create an instance of the old offline assignment type (Assignment 2.2). Grade a student and provide a feedback comment Upgrade the assignment using the upgrade tool Check that feedback comments are enabled and the feedback comment for the student has been retained in the new assignment Create an instance of the old online assignment type (Assignment 2.2). Enable "comment inline" Grade a student and provide a feedback comment Upgrade the assignment using the upgrade tool Check that feedback comments are enabled and the feedback comment for the student has been retained in the new assignment
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:

      Description

      Offline assignments and Online Text assignments loose all feedback during the update process, which is completely lost from the DB.

      On our site, we lost 30,000+ feedbacks - we are working on a tool to bring them from a DB back into the new assignment, but this is a pretty major dataloss event.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Michael de Raadt added a comment -

            Hi, Eric.

            Do you mean feedback comments or attached feedback files?

            Show
            Michael de Raadt added a comment - Hi, Eric. Do you mean feedback comments or attached feedback files?
            Hide
            Eric Merrill added a comment -

            Comments, but I haven't looked into files

            Show
            Eric Merrill added a comment - Comments, but I haven't looked into files
            Hide
            Damyon Wiese added a comment -

            Thanks for reporting this - not sure how I missed it.

            Show
            Damyon Wiese added a comment - Thanks for reporting this - not sure how I missed it.
            Hide
            Adrian Greeve added a comment -

            Hi Damyon,

            I went over the code and tested everything out. It works with no problems.
            Thanks for the quick fix.

            Show
            Adrian Greeve added a comment - Hi Damyon, I went over the code and tested everything out. It works with no problems. Thanks for the quick fix.
            Hide
            Damyon Wiese added a comment -

            This looks OK for integration - I just rebased it.

            Show
            Damyon Wiese added a comment - This looks OK for integration - I just rebased it.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks! (23 & master)

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (23 & master)
            Hide
            Tim Barker added a comment -

            Tested as per testing instructions and apart from noticing an unrelated, existing issue, everything was fine .

            Show
            Tim Barker added a comment - Tested as per testing instructions and apart from noticing an unrelated, existing issue, everything was fine .
            Hide
            Eloy Lafuente (stronk7) added a comment -

            For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

            Many thanks for your collaboration, yay!

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao
            Hide
            Richard van Iwaarden added a comment - - edited

            Does this also correct missing feedback? We have already upgraded all our old 2.2 assignments to the new 2.3 assignments, losing lots of feedback and grades.

            Will a Moodle upgrade get the feedback and grades back in the gradelist?

            Show
            Richard van Iwaarden added a comment - - edited Does this also correct missing feedback? We have already upgraded all our old 2.2 assignments to the new 2.3 assignments, losing lots of feedback and grades. Will a Moodle upgrade get the feedback and grades back in the gradelist?
            Hide
            Richard van Iwaarden added a comment -

            Please see my forumpost here for screenshots.
            https://moodle.org/mod/forum/discuss.php?d=213430

            Is this the same bug?

            Show
            Richard van Iwaarden added a comment - Please see my forumpost here for screenshots. https://moodle.org/mod/forum/discuss.php?d=213430 Is this the same bug?

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: