I created a demo test. Does the same for me on qa site. Windows 7/Chrome. When it fails, if I mouse over the taskbar and manually maximize the window, it can appear. Testing on Mac now.

Chrome on the Mac opens a very small window, but does allow it to be resized.

As a temporary fix I added this js for just the quiz-secure-window pages:
chrome = navigator.userAgent.toLowerCase().indexOf('chrome') > -1;
if (chrome)

I'm using jquery for some other functions for my site so this wasn't too hard to implement. I hope there is a more permanent fix we can find.

HI Tim - Jeff posted about this in the forums - I had issues with resizeto and SCORM code - more info on MDL-32388 if that's helpful.

Note that the quiz is using the Moodle core JS function openpopup, rather than re-implementing it.

https://github.com/timhunt/moodle/compare/master...MDL-34590 is my best guess on how to fix things, based on Dan's hint.

It works fine in FF and IE. On chrome it works better than before, but it is not quite right. The window that opens is too big. It looks like the web page area is the size of the screen, and then you ahve the windows re-size bars around that, so actually the window does not fit, and you can't see the bottom or right edges. I am not sure what to do about that.

I'll work on it later, but I think if we set it to window.innerWidth and window.innerHeight instead of screen.availWidth and Height, it might work better. Or, do a test for 0 in screen.availWidth and Height and use those as fall back. I'll try to integrate that later (possibly Monday) and prepare a patch.

Great. Thanks.

Well, your approach looks to be a better one, but here seems be the problem
http://code.google.com/p/chromium/issues/detail?id=2091

Chrome doesn't support resizeTo (and probably not moveTo if I keep looking). I'll see if there is another work around besides browser sniffing things.

Looks great and works fine

I would not describe my solution as a work-around. I think it is a better way to do things (open the pop-up at the right size to start with, rather than opening at a random size and then re-sizing it later).

But, despite what David says, it does not work fine. The new window is too big, at least on Windows.

I think I figured it out, but the branch got moved over to 2.4 and I wasn't going to update to 2.4 yet. So anyway, if you can figure out how to get this into the code I think it will work. Chrome can resize if you wrap them in a setTimeout. The other browsers don't seem to complain.
line 1189
if (!windowobj)

if (args.fullscreen) {
setTimeout(function()

, 0);
}

Thanks, I will try to test that tomorrow.

Hi,

Sorry Tim, I didn't realize that, in Windows, the new window height is adjusted to the screen size, not the available space in the screen. It seems that availHeight doesn't return the real available space that's why it's bigger than it should be, but after the resizeTo with setTimeout() it's reduced to the real available space (with Windows 7 and a 1280x960 screen the height is reduced from the availHeight = 920 to 914)

I haven't tried it in mac nor Windows XP.

Thanks all for your help. Submitting for integration now.

Seems to test out well
Windows 7
Chrome OK
Firefox 14 OK
IE 8 OK
Safari OK
XP
IE 6 OK
OS 10.7
Firefox 14 OK
Chrome OK
Safari 6 OK

When I try to checkout the MDL-34590_23 or MDL-34590_22 they are both based on 2.4 still. Maybe user error

Thanks for the testing!

The _22 and _23 branches are fine. E.g. on https://github.com/timhunt/moodle/commit/MDL-34590_22 click the 1 parent f2ddce97bd link to see all is well.

Integrated to 22, 23 and master, thanks everyone.

Doesn't seem to work as expected for me. This is in master.

Ubuntu 11.04
Chrome 21.0.1180.57

The popup window opens up unusably small at the top left of the screen. I'm attaching a screen shot.

I can resize the window and then it seems to work fine. I'm using the theme "formal white" just in case that is relevant.

Just to confirm you've tried to purge your caches completely Andrew?

(browser as well as moodle - i'm not sure if this file is served by our auto url changing scripts)

I've tested this with Chrome on OSX and its working ok. My suspicion is that its chrome overagressively caching.

Just to note I was developing on Windows 7, and I tested Chrome, FF and IE there.

I am just testing on MacOS, and the new code works fine in FF, Chrome and Safari.

Andrew, to test your browser is seeing the latest version of the code, you need to use Firebug (or the equivalent tool in other browsers) and look at the code the browser is using for the openpopup function in javascript-static.js, to make sure it matches the code in integration/master.

The question is, do we wait for Andrew to re-test, or do I create a Ubuntu VM?

I've cleared my cache (browser and Moodle), disabled caching in Chrome and restarted Chrome. Im still getting the problem unfortunately. The openpopup() function seems to match the version in integration/master. Here it is copied out of the browser.

function openpopup(event, args) {

    if (event) {

        if (event.preventDefault) {

            event.preventDefault();

        } else {

            event.returnValue = false;

        }

    }

    var fullurl = args.url;

    if (!args.url.match(/https?:\/\//)) {

        fullurl = M.cfg.wwwroot + args.url;

    }

    if (args.fullscreen) {

        args.options = args.options.

                replace(/top=\d+/, 'top=0').

                replace(/left=\d+/, 'left=0').

                replace(/width=\d+/, 'width=' + screen.availWidth).

                replace(/height=\d+/, 'height=' + screen.availHeight);

    }

    var windowobj = window.open(fullurl,args.name,args.options);

    if (!windowobj) {

        return true;

    }

    if (args.fullscreen) {

        setTimeout(function() {

            windowobj.moveTo(0, 0);

            windowobj.resizeTo(screen.availWidth, screen.availHeight)

        }, 0);

    }

    windowobj.focus();

    return false;

}

Thanks Andrew. Are you able to test moodle/master and see what the behaviour is there?

I'm just wondering if this has made the situation worse or just not resolved the problem on ubuntu (in which case i'll vote for leaving this is as we are making a step forward on major platforms, at least).

I'm afraid we have made the situation worse. I just tried this in master and the window opens in the top left but its a decent size.

Ankit tried this out and confirmed it.

Grrr! web browsers.

Did MDL-32388 get tested as thoroughly? Would be nice to know if Dan M's JS works.

yeah - my main machine runs Xubuntu and I tested Chrome with SCORM on mine and it worked last time I checked.... but I don't use any resize code anymore - SCORM just opens the new window and passes the height/width when opening the window.

I wondered if it was the move in your code that was causing the issues? - I tested this yesterday on my machine and I think I saw a flash of it opened large screen before it was moved.

So, actually, it is probably the resizeTo, not the moveTo, that is breaking things. Perhaps screen.availWidth and screen.availHeight return the wrong thing on Chrome / Ubuntu?

Thanks do Dan's testing, I think we have finally got it:

https://github.com/timhunt/moodle/compare/master...MDL-34590_grr

Dan has tested Chrome on Ubuntu.

I have tested FF, Chrome and IE8 on Windows 7.

Crap! I got an un-realated bug fix into the same commit. Will fix.

OK, should really be ready for integration now.

Tested on FF, Chrome and Safari, Mac. All ok too apparently. Proceeding with integration of the extra commit...

Integrated (22, 23 & master), thanks!

Test passed too (based on previous comments on Ubuntu, Win and Mac).

Fixed STOP Closed STOP Thanks STOP

Yay, imagination! Ciao

Alas, secure quizzes stopped working on Chrome this term.
In my 1.6.x the function is in javascript.php

function openpopup(url,name,options,fullscreen) {
fullurl = "<?php echo $CFG->httpswwwroot ?>" + url;
windowobj = window.open(fullurl,name,options);
if (fullscreen)

windowobj.focus();
return false;
}

The bit I think I need is from
https://github.com/moodle/moodle/blob/master/lib/javascript-static.js
(I have deleted the comments)

if (args.fullscreen) {
var hackcount = 100;
var get_size_exactly_right = function() {
windowobj.moveTo(0, 0);
windowobj.resizeTo(screen.availWidth, screen.availHeight);
if (hackcount > 0 && (windowobj.innerHeight < 10 || windowobj.innerWidth < 10))

}
setTimeout(get_size_exactly_right, 0);
}

Which I think should work in place of my "if(fullscreen)

" (and remove "args." of course)
Yes. Chrome on windows seems to work with the above but then it seems my issue is elsewhere.

The links to github for the diffs do not seem to work for me so I am posting this just in case
anyone wants to patch a legacy Moodle.

Tim