Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-32225 add plagiarism api hooks to other areas of Moodle code
  3. MDL-34593

add extra plugin param to plagiarism_get_form_elements_module()

    XMLWordPrintable

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Plagiarism
    • Labels:
    • Testing Instructions:
      Hide

      This can only be tested by a developer, no core code calls these functions.
      Also - the existing plagiarism plugins don't make use of this parameter (yet) - once this patch is accepted we'll patch the plugins to use the new param.

      Show
      This can only be tested by a developer, no core code calls these functions. Also - the existing plagiarism plugins don't make use of this parameter (yet) - once this patch is accepted we'll patch the plugins to use the new param.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      master_MDL-34593_add_extra_plugin_param_to_get_form_elements_module

      Description

      now that we've added hooks to various plugins we're finding the current method of obtaining the current module type is a bit fragile.

      We need to add an extra param to plagiarism_get_form_elements_module() called $plugin which contains the $module->component (frankenstyle name) - so in mod forum it would look like this:
      plagiarism_get_form_elements_module($mform, $ctx->get_course_context(), 'mod_forum');

        Attachments

          Activity

            People

            Assignee:
            danmarsden Dan Marsden
            Reporter:
            danmarsden Dan Marsden
            Integrator:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Tester:
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Participants:
            Component watchers:
            Dan Marsden, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              3/Dec/12