Moodle
  1. Moodle
  2. MDL-34606

Javascript error in buttons on Site administrators and Assign system roles pages

    Details

    • Testing Instructions:
      Hide
      1. Login as Admin
      2. Navigate to Site admin > Users > Permissions > Site admininstrators
      3. Use Firebug or an equivalent tool to inspect the code for the Clear buttons and make sure it has proper id
      4. Navigate to Site admin > Users > Permissions > Assign system roles
      5. Use Firebug or an equivalent tool to inspect the code for the Clear buttons and make sure it has proper id

      FYI:
      Clear button should be disabled by default, and when typed something should enable them.

      Show
      Login as Admin Navigate to Site admin > Users > Permissions > Site admininstrators Use Firebug or an equivalent tool to inspect the code for the Clear buttons and make sure it has proper id Navigate to Site admin > Users > Permissions > Assign system roles Use Firebug or an equivalent tool to inspect the code for the Clear buttons and make sure it has proper id FYI: Clear button should be disabled by default, and when typed something should enable them.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      wip-mdl-34606

      Description

      There's a clear control at the bottom of the user search boxes that lets you reset the search for users. It has a class id of "NaN_clearbutton". I assume they are supposed to be individually numbered but a javascript error has occured and returned NaN (Not a Number).

      Replication steps:

      1. Navigate to Site admin > Users > Permissions > Site admininstrators
      2. Use Firebug or an equivalent tool to inspect the code for the Clear buttons
      3. Navigate to Site admin > Users > Permissions > Assign system roles
      4. Use Firebug or an equivalent tool to inspect the code for the Clear buttons

        Gliffy Diagrams

          Activity

          Hide
          David Scotson added a comment -

          To be clear this is found here:

          /admin/roles/admins.php

          and here:

          /admin/roles/assign.php?contextid=1&roleid=1

          Show
          David Scotson added a comment - To be clear this is found here: /admin/roles/admins.php and here: /admin/roles/assign.php?contextid=1&roleid=1
          Hide
          Michael de Raadt added a comment -

          Thanks for spotting that.

          I was able to see the problem. The buttons seem to work regardless.

          Show
          Michael de Raadt added a comment - Thanks for spotting that. I was able to see the problem. The buttons seem to work regardless.
          Hide
          Frédéric Massart added a comment -

          Looks good Raj. Submitting for integration.

          Show
          Frédéric Massart added a comment - Looks good Raj. Submitting for integration.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (22, 23 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
          Hide
          Adrian Greeve added a comment -

          Tested on 2.2, 2.3 and master.
          No problems found.
          The clear button is working as expected.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested on 2.2, 2.3 and master. No problems found. The clear button is working as expected. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work.

          These changes have been spread upstream and are already available in the git and cvs repositories.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work. These changes have been spread upstream and are already available in the git and cvs repositories. Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: