Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34608

Uneditable form entries could use some extra markup e.g. span.uneditable-input

    XMLWordPrintable

    Details

    • Affected Branches:
      MOODLE_23_STABLE

      Description

      In Moodle's various forms occaisonally it will present uneditable text, e.g. I just edited my profile on our site and I don't have any choice of which authentication to use so it says "Choose an authentication method" and the text that follows is just plain gray text, not a text area or drop down to select from. Lower down the same form "Current Picture: None" is another example.

      These are usually inside a div.felement.fstatic just as e.g. text entry boxes are inside div.felement.ftext but in the editable case the text input is a <input> tag where the uneditable text is just immediately contained within the div.felement with no extra tags wrapping it. This gives this text one less layer of CSS targeting compared with the rest of the form.

      It would be good if this text was wrapped in span.uneditable-input to allow it to be styled as being within a container.

      I'll note also that some help text (e.g. the advice on the password rules in the same form) is currently marked up in exactly the same way i.e. div.felment.fstatic then just straight text. It wouldn't be appropriate if this was wrapped in span.uneditable-input, but perhaps could be wrapped in p.help-block tags instead.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              moodle.com moodle.com
              Reporter:
              bawjaws David Scotson
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Bas Brands
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated: