Moodle
  1. Moodle
  2. MDL-34624

.capdefault is missing from theme/base (found only on theme/standard)

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Select any CORE theme
      2. Go to Settings->Site administration-> Users->Permissions->Define roles
      3. Edit a role
      4. Enable "Show advanced" button.
      5. TEST that all default settings have a grey background with border.
      Show
      Select any CORE theme Go to Settings->Site administration-> Users->Permissions->Define roles Edit a role Enable "Show advanced" button. TEST that all default settings have a grey background with border.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
    • Rank:
      43062

      Description

      It seems more useful to have the ".capdefault" CSS rule (class) placed on theme/base/style/admin.css then on theme/standard/style/admin.css, Since all themes derived from theme/base and thus can enjoy this very useful UI "default capability highlight" feature.

      Currently, it is placed in side theme/standard (and theme/standard_white)
      (moodle/theme/standard/style/admin.css)

      #page-admin-roles-define .capdefault {background-color:#DDDDDD;border: 1px solid #CECECE;}
      

        Issue Links

          Activity

          Hide
          Mary Evans added a comment -

          @Nadav

          Thanks for reporting this. Can you also tell me where this css rule is used? I need to know this so I can write TEST INSTRUCTIONS?

          Show
          Mary Evans added a comment - @Nadav Thanks for reporting this. Can you also tell me where this css rule is used? I need to know this so I can write TEST INSTRUCTIONS?
          Hide
          Nadav Kavalerchik added a comment -

          It's in "HOME / ► SITE ADMINISTRATION / ► USERS / ► PERMISSIONS / ► DEFINE ROLES"
          http://your-moodle/admin/roles/define.php?action=edit&roleid=3
          And make sure you click the "Show Advanced" button.

          Show
          Nadav Kavalerchik added a comment - It's in "HOME / ► SITE ADMINISTRATION / ► USERS / ► PERMISSIONS / ► DEFINE ROLES" http://your-moodle/admin/roles/define.php?action=edit&roleid=3 And make sure you click the "Show Advanced" button.
          Hide
          Mary Evans added a comment -

          Got it thanks! I also found MDL-29403 where it was fixed last year.
          Reading the comment I left there reminded me that I forgot to add this fix to BASE theme!

          Show
          Mary Evans added a comment - Got it thanks! I also found MDL-29403 where it was fixed last year. Reading the comment I left there reminded me that I forgot to add this fix to BASE theme!
          Hide
          Mary Evans added a comment -

          I'll do it now!

          Show
          Mary Evans added a comment - I'll do it now!
          Hide
          Dan Poltawski added a comment -

          Thanks Mary/Nadav, i've integrated this now.

          Note that i've not backported into 2.1 as we are no longer accepting non-security bugfixes into this release.

          Show
          Dan Poltawski added a comment - Thanks Mary/Nadav, i've integrated this now. Note that i've not backported into 2.1 as we are no longer accepting non-security bugfixes into this release.
          Hide
          Andrew Davis added a comment -

          Looks good. Passing.

          Show
          Andrew Davis added a comment - Looks good. Passing.
          Hide
          Dan Poltawski added a comment -

          asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

          Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

          Show
          Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: