Details

    • Testing Instructions:
      Hide

      1/ set up main sending on test server, enable multilang
      2/ create course 1 and add self enrolment instance - enable send confirmation email with empty custom message
      3/ review the new help for custom message
      4/ create course 2 with plaintext enrol message
      5/ create course 3 with force non-default language with FORMAT_MOODLE markup and multilang that includes the force course langauge
      6/ log in as student and enrol into these 3 courses
      7/ verify 3 emails in different main clients

      Show
      1/ set up main sending on test server, enable multilang 2/ create course 1 and add self enrolment instance - enable send confirmation email with empty custom message 3/ review the new help for custom message 4/ create course 2 with plaintext enrol message 5/ create course 3 with force non-default language with FORMAT_MOODLE markup and multilang that includes the force course langauge 6/ log in as student and enrol into these 3 courses 7/ verify 3 emails in different main clients
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w32_MDL-34635_m24_selfwelcommultilang
    • Rank:
      43077

      Description

      As reported in the forums, if multilang tags are used in course titles, they appear as tags in welcome to the course emails.

      Forum discussions about this issue:
      http://moodle.org/mod/forum/discuss.php?d=151850
      http://moodle.org/mod/forum/discuss.php?d=208078

        Activity

        Hide
        Valentin Dumitru added a comment -

        Versions 1.9.x also affected, please include in fix.

        Show
        Valentin Dumitru added a comment - Versions 1.9.x also affected, please include in fix.
        Hide
        Petr Škoda added a comment -

        There are two problems:
        1/ the course titles are filtered with the system level filter settings - it is a bug, it has to use filter settings from the current course
        2/ the custom message is a plain text, but we support multilang only in HTML texts - so technically it is not a bug. I agree it would be better to allow text format selection there, I do not think we can just flip to html there. Unfortunately there is no free space in the enrol table to keep this flag, so the solution will be most probably in 2.4 only.

        1.9.x is not supported any more, it gets only serious security fixes, sorry.

        Show
        Petr Škoda added a comment - There are two problems: 1/ the course titles are filtered with the system level filter settings - it is a bug, it has to use filter settings from the current course 2/ the custom message is a plain text, but we support multilang only in HTML texts - so technically it is not a bug. I agree it would be better to allow text format selection there, I do not think we can just flip to html there. Unfortunately there is no free space in the enrol table to keep this flag, so the solution will be most probably in 2.4 only. 1.9.x is not supported any more, it gets only serious security fixes, sorry.
        Hide
        Petr Škoda added a comment -

        Hmm, or maybe we could treat the text as FORMAT_MOODLE and convert back to plain text format...

        Show
        Petr Škoda added a comment - Hmm, or maybe we could treat the text as FORMAT_MOODLE and convert back to plain text format...
        Hide
        Petr Škoda added a comment -

        Here is a patch that is ready for testing, please try it with different email clients.

        There are now 3 options:
        1/ default message
        2/ plain text message - no html tags (needed for full backwards compatibility)
        3/ FORMAT_MOODLE - if html tags found, supports multilang

        Helen: please review the new help string.

        If nobody helps with testing it will go into 2.4dev only...

        Ciao

        Show
        Petr Škoda added a comment - Here is a patch that is ready for testing, please try it with different email clients. There are now 3 options: 1/ default message 2/ plain text message - no html tags (needed for full backwards compatibility) 3/ FORMAT_MOODLE - if html tags found, supports multilang Helen: please review the new help string. If nobody helps with testing it will go into 2.4dev only... Ciao
        Hide
        Helen Foster added a comment -

        Thanks a lot Petr for your work on this issue.

        My suggestion for customwelcomemessage_help is as follows:

        A custom welcome message may be added as plain text or Moodle-auto format, including HTML tags and multi-lang tags.

        The following placeholders may be included in the message:

        • Course name {$a->coursename}
        • Link to user's profile page {$a->profileurl}
        Show
        Helen Foster added a comment - Thanks a lot Petr for your work on this issue. My suggestion for customwelcomemessage_help is as follows: A custom welcome message may be added as plain text or Moodle-auto format, including HTML tags and multi-lang tags. The following placeholders may be included in the message: Course name {$a->coursename} Link to user's profile page {$a->profileurl}
        Hide
        Petr Škoda added a comment -

        Thanks a lot Helen!

        Show
        Petr Škoda added a comment - Thanks a lot Helen!
        Hide
        Dan Poltawski added a comment -

        The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

        TIA and ciao

        Show
        Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
        Hide
        Valentin Dumitru added a comment -

        Thank you for your work on this issue. Unfortunately I am bound to version 1.9.11 (or 1.9.x) for a while, so I will not be able to benefit from it Maybe I will get resources to migrate to 2.x towards the end of the year.

        Show
        Valentin Dumitru added a comment - Thank you for your work on this issue. Unfortunately I am bound to version 1.9.11 (or 1.9.x) for a while, so I will not be able to benefit from it Maybe I will get resources to migrate to 2.x towards the end of the year.
        Hide
        Dan Poltawski added a comment -

        I've integrated this now, thanks.

        Show
        Dan Poltawski added a comment - I've integrated this now, thanks.
        Hide
        Tim Barker added a comment -

        Re-adding Jason, Sorry, no-one picked it up and it's OK for you to do it in the morning.

        Show
        Tim Barker added a comment - Re-adding Jason, Sorry, no-one picked it up and it's OK for you to do it in the morning.
        Hide
        Jason Fowler added a comment -

        All good

        Show
        Jason Fowler added a comment - All good
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Fixed STOP Closed STOP Thanks STOP

        Yay, imagination! Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

          People

          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: