Loading...

XML

Word

Printable

Affected Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
Fixed Branches:
MOODLE_22_STABLE, MOODLE_23_STABLE
Pull from Repository:
git://github.com/danmarsden/moodle.git
Pull Main Branch:
master_~~MDL-34656~~
Pull Main Diff URL:
https://github.com/danmarsden/moodle/compare/master...master_MDL-34656
Testing Instructions:
Hide

Add a SCORM to your page - easiest to test with scorm shown in current window and TOC displayed to the left.

Enter SCORM player.

Logout of Moodle on a seperate window - either by using logout link on current page but opening in new window or by having a separate moodle window open and logging out there.

click on a link in the TOC to load a different SCO (or the same SCO) in the iframe.

a message should be displayed stating the user isn't logged in - the login form should not load in the iframe.
Show
Add a SCORM to your page - easiest to test with scorm shown in current window and TOC displayed to the left. Enter SCORM player. Logout of Moodle on a seperate window - either by using logout link on current page but opening in new window or by having a separate moodle window open and logging out there. click on a link in the TOC to load a different SCO (or the same SCO) in the iframe. a message should be displayed stating the user isn't logged in - the login form should not load in the iframe.

Reproduce:

Run any SCORM-lesson.
Start working with any lesson page.
Click "Logout" by middle mouse button. Thats do logout, but tab with SCORM will remain on previous window.
Return to window contained SCORM-lesson.
Try move to any lesson-page.

Result:
Login form embedding into SCORM-frame.

Solving:
I manage it by adding next five lines at the start of login/index.php file:

echo '<script>

    var str = top.location.href;

    if (str.substr(str.length - 20, 20) == "mod/scorm/player.php") {

    top.location.href = str.substr(0, str.length - 20) + "login/index.php";

    }</script>';

That script manage problem, but I think it's not best way.

Participants:: Dan Marsden, Dan Poltawski, Eloy Lafuente (stronk7), Rossiani Wijaya, Yuriy Burka