Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide
      1. Add a SCORM to your page - easiest to test with scorm shown in current window and TOC displayed to the left.
      2. Enter SCORM player.
      3. Logout of Moodle on a seperate window - either by using logout link on current page but opening in new window or by having a separate moodle window open and logging out there.
      4. click on a link in the TOC to load a different SCO (or the same SCO) in the iframe.
      5. a message should be displayed stating the user isn't logged in - the login form should not load in the iframe.
      Show
      Add a SCORM to your page - easiest to test with scorm shown in current window and TOC displayed to the left. Enter SCORM player. Logout of Moodle on a seperate window - either by using logout link on current page but opening in new window or by having a separate moodle window open and logging out there. click on a link in the TOC to load a different SCO (or the same SCO) in the iframe. a message should be displayed stating the user isn't logged in - the login form should not load in the iframe.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      master_MDL-34656

      Description

      Reproduce:

      1. Run any SCORM-lesson.
      2. Start working with any lesson page.
      3. Click "Logout" by middle mouse button. Thats do logout, but tab with SCORM will remain on previous window.
      4. Return to window contained SCORM-lesson.
      5. Try move to any lesson-page.

      Result:
      Login form embedding into SCORM-frame.

      Solving:
      I manage it by adding next five lines at the start of login/index.php file:

       
      echo '<script>
          var str = top.location.href;
          if (str.substr(str.length - 20, 20) == "mod/scorm/player.php") { 
          top.location.href = str.substr(0, str.length - 20) + "login/index.php"; 
          }</script>';

      That script manage problem, but I think it's not best way.

        Gliffy Diagrams

          Activity

          Hide
          Yuriy Burka added a comment -

          If you logout by middle mouse button, then try click "Лекция 2.Общая", login form embedding into SCORM-frame

          Show
          Yuriy Burka added a comment - If you logout by middle mouse button, then try click "Лекция 2.Общая", login form embedding into SCORM-frame
          Hide
          Dan Marsden added a comment -

          thanks for the report.

          Show
          Dan Marsden added a comment - thanks for the report.
          Hide
          Dan Marsden added a comment -

          bouncing this up for peer review.

          Show
          Dan Marsden added a comment - bouncing this up for peer review.
          Hide
          Dan Poltawski added a comment -

          It makes sense to me Dan. +1

          Show
          Dan Poltawski added a comment - It makes sense to me Dan. +1
          Hide
          Dan Marsden added a comment -

          Thanks Dan - btw - Peer review has been really fast recently - thanks for all the hard work.

          Bouncing this up for integration - I'm happy for this to go only into master but if the integrator really wants to cherry-pick to 2.2/2.3 that would be ok with me.

          Show
          Dan Marsden added a comment - Thanks Dan - btw - Peer review has been really fast recently - thanks for all the hard work. Bouncing this up for integration - I'm happy for this to go only into master but if the integrator really wants to cherry-pick to 2.2/2.3 that would be ok with me.
          Hide
          Yuriy Burka added a comment -

          Thanks for working and beauty solution.

          Show
          Yuriy Burka added a comment - Thanks for working and beauty solution.
          Hide
          Dan Poltawski added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Dan Poltawski added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (22, 23 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (22, 23 & master), thanks!
          Hide
          Rossiani Wijaya added a comment -

          This looks good.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This looks good. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: