Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34658

"Saving failed because missing or false values"

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Feedback
    • Labels:
    • Testing Instructions:
      Hide
      1. enable the feedback-module at Site-admin/Plugins/Activity modules/Manage activities
      2. create a new feedback activity
      3. create a numeric question with a range from greater 0 e.g. 10 to 20
      4. submit this feedback without a value
      5. It should be submitted without errors
      6. submit this feedback with a wrong value e.g. "5" or "abcde"
      7. It shouldn't be submitted
      Show
      enable the feedback-module at Site-admin/Plugins/Activity modules/Manage activities create a new feedback activity create a numeric question with a range from greater 0 e.g. 10 to 20 submit this feedback without a value It should be submitted without errors submit this feedback with a wrong value e.g. "5" or "abcde" It shouldn't be submitted
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34658-master

      Description

      I have created a feedback form with no compulsory questions. However, when one tries to submit an incomplete form, the following error message shows: "Saving failed because missing or false values". After a fair amount of Googling I'm still clueless. I'm using Moodle 2.3.1+ (Build: 20120726). Very thankful for any help!

        Gliffy Diagrams

          Attachments

          1. feedb settings.pdf
            258 kB
          2. q settings.pdf
            145 kB
          3. response.pdf
            108 kB

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Hi, Mikael.

            I tried this by creating a Feedback activity with a few questions (short text, long text, multiple choice), where none were required. I was able to submit an empty response from a student without seeing this message.

            Were there specific question types present in your feedback activity? Could you create a set of steps we could follow to replicate this problem?

            Show
            salvetore Michael de Raadt added a comment - Hi, Mikael. I tried this by creating a Feedback activity with a few questions (short text, long text, multiple choice), where none were required. I was able to submit an empty response from a student without seeing this message. Were there specific question types present in your feedback activity? Could you create a set of steps we could follow to replicate this problem?
            Hide
            alcarola Mikael Kurula added a comment -

            Thanks for your speedy response, Michael!

            A minimal example can be produced by creating a new Feedback activity and adding a numerical question to it. I attach the quiz and question settings, as well as the response on not filling the field in.

            I upgraded Moodle to Moodle 2.3.1+ (Build: 20120802) and the problem still persists. Not surprising, because git diff didn't show any changes to the feedback module since my previous version.

            Show
            alcarola Mikael Kurula added a comment - Thanks for your speedy response, Michael! A minimal example can be produced by creating a new Feedback activity and adding a numerical question to it. I attach the quiz and question settings, as well as the response on not filling the field in. I upgraded Moodle to Moodle 2.3.1+ (Build: 20120802) and the problem still persists. Not surprising, because git diff didn't show any changes to the feedback module since my previous version.
            Hide
            grabs Andreas Grabs added a comment -

            Thank you for reporting this.
            Andreas

            Show
            grabs Andreas Grabs added a comment - Thank you for reporting this. Andreas
            Hide
            alcarola Mikael Kurula added a comment -

            Andreas, thanks a lot for the speedy correction of this bug! I cherry-picked the MDL-34658-23 commit and all my feedback forms seem to work as expected now.

            Mikael

            Show
            alcarola Mikael Kurula added a comment - Andreas, thanks a lot for the speedy correction of this bug! I cherry-picked the MDL-34658 -23 commit and all my feedback forms seem to work as expected now. Mikael
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks Andreas, this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks Andreas, this has been integrated now.
            Hide
            ankit_frenz Ankit Agarwal added a comment -

            works as expected.
            Passing!
            Thanks

            Show
            ankit_frenz Ankit Agarwal added a comment - works as expected. Passing! Thanks
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Fixed STOP Closed STOP Thanks STOP

            Yay, imagination! Ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Sep/12