Moodle
  1. Moodle
  2. MDL-34670

undefined variable $type in feedback templates

    Details

    • Testing Instructions:
      Hide
      1. enable the feedback-module at Site-admin/Plugins/Activity modules/Manage activities
      2. create a new feedback activity
      3. add a question
      4. You have to ensure that no template exists. If one exists you have to delete all templates before next step.
      5. select the templates tab
      6. no undefined error occurs.
      Show
      enable the feedback-module at Site-admin/Plugins/Activity modules/Manage activities create a new feedback activity add a question You have to ensure that no template exists. If one exists you have to delete all templates before next step. select the templates tab no undefined error occurs.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34670-master
    • Rank (Obsolete):
      43159

      Description

      This occurs when there's no defined template available for feedback.
      Notice: Undefined variable: type in /master/lib/pear/HTML/QuickForm/group.php on line 277

      To re-produce:

      1. create a new feedback activity
      2. add a question
      3. select the templates tab
        undefined error occurs.

        Issue Links

          Activity

          Hide
          Andreas Grabs added a comment -

          Thank you for reporting this.
          Andreas

          Show
          Andreas Grabs added a comment - Thank you for reporting this. Andreas
          Hide
          Sam Hemelryk added a comment -

          Thanks Andreas, this has been integrated now.

          Show
          Sam Hemelryk added a comment - Thanks Andreas, this has been integrated now.
          Hide
          Ankit Agarwal added a comment -

          working as expected.
          Thanks

          Show
          Ankit Agarwal added a comment - working as expected. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: