Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34671

Pressing Escape in modal dialogues causes full screen to exit in some browsers

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      Using both of the following browsers (and any other browsers you think may be affected):

      • Opera under Windows
      • Safari under MacOS
      • Make your browser full screen
      • Open a course
      • Turn editing on
      • Open the Module Chooser
      • Press escape
        • Confirm that the module chooser closes but the window does not change out of full screen
      • On an existing resource, use the quick rename function in the toolbox
      • Press escape
        • Confirm that the quick rename cancels but the window does not change out of full screen
      Show
      Using both of the following browsers (and any other browsers you think may be affected): Opera under Windows Safari under MacOS Make your browser full screen Open a course Turn editing on Open the Module Chooser Press escape Confirm that the module chooser closes but the window does not change out of full screen On an existing resource, use the quick rename function in the toolbox Press escape Confirm that the quick rename cancels but the window does not change out of full screen
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      If you're using some browsers and are in full screen with a modal dialogue open, pressing escape should close the modal dialogue but not exit full screen.
      I've seen this with:

      • Opera under Windows
      • Safari under Chrome

      and in the following dialogues (and other locations):

      • modchooser (moodle-core-chooserdialogue)
      • filepicker
      • resource toolbox rename tool

      In both the modchooser and toolbox it's simply a case of changing the onkeyup event to an onkeydown event (keyup is too late to prevent the default browser action).

      I haven't managed to figure out what's triggering the filepicker being closed on escape yet.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              dobedobedoh Andrew Nicols
              Peer reviewer:
              Frédéric Massart
              Integrator:
              Sam Hemelryk
              Tester:
              Aparup Banerjee
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Mar/13