Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34680

The labels for the completion percentages are outside the label tags

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      0. Ensure that conditional availability is enabled at system level.
      1. On a test course, select to add a new Page.
      2. Look at the 'Restrict access' area of the form, by the 'Grade condition' label.
      + It should show something like '...must be at least BOX % and less than BOX %', where BOX indicate edit boxes. This is unchanged from previous behaviour.
      3. Click on the 'must be at least' text and then the 'and less than' text.
      + Clicking on the text should cause the relevant edit box to be focused.
      4. Validate the page (e.g. using Firebug 'Tools / Validate Local HTML').
      + There will be some errors, because Moodle pages are usually not valid, but these errors should not be related to the specific area of code where these HTML changes were made.

      Show
      0. Ensure that conditional availability is enabled at system level. 1. On a test course, select to add a new Page. 2. Look at the 'Restrict access' area of the form, by the 'Grade condition' label. + It should show something like '...must be at least BOX % and less than BOX %', where BOX indicate edit boxes. This is unchanged from previous behaviour. 3. Click on the 'must be at least' text and then the 'and less than' text. + Clicking on the text should cause the relevant edit box to be focused. 4. Validate the page (e.g. using Firebug 'Tools / Validate Local HTML'). + There will be some errors, because Moodle pages are usually not valid, but these errors should not be related to the specific area of code where these HTML changes were made.
    • Affected Branches:
      MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-34680-master

      Description

      When you turn on conditional access in advanced settings, you get some new options when setting up resources under the Restrict Access heading.

      The new option lets you choose a type of grade and set minimum and maximum percentages. The text "must be at least ___%" and "and less than ___%" are the labels for the entry boxes (marked with ___ in this text) but are outside the empty label tags that exist for those input fields.

      Ideally the entire input including the text on both sides of it would be contained within the label. Moodle seems to generally opt for a seperate label tag that points to the input field with an id. Sometimes this is necessary, but when it's not it's probably better to use the other method. In this case I think it would stop the % sign from dropping onto the next line when space is tight.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              bawjaws David Scotson
              Integrator:
              Aparup Banerjee
              Participants:
              Component watchers:
              Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze, Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated: