Moodle
  1. Moodle
  2. MDL-34691

Time remaining Assignment is overdue by

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.3.1
        • Fix Version/s: 2.3.2
        • Component/s: Assignment
        • Labels:
        • Testing Instructions:
          Hide
          1. As the teacher create an Assignment in a course that is due a few minutes from now.
          2. As a student submit a file for the assignment before the due data time.
          3. After the assignment is due go back to the assignment as the student.

          [Test]
          Under Time Remaining there should be a message saying "Assignment was submitted X mins X sec early".
          Make sure that it doesn't say "Assignment is overdue by: X mins X secs".

          Show
          As the teacher create an Assignment in a course that is due a few minutes from now. As a student submit a file for the assignment before the due data time. After the assignment is due go back to the assignment as the student. [Test] Under Time Remaining there should be a message saying "Assignment was submitted X mins X sec early". Make sure that it doesn't say "Assignment is overdue by: X mins X secs".
        • Affected Branches:
          MOODLE_23_STABLE
        • Fixed Branches:
          MOODLE_23_STABLE
        • Pull from Repository:
        • Pull Master Branch:
          MDL-34691_assign_overdue_by
        • Pull Master Diff URL:
        • Rank:
          43149

          Description

          While logged in as the actual student, view a previously submitted assignment that is past the due date. The Time remaining field is red and says "Assignment is overdue by: X days X hour". It should say "Assignment was submitted X mins X sec early"

          Replication steps

          1. As the teacher create an Assignment in a course that is due a few minutes from now.
          2. As a student submit a file for the assignment.
          3. After the assignment is due go back to the assignment as the student.

          Under Time Remaining I expected "Assignment was submitted 1 mins 1 sec early".
          What actually happens "Assignment is overdue by: 3 mins 25 secs".

          1. Text File
            mdl-34691.patch
            0.8 kB
            Nigel Cunningham

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Matthew G. Switlik added a comment -

            It was an easy fix. https://github.com/SWiT/moodle/tree/MDL-34691_assign_overdue_by

            I'm new to the moodle/github development setup. What should I do next? Are my branch names and commit messages ok?

            Show
            Matthew G. Switlik added a comment - It was an easy fix. https://github.com/SWiT/moodle/tree/MDL-34691_assign_overdue_by I'm new to the moodle/github development setup. What should I do next? Are my branch names and commit messages ok?
            Hide
            Permalink
            Michael de Raadt added a comment -

            Thanks for spotting that and providing a solution.

            If you could provide replication and testing steps, this issue would be ready to integrate.

            Show
            Michael de Raadt added a comment - Thanks for spotting that and providing a solution. If you could provide replication and testing steps, this issue would be ready to integrate.
            Hide
            Permalink
            Matthew G. Switlik added a comment -

            I updated the description and made testing instructions. Is there anything else I should fill in?

            Show
            Matthew G. Switlik added a comment - I updated the description and made testing instructions. Is there anything else I should fill in?
            Hide
            Permalink
            Andrew Davis added a comment -

            Looks good. Submit for integration whenever you're ready.

            Show
            Andrew Davis added a comment - Looks good. Submit for integration whenever you're ready.
            Hide
            Permalink
            Nigel Cunningham added a comment -

            You also need brackets around the string comparison, at least in my version of PHP (5.4.4-2).

            Show
            Nigel Cunningham added a comment - You also need brackets around the string comparison, at least in my version of PHP (5.4.4-2).
            Hide
            Permalink
            Nigel Cunningham added a comment -

            Updated patch that works for me.

            Show
            Nigel Cunningham added a comment - Updated patch that works for me.
            Hide
            Permalink
            Dan Poltawski added a comment -

            Hi,

            Damyon (mod_assign component maintainer) hasn't been involved/added as a watcher to this issue.

            I've added him to have a look.

            Show
            Dan Poltawski added a comment - Hi, Damyon (mod_assign component maintainer) hasn't been involved/added as a watcher to this issue. I've added him to have a look.
            Hide
            Permalink
            Dan Poltawski added a comment -

            I'm reopening this because Damyon was not involved at all in this issue.

            Note that he has been working on some other issues related to this change on other bugs, so we must try and coordinate better with the component maintainer.

            Show
            Dan Poltawski added a comment - I'm reopening this because Damyon was not involved at all in this issue. Note that he has been working on some other issues related to this change on other bugs, so we must try and coordinate better with the component maintainer.
            Hide
            Permalink
            Damyon Wiese added a comment -

            Thanks Dan - it looks OK to me.

            Show
            Damyon Wiese added a comment - Thanks Dan - it looks OK to me.
            Hide
            Permalink
            Adrian Greeve added a comment -

            Thanks Damyon for having a look at this.

            Submitting for integration.

            Show
            Adrian Greeve added a comment - Thanks Damyon for having a look at this. Submitting for integration.
            Hide
            Permalink
            Dan Poltawski added a comment -

            Great, thanks everyone i've integrated this now (23 and master)

            Show
            Dan Poltawski added a comment - Great, thanks everyone i've integrated this now (23 and master)
            Hide
            Permalink
            Tim Barker added a comment -

            Works perfectly as described.

            Show
            Tim Barker added a comment - Works perfectly as described.
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            YEAR!*

            CAF*, TOT!*

            • Your effort amazingly resulted. (unbelievable :-P)
            • Closing as fixed.
            • Tons of thanks.
            Show
            Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.
            Hide
            Permalink
            Stephen Porter added a comment -

            Thanks to everyone for a quick resolution!

            Show
            Stephen Porter added a comment - Thanks to everyone for a quick resolution!

              People

              • Votes:
                5 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: