Moodle
  1. Moodle
  2. MDL-34692

Assignment Submission agreement should not be visible if the submission statement is empty

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.4
    • Fix Version/s: 2.4
    • Component/s: Assignment
    • Labels:
    • Testing Instructions:
      Hide

      Go to "Site admininstration -> Plugins -> Activity Modules -> Assignment"
      Set the submission statement to empty and set "Require that students accept the submission statement" to On
      Create an assignment
      Login as a student and submit to the assignment.
      You should not be required to accept a blank submission statement.

      Show
      Go to "Site admininstration -> Plugins -> Activity Modules -> Assignment" Set the submission statement to empty and set "Require that students accept the submission statement" to On Create an assignment Login as a student and submit to the assignment. You should not be required to accept a blank submission statement.
    • Affected Branches:
      MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:

      Description

      The form elements included with an assignment submission for getting a student's agreement to the authorship statement should not be visible when there is no submission statement. Also, this element should not be validated.

      The global setting checkbox needs to be checked and the associated text statement should have a value before it is considered valid. Unfortunately we cannot validate this in the global configuration settings (which is another issue).

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Raymond Antonio added a comment -

            Hi,

            This is my proposed fix for this tracker. it sits on my github repo : MDL-34692

            https://github.com/raymondAntonio/moodle/tree/MDL-34692

            and here is the diff:

            https://github.com/raymondAntonio/moodle/commit/f6b88b1e060b04507982c5e52023491c45f1e445

            Cheers

            Show
            Raymond Antonio added a comment - Hi, This is my proposed fix for this tracker. it sits on my github repo : MDL-34692 https://github.com/raymondAntonio/moodle/tree/MDL-34692 and here is the diff: https://github.com/raymondAntonio/moodle/commit/f6b88b1e060b04507982c5e52023491c45f1e445 Cheers
            Hide
            Damyon Wiese added a comment -

            Hi Raymond,

            These changes:

            -        if (!empty($adminconfig->submissionstatement)) {
            -            $submissionstatement = $adminconfig->submissionstatement;
            -        }
            +        $submissionstatement = $adminconfig->submissionstatement;
            

            Could produce a warning if submissionstatement is not set and have no effect otherwise.

            Show
            Damyon Wiese added a comment - Hi Raymond, These changes: - if (!empty($adminconfig->submissionstatement)) { - $submissionstatement = $adminconfig->submissionstatement; - } + $submissionstatement = $adminconfig->submissionstatement; Could produce a warning if submissionstatement is not set and have no effect otherwise.
            Hide
            Raymond Antonio added a comment -

            Hi Damyon,

            Thanks for the feedback and here is the updated diff:
            https://github.com/raymondAntonio/moodle/commit/a9b94affd4b3b7f9c02a28d471907a047f059849

            Cheers

            Show
            Raymond Antonio added a comment - Hi Damyon, Thanks for the feedback and here is the updated diff: https://github.com/raymondAntonio/moodle/commit/a9b94affd4b3b7f9c02a28d471907a047f059849 Cheers
            Hide
            Damyon Wiese added a comment -

            This looks good Raymond, thanks.

            Show
            Damyon Wiese added a comment - This looks good Raymond, thanks.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
            Hide
            Sam Hemelryk added a comment -

            Hi guys,

            These changes look good.
            Before this can be integrated however can you please add some testing instructions to the issue.

            Also if you are happy to the git repo to pull from and branch to use. Those arn't required but its nice when they're there.

            Many thanks
            Sam

            Show
            Sam Hemelryk added a comment - Hi guys, These changes look good. Before this can be integrated however can you please add some testing instructions to the issue. Also if you are happy to the git repo to pull from and branch to use. Those arn't required but its nice when they're there. Many thanks Sam
            Hide
            Damyon Wiese added a comment -

            Thanks Sam - added test instructions and the repo.

            Show
            Damyon Wiese added a comment - Thanks Sam - added test instructions and the repo.
            Hide
            Sam Hemelryk added a comment -

            Thanks Damyon, this has been integrated now

            Show
            Sam Hemelryk added a comment - Thanks Damyon, this has been integrated now
            Hide
            Rajesh Taneja added a comment -

            Works Great,

            Thanks for fixing this Raymond and Damyon.

            Show
            Rajesh Taneja added a comment - Works Great, Thanks for fixing this Raymond and Damyon.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio

            This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

            Thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Gutta cavat lapidem, non vi sed saepe cadendo - Ovidio This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: