Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:
    • Rank:
      43163

      Description

      it is probably better to do the import early in case there are some regressions - they might be able to fix them in 3.6.1...

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -

          Sam: could you please have a look at https://github.com/skodak/moodle/commit/890e1aacc3b701fd5302c7dcf07bee21f7fbdf85 , I spent a long time looking for a YUI regression in the loader code, it seems that it breaks when it find a root property in the patter definition, so I just removed it and so far it seems to work fine. Do you know why 'root was added to our YUI module config in the first place?

          Show
          Petr Škoda added a comment - Sam: could you please have a look at https://github.com/skodak/moodle/commit/890e1aacc3b701fd5302c7dcf07bee21f7fbdf85 , I spent a long time looking for a YUI regression in the loader code, it seems that it breaks when it find a root property in the patter definition, so I just removed it and so far it seems to work fine. Do you know why 'root was added to our YUI module config in the first place?
          Hide
          Sam Hemelryk added a comment -

          Thanks Petr - this has been integrated now.

          In regards to the root being specified within a pattern I can't remember why it was there originally, and I couldn't find any reason not to remove it. Surely 100% safe and as it is causing issues required.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Thanks Petr - this has been integrated now. In regards to the root being specified within a pattern I can't remember why it was there originally, and I couldn't find any reason not to remove it. Surely 100% safe and as it is causing issues required. Cheers Sam
          Hide
          Rossiani Wijaya added a comment -

          This looks good.

          Test passed.

          Show
          Rossiani Wijaya added a comment - This looks good. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: