Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3
    • Fix Version/s: 2.4
    • Component/s: Libraries
    • Labels:

      Description

      it is probably better to do the import early in case there are some regressions - they might be able to fix them in 3.6.1...

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              skodak Petr Skoda created issue -
              skodak Petr Skoda made changes -
              Field Original Value New Value
              Status Open [ 1 ] Waiting for integration review [ 10010 ]
              Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w32_MDL-34701_m24_yui360
              Pull Master Branch w32_MDL-34701_m24_yui360
              Pull from Repository git://github.com/skodak/moodle.git
              Fix Version/s 2.4 [ 12255 ]
              Testing Instructions 1/ try the usual parts of UI that depend on YUI
              Hide
              skodak Petr Skoda added a comment -

              Sam: could you please have a look at https://github.com/skodak/moodle/commit/890e1aacc3b701fd5302c7dcf07bee21f7fbdf85 , I spent a long time looking for a YUI regression in the loader code, it seems that it breaks when it find a root property in the patter definition, so I just removed it and so far it seems to work fine. Do you know why 'root was added to our YUI module config in the first place?

              Show
              skodak Petr Skoda added a comment - Sam: could you please have a look at https://github.com/skodak/moodle/commit/890e1aacc3b701fd5302c7dcf07bee21f7fbdf85 , I spent a long time looking for a YUI regression in the loader code, it seems that it breaks when it find a root property in the patter definition, so I just removed it and so far it seems to work fine. Do you know why 'root was added to our YUI module config in the first place?
              skodak Petr Skoda made changes -
              Peer reviewer samhemelryk
              Affects Version/s 2.3 [ 10657 ]
              Affects Version/s 2.4 [ 12255 ]
              skodak Petr Skoda made changes -
              Link This issue blocks MDL-34700 [ MDL-34700 ]
              salvetore Michael de Raadt made changes -
              Labels triaged
              skodak Petr Skoda made changes -
              Link This issue blocks MDL-34741 [ MDL-34741 ]
              samhemelryk Sam Hemelryk made changes -
              Currently in integration Yes [ 10041 ]
              samhemelryk Sam Hemelryk made changes -
              Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
              Integrator samhemelryk
              Hide
              samhemelryk Sam Hemelryk added a comment -

              Thanks Petr - this has been integrated now.

              In regards to the root being specified within a pattern I can't remember why it was there originally, and I couldn't find any reason not to remove it. Surely 100% safe and as it is causing issues required.

              Cheers
              Sam

              Show
              samhemelryk Sam Hemelryk added a comment - Thanks Petr - this has been integrated now. In regards to the root being specified within a pattern I can't remember why it was there originally, and I couldn't find any reason not to remove it. Surely 100% safe and as it is causing issues required. Cheers Sam
              samhemelryk Sam Hemelryk made changes -
              Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
              timb Tim Barker made changes -
              Tester rwijaya
              rwijaya Rossiani Wijaya made changes -
              Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
              Hide
              rwijaya Rossiani Wijaya added a comment -

              This looks good.

              Test passed.

              Show
              rwijaya Rossiani Wijaya added a comment - This looks good. Test passed.
              rwijaya Rossiani Wijaya made changes -
              Status Testing in progress [ 10011 ] Tested [ 10006 ]
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Fixed STOP Closed STOP Thanks STOP

              Yay, imagination! Ciao

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao
              stronk7 Eloy Lafuente (stronk7) made changes -
              Status Tested [ 10006 ] Closed [ 6 ]
              Resolution Fixed [ 1 ]
              Currently in integration Yes [ 10041 ]
              Integration date 09/Aug/12

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12