Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34707

JavaScript included twice in the backup UI

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      1. Go to a course.

      2. Click Backup, then Next.

      3. Inspect the page using Firebug, and look in the last <script> tag in the HTML.

      4. Verify that there is only one call to M.core_backup.watch_cancel_buttons

      Show
      1. Go to a course. 2. Click Backup, then Next. 3. Inspect the page using Firebug, and look in the last <script> tag in the HTML. 4. Verify that there is only one call to M.core_backup.watch_cancel_buttons
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      This is despite the fact that there is a require_definition_after_data method that tries to prevent this.

      The problems is that some parts of formslib (e.g. get_data) call definition_after_data directly.

        Attachments

          Issue Links

          will help resolve

          Improvement - An enhancement to an existing Moodle feature. MDL-32705 No way to clear all checkboxes in backup schema settings

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-34727 Restore UI should use checkboxes for whether to restore userdata

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              timhunt Tim Hunt
              Reporter:
              timhunt Tim Hunt
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Michael de Raadt Michael de Raadt
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Sep/12