Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34707

JavaScript included twice in the backup UI

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Backup
    • Labels:
    • Testing Instructions:
      Hide

      1. Go to a course.

      2. Click Backup, then Next.

      3. Inspect the page using Firebug, and look in the last <script> tag in the HTML.

      4. Verify that there is only one call to M.core_backup.watch_cancel_buttons

      Show
      1. Go to a course. 2. Click Backup, then Next. 3. Inspect the page using Firebug, and look in the last <script> tag in the HTML. 4. Verify that there is only one call to M.core_backup.watch_cancel_buttons
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      This is despite the fact that there is a require_definition_after_data method that tries to prevent this.

      The problems is that some parts of formslib (e.g. get_data) call definition_after_data directly.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Sep/12