Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4, 2.3.1, 2.4
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      Test pre-requisites

      • WebDAV server supporting SSL (HTTPS) and set up with Digest authentication
      • WebDAV repository enabled
      • 2 different WebDAV instances in Moodle:
        • 'WebDAV Digest' which requires Digest authentication
        • 'WebDAV Digest SSL' which requires Digest authentication and HTTPS
      • Each share should contain multiple directories, sub directories, and files on every level.
      • Some directories and files must contain non-ascii characters

      Test steps

      1. Go to your private files
      2. Click on add
      3. Navigate to each WebDAV repository
      4. From each of them, make sure:
      • You can navigate in every directory
      • You can download any file
      • Files downloaded are correctly saved (check their content)
      Show
      Test pre-requisites WebDAV server supporting SSL (HTTPS) and set up with Digest authentication WebDAV repository enabled 2 different WebDAV instances in Moodle: 'WebDAV Digest' which requires Digest authentication 'WebDAV Digest SSL' which requires Digest authentication and HTTPS Each share should contain multiple directories, sub directories, and files on every level. Some directories and files must contain non-ascii characters Test steps Go to your private files Click on add Navigate to each WebDAV repository From each of them, make sure : You can navigate in every directory You can download any file Files downloaded are correctly saved (check their content)
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34715-master
    • Rank:
      43179

      Description

      WebDAV repository does not support Digest Authentication

        Issue Links

          Activity

          Hide
          Jason Fowler added a comment -

          there is an extra line of white space at the beginning of the new function - line 1320 in lib/webdavlib.php other than it's all good

          Show
          Jason Fowler added a comment - there is an extra line of white space at the beginning of the new function - line 1320 in lib/webdavlib.php other than it's all good
          Hide
          Frédéric Massart added a comment -

          Thanks Jason! Pushing for integration.

          Show
          Frédéric Massart added a comment - Thanks Jason! Pushing for integration.
          Hide
          Aparup Banerjee added a comment -

          Hi Fred,
          thanks, thats been integrated into master.

          Also integrated into 23 and 22 seeing that digest support should be a very isolated failure and wouldn't risk stability much mroe than its helping there. I think this will also get more exposure being in stable.

          Show
          Aparup Banerjee added a comment - Hi Fred, thanks, thats been integrated into master. Also integrated into 23 and 22 seeing that digest support should be a very isolated failure and wouldn't risk stability much mroe than its helping there. I think this will also get more exposure being in stable.
          Hide
          Michael de Raadt added a comment -

          Test result: Success!

          Tested in 2.2, 2.3 and master.

          Show
          Michael de Raadt added a comment - Test result: Success! Tested in 2.2, 2.3 and master.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fixed STOP Closed STOP Thanks STOP

          Yay, imagination! Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Fixed STOP Closed STOP Thanks STOP Yay, imagination! Ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: