Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-34733

Clicking either "Finish Review" button results in a 404 to /mod/quiz/0

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3, 2.3.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      Note that a different fix was done on stable branches (22 and 23) and master, so please test both versions carefully.

      1. Create a quiz with Browser security set to Full screen pop-up with some JavaScript protection. Make sure the review options allow the attempt to be reviewed.

      2. Add some questions to the quiz.

      3. Preview the quiz as teacher, work all the way through:

      3a. Start on the view.php page and click Start attempt.
      3b. Answer all the questions, clicking next, to end up on the summary page.
      3c. Click submit all and finish.
      3d. Click the finish review link, either in the navigation panel, or at the bottom of the last page of the quiz.
      3e. Make sure that you get back to the view.php page.

      4. Repeat 4, but as a student. The attempt should open in a pop-up window, and at the end of the review, the pop-up should close when you click the finish review button.

      Show
      Note that a different fix was done on stable branches (22 and 23) and master, so please test both versions carefully. 1. Create a quiz with Browser security set to Full screen pop-up with some JavaScript protection. Make sure the review options allow the attempt to be reviewed. 2. Add some questions to the quiz. 3. Preview the quiz as teacher, work all the way through: 3a. Start on the view.php page and click Start attempt. 3b. Answer all the questions, clicking next, to end up on the summary page. 3c. Click submit all and finish. 3d. Click the finish review link, either in the navigation panel, or at the bottom of the last page of the quiz. 3e. Make sure that you get back to the view.php page. 4. Repeat 4, but as a student. The attempt should open in a pop-up window, and at the end of the review, the pop-up should close when you click the finish review button.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Pull Master Diff URL:

      Description

      As teacher, review a quiz attempt and it will redirect to /mod/quiz/0 and result in a 404.

      I've tested this on my main site and on a demo site and it works the same and in Firefox and Chrome. It just fails in IE8 and does nothing and complains about a problem in module.js.

      It appears that #secureclosebutton is setup to close the secure window mod/quiz/module.js line 272. I assume this is the root of the problem. When I step through the debugger, it appears that the url gets set to "0".

      Anyone else notice this? Didn't notice this in 2.0, but haven't tested except in 2.3.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            jeffsibi Jeff Rader
            Integrator:
            Dan Poltawski
            Tester:
            David Monllaó
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Sep/12