Details

    • Testing Instructions:
      Hide

      For developers:
      1/ purge all caches and enable debug console in your brower
      2/ try slasharguments on and off, yui-combo-loading on and off, external yui on and off
      3/ go through each commit and test affected area:

      • mod_folder
      • private files block
      • file picker
      • date selector form element
      • mod_imscp
      • some user TreeView
      • mod_wiki
      • mod_assignment
      • mod_assign
      • mod_lti
      • mod_forum
      • mod_scorm
      • gradebook
      • groups UI
      • forms
      • tags
      • report_progress
      • report_completion
      • portfolio download
      • question bank
      • mod_quiz
      • comments
      • mod_chat
      • mod_survey
      Show
      For developers: 1/ purge all caches and enable debug console in your brower 2/ try slasharguments on and off, yui-combo-loading on and off, external yui on and off 3/ go through each commit and test affected area: mod_folder private files block file picker date selector form element mod_imscp some user TreeView mod_wiki mod_assignment mod_assign mod_lti mod_forum mod_scorm gradebook groups UI forms tags report_progress report_completion portfolio download question bank mod_quiz comments mod_chat mod_survey
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w33_MDL-34741_m24_yui2in3
    • Rank:
      43210

      Description

      At present we have a homegrown YUI2 legacy support that loads YUI2 classes into the global scope (which means that YUI2 is available via global YAHOO object). The official recommended way is to use 2in3 http://yuilibrary.com/yui/docs/yui/yui-yui2.html which loads slightly modified YUI2 directly into the YUI3 instance property Y.YUI2.

      This patch replaces our non-standard YUI2 hack with officially supported YUI 2in3.

      Benefits:
      1/ YUI2 Javascript classes and CSS are not loaded on each page - performance
      2/ YUI2 files are loaded asynchronously - performance
      3/ cleaner coding style with fewer bugs

      Necessary code changes:
      1/ YUI3 code using YUI2 widgets needs to use Y.YUI2.* instead of previous YAHOO.
      2/ rewrite old legacy code that is still using deprecated $PAGE->requires->yui2_lib('xx') to use new moodle JS modules
      3/ in the worst case wrap old code with YUI3 block and use yui2-* modules as dependencies

      Example of YUI3 module using TreeView widget:

      YUI.add('mod-mymodule-tree', function(Y) {
        // ...
        var tree = new Y.YUI2.widget.TreeView("elemid");
        // ...
      }, '@VERSION@', {requires:['base', 'node', 'yui2-treeview']});
      

      Sample modification of YUI3 code without changing module dependencies:

      YUI().use(function(Y) {
        // Old code
        // ...
        Y().use('yui2-treeview', function(Y) {
          var tree = new Y.YUI2.widget.TreeView("elemid");
          // ...
        });
        // ...
      

      Example of backwards compatibility hack in global scope:

      YUI().use('yui2-dom', 'yui2-event', '...', function(Y) {
        var YAHOO = Y.YUI2;
        // Old code here
        // ...
      
      });
      
      1. yui2_lib.txt
        7 kB
        Aparup Banerjee

        Issue Links

          Activity

          Hide
          Petr Škoda added a comment -
          Show
          Petr Škoda added a comment - here is my work in progress branch: https://github.com/skodak/moodle/compare/wip_MDL-34741_m24_yui2in3
          Show
          Petr Škoda added a comment - - edited some SCORM rewrite info: https://github.com/mayankgupta/moodle/compare/master_MDL-32835_scorm_get_toc_rewrite...master_MDL-28937_CM-01_sequencing_control_flow https://github.com/mayankgupta/moodle/compare/master...master_MDL-7068_CM-tests
          Hide
          Petr Škoda added a comment -

          The code should be ready for review, I am going to work on docs tomorrow...

          Show
          Petr Škoda added a comment - The code should be ready for review, I am going to work on docs tomorrow...
          Hide
          Petr Škoda added a comment -

          Tim: could you please review the quiz and qbank related commits? thanks

          Show
          Petr Škoda added a comment - Tim: could you please review the quiz and qbank related commits? thanks
          Hide
          Martin Dougiamas added a comment -

          1) Is there any effect on YUI3 code out there?

          2) Can someone (Apu) grep all the plugins in moodle.org/plugins to see what this will break? This won't help anyone who used YUI2 in local code but it's a start.

          Show
          Martin Dougiamas added a comment - 1) Is there any effect on YUI3 code out there? 2) Can someone (Apu) grep all the plugins in moodle.org/plugins to see what this will break? This won't help anyone who used YUI2 in local code but it's a start.
          Hide
          Petr Škoda added a comment -

          1) YUI3 code is not affected at all, I had to improve the default YUI loader configuration handling and shuffled the libs around a bit, but the BC is 100% for everything that uses YUI3.

          2) yes, the contrib will be a pain, especially legacy 1.9-style JS includes that define everything as functions in a global scope

          Show
          Petr Škoda added a comment - 1) YUI3 code is not affected at all, I had to improve the default YUI loader configuration handling and shuffled the libs around a bit, but the BC is 100% for everything that uses YUI3. 2) yes, the contrib will be a pain, especially legacy 1.9-style JS includes that define everything as functions in a global scope
          Hide
          Martin Dougiamas added a comment -

          I think the benefits have to be really hugely better, or we prove this will affect very few people ... for me to +1 this. I'm just really sensitive to making Moodle upgrades any more difficult at the moment.

          Show
          Martin Dougiamas added a comment - I think the benefits have to be really hugely better, or we prove this will affect very few people ... for me to +1 this. I'm just really sensitive to making Moodle upgrades any more difficult at the moment.
          Hide
          Tim Hunt added a comment -

          Completely eliminating all trace of YUI2 is a big win:

          1. Perf improvement (less JS that might be loaded).
          2. It makes Moodle a cleaner platform. We only need one JS library.
          3. Hence, easier-to-maintain code and less buggy code.

          This is only one step on the way to eliminating YUI2. Is this one step enough to break backwards-compatibility? Can we guarantee to complete the other steps before 2.4?

          Show
          Tim Hunt added a comment - Completely eliminating all trace of YUI2 is a big win: Perf improvement (less JS that might be loaded). It makes Moodle a cleaner platform. We only need one JS library. Hence, easier-to-maintain code and less buggy code. This is only one step on the way to eliminating YUI2. Is this one step enough to break backwards-compatibility? Can we guarantee to complete the other steps before 2.4?
          Hide
          Petr Škoda added a comment -

          Please note that you can write code that runs both with this patch and older global YAHOO:

          function (Y) {
              if (!YAHOO) {
                  var YAHOO = Y.YUI2;
              }
              ...
          

          But still you would have to convert the code to new moodle yui3 modules or use $PAGE->requires->js_init_call() methods.

          Show
          Petr Škoda added a comment - Please note that you can write code that runs both with this patch and older global YAHOO: function (Y) { if (!YAHOO) { var YAHOO = Y.YUI2; } ... But still you would have to convert the code to new moodle yui3 modules or use $PAGE->requires->js_init_call() methods.
          Show
          Tim Hunt added a comment - The Changes look OK ( https://github.com/skodak/moodle/commit/9ac01dc8d59deba0e262c352e6a90aa313e245a5 and https://github.com/skodak/moodle/commit/1ef90e62b6ded9796e84030aeacf27b57e87c3a8 ). I have not tested them.
          Hide
          Petr Škoda added a comment -

          I tested all my changes in OS X FF+Safari.

          Show
          Petr Škoda added a comment - I tested all my changes in OS X FF+Safari.
          Hide
          Petr Škoda added a comment -

          We have following options:
          1/ keep current YUI2 hacks forever - good for devs that ignore coding style guides and unmaintained plugins, bad for everybody else (not officially supported, there are sometimes problems during YUI3 upgrades)
          2/ switch to 2in3 - good for developers that need to use only some YUI2 widgets, bad for lazy developers, good for the rest (officially supported by YUI team)
          3/ remove YUI2 completely - not likely anytime soon, all developers would need to migrate everything to YUI3

          Show
          Petr Škoda added a comment - We have following options: 1/ keep current YUI2 hacks forever - good for devs that ignore coding style guides and unmaintained plugins, bad for everybody else (not officially supported, there are sometimes problems during YUI3 upgrades) 2/ switch to 2in3 - good for developers that need to use only some YUI2 widgets, bad for lazy developers, good for the rest (officially supported by YUI team) 3/ remove YUI2 completely - not likely anytime soon, all developers would need to migrate everything to YUI3
          Hide
          Dan Poltawski added a comment -

          Really 3/ is the ideal and it seems like worth breaking backwards compatibility for, then we could exorcise yui2 completely from core.

          If we managed to get to 3/, I suppose that third parties could ship YUI2 themselves/depend on a yui2 plugin? That would seem like a best way to spend their effort rather than doing this intermediate step.

          If we can't manage to upgrade to core to YUI3, then I don't think there is the justification to force third parties to do the half way step.

          I'm no expert in this area, but I thought that we could just eliminate all the YUI2 $PAGE->requires calls to reduce the performance impact on all moodle pages.

          Show
          Dan Poltawski added a comment - Really 3/ is the ideal and it seems like worth breaking backwards compatibility for, then we could exorcise yui2 completely from core. If we managed to get to 3/, I suppose that third parties could ship YUI2 themselves/depend on a yui2 plugin? That would seem like a best way to spend their effort rather than doing this intermediate step. If we can't manage to upgrade to core to YUI3, then I don't think there is the justification to force third parties to do the half way step. I'm no expert in this area, but I thought that we could just eliminate all the YUI2 $PAGE->requires calls to reduce the performance impact on all moodle pages.
          Hide
          Petr Škoda added a comment -

          My YUI2 moodle hacks were supposed to be intermediate solution for YUI 3.0.0, 2in3 was released later and is the final solution for YUI3 code that needs some missing widgets from YUI2. I wanted to make the JS code conversion easier, but now I see that it just helped not-enough-motivated developers that did not want to learn YUI3 and decided to keep using YUI2, most of the code I changed in the linked patch seems to be from 2.x which made me sad.

          I am afraid there will never be a good time to remove YUI2. Do we want to live with it in global JS scope forever? If not I think it is a good time to migrate to 2in3 and drop it completely once it is not working on current browsers.

          And yes, it is technically possible and relatively simple to include 2in3 in your plugin if it gets dropped from core (without the yui_combo.php loader of course) - each plugin may even use it's own version because 2in3 is sandboxed. You could load it also from external site without any problems.

          It would be much much harder to bundle my current YUI2 hacks in a custom plugin.

          Show
          Petr Škoda added a comment - My YUI2 moodle hacks were supposed to be intermediate solution for YUI 3.0.0, 2in3 was released later and is the final solution for YUI3 code that needs some missing widgets from YUI2. I wanted to make the JS code conversion easier, but now I see that it just helped not-enough-motivated developers that did not want to learn YUI3 and decided to keep using YUI2, most of the code I changed in the linked patch seems to be from 2.x which made me sad. I am afraid there will never be a good time to remove YUI2. Do we want to live with it in global JS scope forever? If not I think it is a good time to migrate to 2in3 and drop it completely once it is not working on current browsers. And yes, it is technically possible and relatively simple to include 2in3 in your plugin if it gets dropped from core (without the yui_combo.php loader of course) - each plugin may even use it's own version because 2in3 is sandboxed. You could load it also from external site without any problems. It would be much much harder to bundle my current YUI2 hacks in a custom plugin.
          Hide
          Sam Hemelryk added a comment -

          Obviously this gets a huge +1 from me.
          The current way in which we load YUI2 modules into the page bloats the page size for every page.
          Having to load the module JS when they are used is also a big burden, especially as most things are available in Y3 anyway and as we use more and more JS in every page its more likely that the equivalent YUI3 JS will already have been loaded.
          I also feel this will be a good push for developers to look back at their old JS code and think about updating it.
          Removing it entirely is out of the question at the moment for sure.

          Personally I think only good can come from getting this change into 2.4.

          Show
          Sam Hemelryk added a comment - Obviously this gets a huge +1 from me. The current way in which we load YUI2 modules into the page bloats the page size for every page. Having to load the module JS when they are used is also a big burden, especially as most things are available in Y3 anyway and as we use more and more JS in every page its more likely that the equivalent YUI3 JS will already have been loaded. I also feel this will be a good push for developers to look back at their old JS code and think about updating it. Removing it entirely is out of the question at the moment for sure. Personally I think only good can come from getting this change into 2.4.
          Hide
          Martin Dougiamas added a comment -
          Show
          Martin Dougiamas added a comment - See GDF discussion http://moodle.org/mod/forum/discuss.php?d=208591
          Hide
          Aparup Banerjee added a comment -

          Ok, here's a list of all plugins registered in the Plugins plugin db that require yui2 libs. That's 11/384 plugins.

          I've seen that no plugin has ever deprecated requiring yui2 libs as such all versions of the below plugins do require yui2 libs. Of these , only 3 (Navbuttons,Checklist! and Ajax Marking Block) are for 2.3 so maybe yui2in3 might be good timing for 2.4.

          Navbuttons 1.9 - 2.3
          Anonymizable Forum 2.1
          Reservation 2.0 - 2.2
          Checklist 2.0 - 2.3
          Facility To Moodle 2 2.2
          Parental Portal 2.2
          Source-code Plagiarism Plugin 2.0 - 2.2
          Flexpage format 2.2
          Topics format (colours) 2.0 - 2.2
          OU wiki 2.1 - 2.2
          AJAX Marking Block 1.9 - 2.3

          The attached file yui2_lib.txt breaks down what exact yui2 libs they require (in the plugin's latest version).

          Show
          Aparup Banerjee added a comment - Ok, here's a list of all plugins registered in the Plugins plugin db that require yui2 libs. That's 11/384 plugins. I've seen that no plugin has ever deprecated requiring yui2 libs as such all versions of the below plugins do require yui2 libs. Of these , only 3 (Navbuttons,Checklist! and Ajax Marking Block) are for 2.3 so maybe yui2in3 might be good timing for 2.4. Navbuttons 1.9 - 2.3 Anonymizable Forum 2.1 Reservation 2.0 - 2.2 Checklist 2.0 - 2.3 Facility To Moodle 2 2.2 Parental Portal 2.2 Source-code Plagiarism Plugin 2.0 - 2.2 Flexpage format 2.2 Topics format (colours) 2.0 - 2.2 OU wiki 2.1 - 2.2 AJAX Marking Block 1.9 - 2.3 The attached file yui2_lib.txt breaks down what exact yui2 libs they require (in the plugin's latest version).
          Hide
          Petr Škoda added a comment -

          Aparup: Thanks for the info.

          I am submitting this for integration because there were no major objections against this so far.

          Thanks for all the feedback.

          Show
          Petr Škoda added a comment - Aparup: Thanks for the info. I am submitting this for integration because there were no major objections against this so far. Thanks for all the feedback.
          Hide
          Martin Dougiamas added a comment -

          Apu can you please contact all those devs of those plugins and let them know about this issue?

          Show
          Martin Dougiamas added a comment - Apu can you please contact all those devs of those plugins and let them know about this issue?
          Hide
          Dan Poltawski added a comment -

          (I am pretty sure we have agreement on this now, so heading for integration)

          Show
          Dan Poltawski added a comment - (I am pretty sure we have agreement on this now, so heading for integration)
          Hide
          Dan Poltawski added a comment -

          I've integrated this now. I did a commit to add a note to lib/upgrade.txt - if anyone wants to add a better summary there please feel free.

          Show
          Dan Poltawski added a comment - I've integrated this now. I did a commit to add a note to lib/upgrade.txt - if anyone wants to add a better summary there please feel free.
          Hide
          Tim Barker added a comment -

          Everyone is testing this

          Show
          Tim Barker added a comment - Everyone is testing this
          Hide
          Tim Barker added a comment -

          4 or 5 non-related issues found. Testing this much of Moodle we were probably going to find something. Great work everyone involved !

          Show
          Tim Barker added a comment - 4 or 5 non-related issues found. Testing this much of Moodle we were probably going to find something. Great work everyone involved !
          Hide
          Tim Hunt added a comment -

          What about the JS error Andrew found in MDL-34905, and filed another bug about?

          Show
          Tim Hunt added a comment - What about the JS error Andrew found in MDL-34905 , and filed another bug about?
          Hide
          Dan Poltawski added a comment -

          I think I might've put off the chase about that other issue. setting this to failed.

          Show
          Dan Poltawski added a comment - I think I might've put off the chase about that other issue. setting this to failed.
          Hide
          Tim Hunt added a comment -

          JS error on the quiz review page. Found by Andrew Davis and reported in MDL-34905:

          Timestamp: 15/08/12 12:18:57
          Error: TypeError: M.core_question_engine is undefined
          Source File: http://localhost/moodle/int/master/lib/javascript.php/1345002270/mod/quiz/module.js
          Line: 1

          Show
          Tim Hunt added a comment - JS error on the quiz review page. Found by Andrew Davis and reported in MDL-34905 : Timestamp: 15/08/12 12:18:57 Error: TypeError: M.core_question_engine is undefined Source File: http://localhost/moodle/int/master/lib/javascript.php/1345002270/mod/quiz/module.js Line: 1
          Hide
          Tim Hunt added a comment -

          Wow! did I really give this a +1 when I peer reviewed this? I hate all the duplicate $module definitions all over the code. For the mod/quiz/module.js, I made a function quiz_get_js_module in mod/quiz/locallib.php. I wish you had done something similar in mod/quiz/editlib.php and question/editlib.php.

          Still can't work out why this is breaking, but still looking.

          Show
          Tim Hunt added a comment - Wow! did I really give this a +1 when I peer reviewed this? I hate all the duplicate $module definitions all over the code. For the mod/quiz/module.js, I made a function quiz_get_js_module in mod/quiz/locallib.php. I wish you had done something similar in mod/quiz/editlib.php and question/editlib.php. Still can't work out why this is breaking, but still looking.
          Hide
          Tim Hunt added a comment -

          I just upgraded to integration/master, and I cannot reproduce this JS error. I tried both with JS caching/combo loading on and off.

          Show
          Tim Hunt added a comment - I just upgraded to integration/master, and I cannot reproduce this JS error. I tried both with JS caching/combo loading on and off.
          Hide
          Petr Škoda added a comment -

          Tim: the use of M.core_question_engine is a nightmare because there might be weird loading problems thanks to missing dependency and module definitions in different question/quiz JS parts. I did not want to rewrite that completely, I tried the least possible modification only to make it pass the integration, sorry. It might be easier to just rewrite all that from scratch using new /yui/ modules.

          Show
          Petr Škoda added a comment - Tim: the use of M.core_question_engine is a nightmare because there might be weird loading problems thanks to missing dependency and module definitions in different question/quiz JS parts. I did not want to rewrite that completely, I tried the least possible modification only to make it pass the integration, sorry. It might be easier to just rewrite all that from scratch using new /yui/ modules.
          Hide
          Petr Škoda added a comment -

          Tim: I am going to work on YUI3 module conversions later this week, we could discuss JS in quiz/questions sometime next week when I have some conversion examples, ok?

          Is there any remaining issue here?

          Show
          Petr Škoda added a comment - Tim: I am going to work on YUI3 module conversions later this week, we could discuss JS in quiz/questions sometime next week when I have some conversion examples, ok? Is there any remaining issue here?
          Hide
          Tim Hunt added a comment -

          Quiz/question divides roughly into two halves:

          1. What happens during attempts. These are the only bits that students see. This code is already fairly clean, and is YUI3, but is in old-style module.js files, (I think it is just mod/quiz/module.js, question/flag.js and question/qengine.js). It would be really great to make those proper yui3 modules, and probably not too hard, but I doubt I will have time to work on that.

          2. The other bits are use in the question bank UI and quiz editing UI. This is mostly still YUI2, and is more work to fix up, but that should be done. The question type selector thingy should be re-written to be just like the activity chooser.

          While I am too busy to work on this myself, I would be happy to try to make time to peer-review patches.

          Show
          Tim Hunt added a comment - Quiz/question divides roughly into two halves: 1. What happens during attempts. These are the only bits that students see. This code is already fairly clean, and is YUI3, but is in old-style module.js files, (I think it is just mod/quiz/module.js, question/flag.js and question/qengine.js). It would be really great to make those proper yui3 modules, and probably not too hard, but I doubt I will have time to work on that. 2. The other bits are use in the question bank UI and quiz editing UI. This is mostly still YUI2, and is more work to fix up, but that should be done. The question type selector thingy should be re-written to be just like the activity chooser. While I am too busy to work on this myself, I would be happy to try to make time to peer-review patches.
          Hide
          Dan Poltawski added a comment -

          Hi,

          Well I integrated this on the principle discussed in various forms that it wouldn't break the world, or if we did, it would be relatively easy to fix. We decided on going with 2in3 because we couldn't fix all yui3 problems and this was an way forward in the meantime.

          Yet here we are with a problem and it sounds like as core developers, experts in moodle development that our only solution to this problem is to upgrade to YUI 3! Note: I might be completely misinformed, but that is what it sounds like from here, right now.

          Well, if that is the case, it feels like i've been deceived. The principles that we integrated this issue on are not sound. As MD has noted we need to stop making life harder for external developers unecessarily, and right now we are in revert territory. Sorry.

          Show
          Dan Poltawski added a comment - Hi, Well I integrated this on the principle discussed in various forms that it wouldn't break the world, or if we did, it would be relatively easy to fix. We decided on going with 2in3 because we couldn't fix all yui3 problems and this was an way forward in the meantime. Yet here we are with a problem and it sounds like as core developers, experts in moodle development that our only solution to this problem is to upgrade to YUI 3! Note: I might be completely misinformed, but that is what it sounds like from here, right now. Well, if that is the case, it feels like i've been deceived. The principles that we integrated this issue on are not sound. As MD has noted we need to stop making life harder for external developers unecessarily, and right now we are in revert territory. Sorry.
          Hide
          Petr Škoda added a comment -

          See "Necessary code changes:" in description, it says that all YUI2 code needs to be updated. Quiz/question code contains a mixture of new and legacy code in several javascript files used in mutliple independent places, that made it the trickiest part, I did not want to rewrite it myself now and that is why we had the discussion with Tim. The rest of the commits was a lot simpler. And yes the proper solution is to upgrade to recommended YUI3 coding style. There are several more javascript coding styles used in moodle now, they still work (except the global YAHOO.*), but I believe they should be standardised in the next step (before 2.4 release).

          Show
          Petr Škoda added a comment - See "Necessary code changes:" in description, it says that all YUI2 code needs to be updated. Quiz/question code contains a mixture of new and legacy code in several javascript files used in mutliple independent places, that made it the trickiest part, I did not want to rewrite it myself now and that is why we had the discussion with Tim. The rest of the commits was a lot simpler. And yes the proper solution is to upgrade to recommended YUI3 coding style. There are several more javascript coding styles used in moodle now, they still work (except the global YAHOO.*), but I believe they should be standardised in the next step (before 2.4 release).
          Hide
          Petr Škoda added a comment - - edited

          Hmmm, I was testing SimpleYUI today and it seems that it could both improve performanceand simplify migration of legacy javascript code to YUI3, see MDL-34915.

          Show
          Petr Škoda added a comment - - edited Hmmm, I was testing SimpleYUI today and it seems that it could both improve performanceand simplify migration of legacy javascript code to YUI3, see MDL-34915 .
          Hide
          Petr Škoda added a comment -

          Why is this still in "Problem during testing"? I do not see any remaining issue here. The last reported problem was not reproduced by Tim, right?

          Show
          Petr Škoda added a comment - Why is this still in "Problem during testing"? I do not see any remaining issue here. The last reported problem was not reproduced by Tim, right?
          Hide
          Dan Poltawski added a comment -

          Because as far as I was aware we still have a problem in testing here. Can anyone report?

          Show
          Dan Poltawski added a comment - Because as far as I was aware we still have a problem in testing here. Can anyone report?
          Hide
          Petr Škoda added a comment -

          I personally can not reproduce the quiz issue in current integration branch.

          Show
          Petr Škoda added a comment - I personally can not reproduce the quiz issue in current integration branch.
          Hide
          Tim Hunt added a comment -

          I wonder if Andrew did all the necessary cache clearing before testing? I was surprised to see that despite JS changes, there were no version number bumps in integration yet this week.

          Show
          Tim Hunt added a comment - I wonder if Andrew did all the necessary cache clearing before testing? I was surprised to see that despite JS changes, there were no version number bumps in integration yet this week.
          Hide
          Dan Poltawski added a comment -

          Tim: There were - see 3542e01a0c1f4b52de69cbdb8488c4e816127926

          Show
          Dan Poltawski added a comment - Tim: There were - see 3542e01a0c1f4b52de69cbdb8488c4e816127926
          Hide
          Eloy Lafuente (stronk7) added a comment -

          3

          Show
          Eloy Lafuente (stronk7) added a comment - 3
          Hide
          Eloy Lafuente (stronk7) added a comment -

          2

          Show
          Eloy Lafuente (stronk7) added a comment - 2
          Hide
          Eloy Lafuente (stronk7) added a comment -

          1

          Show
          Eloy Lafuente (stronk7) added a comment - 1
          Hide
          Eloy Lafuente (stronk7) added a comment -

          0 - Oki, passing this. it's master, we can break it and this is not going to be reverted.

          Show
          Eloy Lafuente (stronk7) added a comment - 0 - Oki, passing this. it's master, we can break it and this is not going to be reverted.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Any problem, please create new issues and, if possible, link them to this.

          Show
          Eloy Lafuente (stronk7) added a comment - Any problem, please create new issues and, if possible, link them to this.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Q1: Will Moodle 2.4 core be 100% free from any Yui2 gadget?

          Show
          Eloy Lafuente (stronk7) added a comment - Q1: Will Moodle 2.4 core be 100% free from any Yui2 gadget?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Q2: Will Moodle 2.5 core be 100% free from any Yui2 gadget?

          Show
          Eloy Lafuente (stronk7) added a comment - Q2: Will Moodle 2.5 core be 100% free from any Yui2 gadget?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Q3: Will Moodle 2.6 core be 100% free from any Yui2 gadget?

          Show
          Eloy Lafuente (stronk7) added a comment - Q3: Will Moodle 2.6 core be 100% free from any Yui2 gadget?
          Hide
          Eloy Lafuente (stronk7) added a comment -

          For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

          Many thanks for your collaboration, yay!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao
          Hide
          Aparup Banerjee added a comment -

          I've notified the contributors of those mentioned plugins about this now.

          Show
          Aparup Banerjee added a comment - I've notified the contributors of those mentioned plugins about this now.
          Hide
          Valery Fremaux added a comment -

          Hi guys,

          is some review of the http://docs.moodle.org/dev/YUI dev doc planned for supporting those changes ? i confess i'm a bit confused with the adequate process to integrate proper ajax calls in a contrib module
          the right way...

          Best wishes for 2013 !
          Valery.

          Show
          Valery Fremaux added a comment - Hi guys, is some review of the http://docs.moodle.org/dev/YUI dev doc planned for supporting those changes ? i confess i'm a bit confused with the adequate process to integrate proper ajax calls in a contrib module the right way... Best wishes for 2013 ! Valery.
          Hide
          Petr Škoda added a comment -

          note: YUI2 will be completely removed from Moodle 2.8, please migrate to YUI3 instead, thanks

          Show
          Petr Škoda added a comment - note: YUI2 will be completely removed from Moodle 2.8, please migrate to YUI3 instead, thanks

            People

            • Votes:
              8 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: