Moodle
  1. Moodle
  2. MDL-34742

can't move block to empty column without ajax support

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Blocks
    • Labels:
    • Database:
      Any
    • Testing Instructions:
      Hide

      Test pre-requisites

      • From the standard theme home page, empty the right column of blocks
      • Disable ajax (or JavaScript)
      • Use different themes and repeat the following test

      Test

      1. As an admin, on the home page, with editing on
      2. Make sure the you can move a block from the left column to the right one
      3. Empty the right column again
      4. Re-enable Ajax or Javascript
      5. Return to the Home page
      6. Make sure the you can a block from the left column to the right one
      Show
      Test pre-requisites From the standard theme home page, empty the right column of blocks Disable ajax (or JavaScript) Use different themes and repeat the following test Test As an admin, on the home page, with editing on Make sure the you can move a block from the left column to the right one Empty the right column again Re-enable Ajax or Javascript Return to the Home page Make sure the you can a block from the left column to the right one
    • Workaround:
      Hide

      turn ajax on and drag block over there as if there was a column

      Show
      turn ajax on and drag block over there as if there was a column
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-34742-master
    • Rank:
      43211

      Description

      If one turns off ajax and removes all the blocks from the standard theme front page right column it is impossible to get blocks back into that column.

      Reproduction steps:

      1. Log in as admin
      2. Navigate to the Home page
      3. In the Settings block under Front page settings, click Turn editing on
      4. Shift all blocks on the right to the left column
      5. Navigate to Site admin > Appearance > AJAX and JavaScript
      6. Uncheck Enable AJAX
      7. Return to the Home page
      8. Attempt to move a block from the left column to the right column

      Expected result: A target location should appear in the right column

      Actual result: No target area appears

        Activity

        Hide
        Michael de Raadt added a comment -

        Thanks for reporting that and providing a patch.

        Show
        Michael de Raadt added a comment - Thanks for reporting that and providing a patch.
        Hide
        moodle.com added a comment -

        This will need to be tested across multiple themes and browsers.

        Show
        moodle.com added a comment - This will need to be tested across multiple themes and browsers.
        Hide
        Michael de Raadt added a comment -

        Just noting that this happens on any page that is not a course page (such as an activity page), where Ajax moving does not yet apply.

        Show
        Michael de Raadt added a comment - Just noting that this happens on any page that is not a course page (such as an activity page), where Ajax moving does not yet apply.
        Hide
        Frédéric Massart added a comment -

        Thanks for your patch Matt, I have amended it and pushed it for peer review.

        Show
        Frédéric Massart added a comment - Thanks for your patch Matt, I have amended it and pushed it for peer review.
        Hide
        Rajesh Taneja added a comment -

        Patch is spot-on Fred,
        Although you might want to fix comment. Comment should start with capital letter and in end with (.) dot

        Show
        Rajesh Taneja added a comment - Patch is spot-on Fred, Although you might want to fix comment. Comment should start with capital letter and in end with (.) dot
        Hide
        Frédéric Massart added a comment -

        Thanks Raj. I had changed the comment but it got lost somewhere between Github and my machine... I've fixed that now. Pushing for integration. Cheers!

        Show
        Frédéric Massart added a comment - Thanks Raj. I had changed the comment but it got lost somewhere between Github and my machine... I've fixed that now. Pushing for integration. Cheers!
        Hide
        Dan Poltawski added a comment -

        Great, i've integrated this to 22, 23 and master.

        Thanks Matt & Fred!

        Show
        Dan Poltawski added a comment - Great, i've integrated this to 22, 23 and master. Thanks Matt & Fred!
        Hide
        Andrew Davis added a comment -

        Works as described. Passing.

        Show
        Andrew Davis added a comment - Works as described. Passing.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        YEAR!*

        CAF*, TOT!*

        • Your effort amazingly resulted. (unbelievable :-P)
        • Closing as fixed.
        • Tons of thanks.
        Show
        Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: