Patch that fixes the problem (alphabetizes by title) in 2.2.1

hi Brad,
Thanks for mentioning it and submitting a patch.

Can you make a small change to the patch please so that function sort_by_title is inside the class and we don't declare a global function in the plugin.
See example 3 in http://au2.php.net/manual/en/function.usort.php

Marina

Updated patch per Marina Glancy's request (thanks for the quick response!)

that's great. Thanks. I changed it a little so that subfolders are listed first.

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

strcmp() and strtolower() breaks for utf8 strings, please use our textlib library instead...

Hi Dan, I want to re-submit it considering Petr's comment. Can you return it to work in progress please?

Hi Marina,

perhaps (Petr means) at https://github.com/marinaglancy/moodle/compare/master...wip-MDL-34748-master#L0R142 we could do :-
collatorlib::ksort($list['list'], collatorlib::SORT_NATURAL);

reopening for Marina.

there is no function in textlib or collatorlib to sort an array of arrays by property or to compare strings.

So I had to retrieve list of dirs and files first, then sort it and then fill the $list['list']

Thanks for asorting that out Marina! :-D

that's been integrated into 22,23 and master.

Works like a charm on 2.2, 2.3 and master! \o/

For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

Many thanks for your collaboration, yay!

Closing, ciao