Moodle
  1. Moodle
  2. MDL-34774

Incorrect lesson statitics when there is only one attempt with score of 0

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1, 2.4.2, 2.5
    • Fix Version/s: 2.3.6, 2.4.3
    • Component/s: Lesson
    • Labels:
    • Rank:
      43261

      Description

      When there is only one attempt in a lesson with 0 score. The "high score" and "low score" column show "Not completed%".

      Replication steps:-

      1. Create a lesson with a question
      2. attempt the lesson as student and secure 0 grade
      3. view the report for the lesson as teacher

        Issue Links

          Activity

          Hide
          Ankit Agarwal added a comment -

          attaching screen

          Show
          Ankit Agarwal added a comment - attaching screen
          Hide
          Adrian Greeve added a comment -

          [Y] Syntax
          [Y] Output
          [Y] Whitespace
          [-] Language
          [-] Databases
          [Y] Testing
          [-] Security
          [-] Documentation
          [Y] Git
          [Y] Sanity check

          Hi Rossie,

          This looks good to me. I couldn't spot anything wrong.

          Send to integration when you're ready.

          Show
          Adrian Greeve added a comment - [Y] Syntax [Y] Output [Y] Whitespace [-] Language [-] Databases [Y] Testing [-] Security [-] Documentation [Y] Git [Y] Sanity check Hi Rossie, This looks good to me. I couldn't spot anything wrong. Send to integration when you're ready.
          Hide
          Rossiani Wijaya added a comment -

          Thanks Adrian for reviewing.

          Sending for integration review.

          Show
          Rossiani Wijaya added a comment - Thanks Adrian for reviewing. Sending for integration review.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Rossie, could you please create a new issue about to change all those NULL (upper) to null (lower). I was near rejecting this but as far as the lesson is plagued, better move that task to another issue and keep this change clean.

          Integrated (23, 24 & master), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Rossie, could you please create a new issue about to change all those NULL (upper) to null (lower). I was near rejecting this but as far as the lesson is plagued, better move that task to another issue and keep this change clean. Integrated (23, 24 & master), thanks!
          Hide
          Rossiani Wijaya added a comment -

          Thanks Eloy.

          I created MDL-38429 to fix the null value.

          Show
          Rossiani Wijaya added a comment - Thanks Eloy. I created MDL-38429 to fix the null value.
          Hide
          Andrew Davis added a comment -

          Works as described. Passing.

          Show
          Andrew Davis added a comment - Works as described. Passing.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads).

          Thanks!

          PS: Yay, legacy template messages. Yes, you're ok, we don't have CVS anymore!

          Show
          Eloy Lafuente (stronk7) added a comment - This issue has been integrated upstream and is now available both via git and cvs (and in some hours, via mirrors and downloads). Thanks! PS: Yay, legacy template messages. Yes, you're ok, we don't have CVS anymore!

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: