Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.3.1, 2.3.4, 2.4.1
-
Testing Instructions:
-
Difficulty:Easy
-
Affected Branches:MOODLE_23_STABLE, MOODLE_24_STABLE
-
Fixed Branches:MOODLE_23_STABLE, MOODLE_24_STABLE, MOODLE_25_STABLE
-
Pull from Repository:
-
Pull Master Branch:wip-
MDL-34775-master -
Pull Master Diff URL:
Description
This is a minor usability issue.
When RSS is enabled a forum's settings includes settings to control the RSS feed coming out of the forum. The first setting is labelled "RSS feed for this activity" and has three options: "None", "Discussions" and "Posts". When this setting is set to none, no RSS feed is generated for the forum. The second RSS setting is the number of recent articles. This setting is active regardless of the state of the first setting. This second setting should be disabled when the first is set to "None".
Reproduction steps:
- Log in as admin
- In Settings > Site admin > Advanced features, enable RSS feeds
- In Settings > Site admin > Plugins > Activity modules > Forum, enable RSS feeds
- Navigate into a course
- Create a new forum or edit an existing one
- Set the setting labelled "RSS feed for this activity" to "None"
- Attempt to change the setting labelled "Number of RSS recent articles"
Expected result: You should not be able to change "Number of RSS recent articles" while "RSS feed for this activity" is "None".
Actual result: You can.
Gliffy Diagrams
Attachments
Issue Links
- Testing discovered
-
-
- Closed
-
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Patch looks good and the logic is sound, thanks Michael. Jason feel free to backport and submit to integration.
Thanks Mark, Back ported and pushed for integration
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
thanks, thats been integrated into 23, 24 and master.
This is working as expected.
Tested for 2.3, 2.4 and master
Test passed.
This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.
Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).
Thanks, closing as fixed!
I've only got the patch for master so far, will backport once I get the all clear from the peer review.