Moodle

Forum RSS count of posts/discussions is not dependent on RSS setting

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.3.1, 2.3.4, 2.4.1
  • Fix Version/s: 2.3.5, 2.4.2, 2.5
  • Component/s: Forum, RSS
  • Labels:

Description

This is a minor usability issue.

When RSS is enabled a forum's settings includes settings to control the RSS feed coming out of the forum. The first setting is labelled "RSS feed for this activity" and has three options: "None", "Discussions" and "Posts". When this setting is set to none, no RSS feed is generated for the forum. The second RSS setting is the number of recent articles. This setting is active regardless of the state of the first setting. This second setting should be disabled when the first is set to "None".

Reproduction steps:

  1. Log in as admin
  2. In Settings > Site admin > Advanced features, enable RSS feeds
  3. In Settings > Site admin > Plugins > Activity modules > Forum, enable RSS feeds
  4. Navigate into a course
  5. Create a new forum or edit an existing one
  6. Set the setting labelled "RSS feed for this activity" to "None"
  7. Attempt to change the setting labelled "Number of RSS recent articles"

Expected result: You should not be able to change "Number of RSS recent articles" while "RSS feed for this activity" is "None".

Actual result: You can.

  1. Text File
    mod_form.php.patch
    08/Aug/12 1:51 PM
    0.7 kB
    Michael de Raadt
  1. screenshot-1.jpg
    32 kB
    08/Aug/12 1:51 PM

Issue Links

discovered while testing

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31599 Site news RSS feed doesn't work for guests

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jason Fowler added a comment -

I've only got the patch for master so far, will backport once I get the all clear from the peer review.

Show
Jason Fowler added a comment - I've only got the patch for master so far, will backport once I get the all clear from the peer review.
Hide
Permalink
Mark Nelson added a comment -

Patch looks good and the logic is sound, thanks Michael. Jason feel free to backport and submit to integration.

Show
Mark Nelson added a comment - Patch looks good and the logic is sound, thanks Michael. Jason feel free to backport and submit to integration.
Hide
Permalink
Jason Fowler added a comment -

Thanks Mark, Back ported and pushed for integration

Show
Jason Fowler added a comment - Thanks Mark, Back ported and pushed for integration
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Aparup Banerjee added a comment -

thanks, thats been integrated into 23, 24 and master.

Show
Aparup Banerjee added a comment - thanks, thats been integrated into 23, 24 and master.
Hide
Permalink
Rossiani Wijaya added a comment -

This is working as expected.

Tested for 2.3, 2.4 and master

Test passed.

Show
Rossiani Wijaya added a comment - This is working as expected. Tested for 2.3, 2.4 and master Test passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities.

Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied).

Thanks, closing as fixed!

Show
Eloy Lafuente (stronk7) added a comment - This is valid for unlimited entries to the, soon to be unveiled, Moodle Codebase Gardens. It includes free access to all facilities. Personal and non-transferable to all assignees, reviewers and testers in this issue. Valid until switching to Blackboard (100000€ penalization will be applied). Thanks, closing as fixed!

People

Vote (0)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: