Moodle
  1. Moodle
  2. MDL-34779

Wrong token in Site Policies "full name format"?

        Details

          Description

          In Site policies the "Full name format" setting default is "Language" but it seems to be mistake.It should be "First name +Surname" as written in the description - default value.
          See image added here. it should be different string token?
          Correct me if I'm wrong.
          Thanks

            Gliffy Diagrams

              Issue Links

              is a regression caused by

              Improvement - An enhancement to an existing Moodle feature. MDL-18824 fullnamedisplay default value should be 'Language'

              • Major - Major loss of function, incorrect output
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Michael de Raadt added a comment -

                It looks like this default changed at some point but the associated language string was not updated.

                Show
                Michael de Raadt added a comment - It looks like this default changed at some point but the associated language string was not updated.
                Hide
                Permalink
                Rossiani Wijaya added a comment -

                This looks good Ankit.

                +1 for integration.

                Show
                Rossiani Wijaya added a comment - This looks good Ankit. +1 for integration.
                Hide
                Permalink
                Ankit Agarwal added a comment -

                Thanks for the review Rosie,
                Sending for integration.

                Show
                Ankit Agarwal added a comment - Thanks for the review Rosie, Sending for integration.
                Hide
                Permalink
                Dan Poltawski added a comment -

                Hi Ankit,

                I see you've correctly attributed the patch to Michael, but how about putting his lastname in the commit

                cheers,
                dan

                Show
                Dan Poltawski added a comment - Hi Ankit, I see you've correctly attributed the patch to Michael, but how about putting his lastname in the commit cheers, dan
                Hide
                Permalink
                Ankit Agarwal added a comment - - edited

                updated

                Show
                Ankit Agarwal added a comment - - edited updated
                Hide
                Permalink
                Dan Poltawski added a comment -

                Integrated, thanks for that.

                Show
                Dan Poltawski added a comment - Integrated, thanks for that.
                Hide
                Permalink
                Rajesh Taneja added a comment -

                String displayed is as described.
                Thanks for fixing this, Ankit.

                Show
                Rajesh Taneja added a comment - String displayed is as described. Thanks for fixing this, Ankit.
                Hide
                Permalink
                Eloy Lafuente (stronk7) added a comment -

                YEAR!*

                CAF*, TOT!*

                • Your effort amazingly resulted. (unbelievable :-P)
                • Closing as fixed.
                • Tons of thanks.
                Show
                Eloy Lafuente (stronk7) added a comment - YEAR!* CAF*, TOT!* Your effort amazingly resulted. (unbelievable :-P) Closing as fixed. Tons of thanks.

                  People

                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    0 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: