Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-3478

RSS Block - cannot add feed as course creator

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: None
    • Component/s: Blocks
    • Labels:
      None
    • Environment:
      Windows XP
    • Database:
      MySQL
    • Affected Branches:
      MOODLE_15_STABLE

      Description

      In Admin > Blocks, Admins and Teachers may define feeds.

      When logged in as a course creator, feeds cannot be added to the block.

      Feeds can be added whilst logged in as Admin, feeds can ve validated by course creator.

      Discussion http://moodle.org/mod/forum/discuss.php?d=25459#120056

      1.5 stable 1.6 dev.

        Gliffy Diagrams

          Activity

          Hide
          dougiamas Martin Dougiamas added a comment -

          From Jon Papaioannou (pj at moodle.org) Monday, 13 June 2005, 10:43 AM:

          I did some research:

          The problem starts from block_rss_client_action.php line 56. It doesn't get past the conditional.

          This happens because $isteacher is always false, which happens because $course is always false, which happens because $courseid is NOT passed to this script. This finally points to rss_get_form() in rsslib.

          In retrospect, it should be obvious from the navigation bar: if you see the course name in there, you can add feeds as a teacher. If not, you need to be an admin.

          Incidentally, this doesn't have anything to do with course creator rights or anything. Just with editing teachers trying to add feeds to an rss block in their course.

          Deferring to Daryl, as I don't know the code well enough to decide how/when $courseid should be passed around.

          From Daryl Hawes (dhawes at mac.com) Monday, 1 August 2005, 10:08 PM:

          Code to fix this has been added to moodle HEAD, 1.6dev.

          Modified files:

          moodle/lib/rsslib.php

          moodle/blocks/rss_client/block_rss_client.php

          moodle/blocks/rss_client/block_rss_client_action.php

          moodle/blocks/rss_client/config_global.html

          moodle/blocks/rss_client/config_instance.html

          moodle/blocks/rss_client/config_instance_tabs.php

          I'll leave the bug open a bit longer in case anyone testing the changes finds other problems.

          From Jon Papaioannou (pj at moodle.org) Monday, 1 August 2005, 10:20 PM:

          Wow, lots of files changed. This could make it non-trivial to patch MOODLE_15_STABLE as well, but IMHO it needs to be done.

          Please have a go at it when you have time to (and after possibly waiting a bit for any testers on 1.6).

          From Daryl Hawes (dhawes at mac.com) Thursday, 4 August 2005, 10:25 AM:

          Closing bug. Fix in 1.6dev and merged back to 15_STABLE

          Show
          dougiamas Martin Dougiamas added a comment - From Jon Papaioannou (pj at moodle.org) Monday, 13 June 2005, 10:43 AM: I did some research: The problem starts from block_rss_client_action.php line 56. It doesn't get past the conditional. This happens because $isteacher is always false, which happens because $course is always false, which happens because $courseid is NOT passed to this script. This finally points to rss_get_form() in rsslib. In retrospect, it should be obvious from the navigation bar: if you see the course name in there, you can add feeds as a teacher. If not, you need to be an admin. Incidentally, this doesn't have anything to do with course creator rights or anything. Just with editing teachers trying to add feeds to an rss block in their course. Deferring to Daryl, as I don't know the code well enough to decide how/when $courseid should be passed around. From Daryl Hawes (dhawes at mac.com) Monday, 1 August 2005, 10:08 PM: Code to fix this has been added to moodle HEAD, 1.6dev. Modified files: moodle/lib/rsslib.php moodle/blocks/rss_client/block_rss_client.php moodle/blocks/rss_client/block_rss_client_action.php moodle/blocks/rss_client/config_global.html moodle/blocks/rss_client/config_instance.html moodle/blocks/rss_client/config_instance_tabs.php I'll leave the bug open a bit longer in case anyone testing the changes finds other problems. From Jon Papaioannou (pj at moodle.org) Monday, 1 August 2005, 10:20 PM: Wow, lots of files changed. This could make it non-trivial to patch MOODLE_15_STABLE as well, but IMHO it needs to be done. Please have a go at it when you have time to (and after possibly waiting a bit for any testers on 1.6). From Daryl Hawes (dhawes at mac.com) Thursday, 4 August 2005, 10:25 AM: Closing bug. Fix in 1.6dev and merged back to 15_STABLE
          Hide
          mblake Michael Blake added a comment -

          Temp reopen to assign to a valid user. Daryl Hawes.

          Show
          mblake Michael Blake added a comment - Temp reopen to assign to a valid user. Daryl Hawes.
          Hide
          mblake Michael Blake added a comment -

          Reassigning to a valid user.

          Show
          mblake Michael Blake added a comment - Reassigning to a valid user.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: