Moodle

Settings nav does not always correctly show the current place in the question bank

Details

  • Testing Instructions:
    Hide

    1. Go to the question bank in a course.
    2. If there is not already more than one question category, add another.
    3. Navigate around between the various Question bank sub-links, and ensure that the current place is always hiligheted.
    4. On the Questions page, use the dropdown to switch to a different category.
    5. Navigate around the question bank some more, and verify that the correct page is hilighted in the settings nav, and that the currently selected category is remembered.

    Show
    1. Go to the question bank in a course. 2. If there is not already more than one question category, add another. 3. Navigate around between the various Question bank sub-links, and ensure that the current place is always hiligheted. 4. On the Questions page, use the dropdown to switch to a different category. 5. Navigate around the question bank some more, and verify that the correct page is hilighted in the settings nav, and that the currently selected category is remembered.
  • Affected Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

To reproduce:

1. Go to the question bank in a course.
2. Use the Select a category drop-down to change to a different category.

Actual result: After the page has reloaded, the 'Question bank' section of the settings navigation is closed, and nothing is hilighted.

Expected result: Question bank is expanded, and Questions is hilighed.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tim Hunt added a comment -

I will re-base and cherry-pick to stable branches once the weeklies are out.

Show
Tim Hunt added a comment - I will re-base and cherry-pick to stable branches once the weeklies are out.
Hide
Permalink
Michael de Raadt added a comment -

Sam: could you please review this?

Show
Michael de Raadt added a comment - Sam: could you please review this?
Hide
Permalink
Sam Hemelryk added a comment -

Looks great thanks Tim, all clear for integration.

Show
Sam Hemelryk added a comment - Looks great thanks Tim, all clear for integration.
Hide
Permalink
Tim Hunt added a comment -

Thanks for the review Sam. Submitting for integration now.

Show
Tim Hunt added a comment - Thanks for the review Sam. Submitting for integration now.
Hide
Permalink
Dan Poltawski added a comment -

Thanks Tim. I've integrated this now.

Show
Dan Poltawski added a comment - Thanks Tim. I've integrated this now.
Hide
Permalink
Rajesh Taneja added a comment -

Works Great,

Thanks for fixing this Tim

Show
Rajesh Taneja added a comment - Works Great, Thanks for fixing this Tim
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

Many thanks for your collaboration, yay!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: