Moodle
  1. Moodle
  2. MDL-34829

We should allow 'single section links' to work even if not in single section mode

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.3.2
    • Component/s: Course
    • Labels:
    • Testing Instructions:
      Hide
      1. Create a course.
      2. Set format as topics, course display to 'show all sections on one page'
      3. Visit yourmoodle/course/view.php?id= {YOURCOURSEID}&topic=2.
        # Verify that you are directed to topic 2 single section
        # Visit yourmoodle/course/view.php?id={YOURCOURSEID}

        &section=2.

      4. Verify that you are directed to topic 2 single section
      5. Set format as weeks
      6. Visit yourmoodle/course/view.php?id= {YOURCOURSEID}

        &week=2.

      7. Verify that you are directed to topic 2 single section
      Show
      Create a course. Set format as topics, course display to 'show all sections on one page' Visit yourmoodle/course/view.php?id= {YOURCOURSEID}&topic=2. # Verify that you are directed to topic 2 single section # Visit yourmoodle/course/view.php?id={YOURCOURSEID} &section=2. Verify that you are directed to topic 2 single section Set format as weeks Visit yourmoodle/course/view.php?id= {YOURCOURSEID} &week=2. Verify that you are directed to topic 2 single section
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Rank:
      43329

      Description

      As people on the forums have pointed out and Mark Drechsler on MDL-32505, the changes in 2.3 break links to a single section if not in single section mode.

      "What happens to people who have built custom navigation into Topic 1 of their course, or a block, and which is a pivotal part of their learning design?"

      We didn't intend to do this and need to fix it.

        Issue Links

          Activity

          Hide
          Dan Poltawski added a comment - - edited

          TO INTEGRATOR - please cherry-pick to master.

          Show
          Dan Poltawski added a comment - - edited TO INTEGRATOR - please cherry-pick to master.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks! (23 & master)

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks! (23 & master)
          Hide
          Adrian Greeve added a comment -

          Tested in 2.3 and Master.
          The page redirects as it should. Thanks to Dan for clarifying what I should see on each page.
          Test passed.

          Show
          Adrian Greeve added a comment - Tested in 2.3 and Master. The page redirects as it should. Thanks to Dan for clarifying what I should see on each page. Test passed.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

          Many thanks for your collaboration, yay!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao

            People

            • Votes:
              3 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: