Moodle
  1. Moodle
  2. MDL-34835

Fusion theme - displaced navbar content appears in header when unenroling from course

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.1
    • Fix Version/s: 2.2.5, 2.3.2
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide
      1. Use Fusion theme
      2. Change role to 'Student'
      3. Select a 'course' from My Courses
      4. From Settings, select "Unenrol me from ('course')"
      5. TEST to see that the navbar/breadcrumb and 'Continue/ Cancel' option buttons sit in main content area of the page and NOT in the header.
      Show
      Use Fusion theme Change role to 'Student' Select a 'course' from My Courses From Settings, select "Unenrol me from ('course')" TEST to see that the navbar/breadcrumb and 'Continue/ Cancel' option buttons sit in main content area of the page and NOT in the header.
    • Affected Branches:
      MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Pull Master Branch:
      MDL-34835_master
    • Rank:
      43337

      Description

      Using Fusion in Moodle 2.3.1 (upgraded 2012/08/04), Firefox & IE9
      When you want to unenrol, the page content appears inside the header (see screenshot)
      This is probably due to the fact that the page does not have any blocks or dock at all.

        Activity

        Hide
        Jean-Luc Delghust added a comment -

        I tried adding some custom CSS to add rules for pages with content only, but that would in turn push the content down on pages where all blocks were docked

        the custom CSS tried was:

        .content-only #page-content #region-main .region-content

        { padding-top: 115px; }

        Don't know how to specify for this rule to apply only on pages without dock AND without blocks

        Show
        Jean-Luc Delghust added a comment - I tried adding some custom CSS to add rules for pages with content only, but that would in turn push the content down on pages where all blocks were docked the custom CSS tried was: .content-only #page-content #region-main .region-content { padding-top: 115px; } Don't know how to specify for this rule to apply only on pages without dock AND without blocks
        Hide
        Mary Evans added a comment -

        Thank you for reporting this.

        The CSS you are looking for is this...

        #page-enrol-manual-unenrolself #region-main .region-content #region-header.inside { margin-bottom: 110px;}
        Show
        Mary Evans added a comment - Thank you for reporting this. The CSS you are looking for is this... #page-enrol-manual-unenrolself #region-main .region-content #region-header.inside { margin-bottom: 110px;}
        Hide
        Mary Evans added a comment -

        This is on my TO-DO list for this weekend.

        Show
        Mary Evans added a comment - This is on my TO-DO list for this weekend.
        Hide
        Mary Evans added a comment -

        All done...it is now in the 'Lap of the Moodle HQ Gods'

        Show
        Mary Evans added a comment - All done...it is now in the 'Lap of the Moodle HQ Gods'
        Hide
        Mary Evans added a comment -

        @Note to Integrator

        It looks like my Text Editor cleaned up some 'white-space', so it's hard to see the actual fix which is right at the bottom of pagelayout.css.

        Show
        Mary Evans added a comment - @Note to Integrator It looks like my Text Editor cleaned up some 'white-space', so it's hard to see the actual fix which is right at the bottom of pagelayout.css.
        Hide
        Dan Poltawski added a comment -

        Hi Mary,

        A trick for cases like this, you can pass the argument ?w=1 to get github to ignore the whitespace changes, so for the diff url I can do:
        https://github.com/lazydaisy/moodle/compare/master...MDL-34835_master?w=1 to see the actual changes.

        I do that with git itself too on the command line with --ignore-space-change. Though I should say, in general we'd prefer it if space changes weren't done needlessly because it makes it harder to follow the history of changes (in this case its fine IMO).

        Show
        Dan Poltawski added a comment - Hi Mary, A trick for cases like this, you can pass the argument ?w=1 to get github to ignore the whitespace changes, so for the diff url I can do: https://github.com/lazydaisy/moodle/compare/master...MDL-34835_master?w=1 to see the actual changes. I do that with git itself too on the command line with --ignore-space-change. Though I should say, in general we'd prefer it if space changes weren't done needlessly because it makes it harder to follow the history of changes (in this case its fine IMO).
        Hide
        Dan Poltawski added a comment -

        Integrated to 23, 22 and master. Thanks!

        Show
        Dan Poltawski added a comment - Integrated to 23, 22 and master. Thanks!
        Hide
        David Monllaó added a comment -

        It passes, tested in MOODLE_22_STABLE and master. The site name is not visible, but it seems that it has nothing to do with this issue

        Show
        David Monllaó added a comment - It passes, tested in MOODLE_22_STABLE and master. The site name is not visible, but it seems that it has nothing to do with this issue
        Hide
        Eloy Lafuente (stronk7) added a comment -

        For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility!

        Many thanks for your collaboration, yay!

        Closing, ciao

        Show
        Eloy Lafuente (stronk7) added a comment - For the good and the bad... this is now part of Moodle and people around the world will start using it immediately, what a responsibility! Many thanks for your collaboration, yay! Closing, ciao
        Hide
        Jean-Luc Delghust added a comment -

        Thanks!

        Show
        Jean-Luc Delghust added a comment - Thanks!
        Hide
        Jean-Luc Delghust added a comment -

        Sorry to come back with this, but adding the custom CSS to our theme (parent to Fusion) only solved the problem for manual enrolments. We have students self-enrolling.
        I added the following CSS as well, which seems to work to solve it (change in capital letters):

        #page-enrol-SELF-unenrolself #region-main .region-content #region-header.inside

        { margin-bottom: 110px;}
        Show
        Jean-Luc Delghust added a comment - Sorry to come back with this, but adding the custom CSS to our theme (parent to Fusion) only solved the problem for manual enrolments. We have students self-enrolling. I added the following CSS as well, which seems to work to solve it (change in capital letters): #page-enrol-SELF-unenrolself #region-main .region-content #region-header.inside { margin-bottom: 110px;}

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: