Moodle
  1. Moodle
  2. MDL-34848

SCORM activity always showing in /my

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2.4
    • Fix Version/s: 2.4
    • Component/s: My home, SCORM
    • Labels:
    • Testing Instructions:
      Hide

      Create a SCORM packge, submit some data to start an attempt.
      make sure student skip content structure page setting is not set to allow proper testing.

      set/test the following "display attempt status" settings and check both the my moodle(course overview block) and the SCORM entry page (view.php) to see if the setting works correctly

      • No (shouldn't display the attempt status info on my moodle or the scorm entry page)
      • My home and entry page (should display on both entry and my moodle pages)
      • My home only (should only display on my moodle page and not scorm entry page
      • Entry page only (hopefully explanatory by now..)
      Show
      Create a SCORM packge, submit some data to start an attempt. make sure student skip content structure page setting is not set to allow proper testing. set/test the following "display attempt status" settings and check both the my moodle(course overview block) and the SCORM entry page (view.php) to see if the setting works correctly No (shouldn't display the attempt status info on my moodle or the scorm entry page) My home and entry page (should display on both entry and my moodle pages) My home only (should only display on my moodle page and not scorm entry page Entry page only (hopefully explanatory by now..)
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull Master Branch:
      master_MDL-34848
    • Rank:
      43363

      Description

      When navigating to http://www.moodlesite.com/my/ all SCORM objects are shown.
      This is regardless of their completion status, dates, etc. - they are always there.
      This behaviour is not consistent with how Quizzes, Assignments and other activities are handled in the /my view.
      I do not think the SCORM objects should be permanently displayed in /my - as this will cause unnecessary problems in courses with lots of SCORM objects.
      (I did a search for this in Tracker but couldn't find anything else on this behaviour - but feel free to link to another issue if it's already been reported).

        Issue Links

          Activity

          Hide
          Dan Marsden added a comment -

          Thanks Stuart does this occur when display attempt status is turned off inside the SCORM settings as well? If that's the problem we could probably split the attmept status setting so that it allowed the teacher to show:
          never
          only on entry page in scorm
          only on my moodle page
          on both entry and my moodle

          Show
          Dan Marsden added a comment - Thanks Stuart does this occur when display attempt status is turned off inside the SCORM settings as well? If that's the problem we could probably split the attmept status setting so that it allowed the teacher to show: never only on entry page in scorm only on my moodle page on both entry and my moodle
          Hide
          Dan Marsden added a comment -

          FYI - It was based on another Moodle Partners request that we added the attempt status to the My Moodle page - so it's expected behaviour for some, but we can add further options to modify how it works if required?

          Show
          Dan Marsden added a comment - FYI - It was based on another Moodle Partners request that we added the attempt status to the My Moodle page - so it's expected behaviour for some, but we can add further options to modify how it works if required?
          Hide
          Dan Marsden added a comment -

          Stuart? - did you have any further feedback on this?

          Show
          Dan Marsden added a comment - Stuart? - did you have any further feedback on this?
          Hide
          Dan Marsden added a comment -

          in the absence of feedback from Stuart - I've added a patch here that allows the user more flexibility on when/where to show the attempt status:

          • No
          • My home and entry page
          • My home only
          • Entry page only

          hopefully that is what you're wanting? - bouncing it up for peer review.

          Show
          Dan Marsden added a comment - in the absence of feedback from Stuart - I've added a patch here that allows the user more flexibility on when/where to show the attempt status: No My home and entry page My home only Entry page only hopefully that is what you're wanting? - bouncing it up for peer review.
          Hide
          Sam Hemelryk added a comment -

          Hi Dan,

          The changes purposed here look good, Stuart it would still be nice to hear from you if possible as to whether this would resolve the concerns you had with the current system?
          The solution appears to me like it would, I suppose either way this is a valid improvement so if not we can always open a new issue to address more specific issues.

          Gets a +1 from me Dan, feel free to put it up for integration when you are ready.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi Dan, The changes purposed here look good, Stuart it would still be nice to hear from you if possible as to whether this would resolve the concerns you had with the current system? The solution appears to me like it would, I suppose either way this is a valid improvement so if not we can always open a new issue to address more specific issues. Gets a +1 from me Dan, feel free to put it up for integration when you are ready. Cheers Sam
          Hide
          Dan Marsden added a comment -

          thanks Sam - I wonder if these messages are getting caught by Stuarts filters....

          Show
          Dan Marsden added a comment - thanks Sam - I wonder if these messages are getting caught by Stuarts filters....
          Hide
          Stuart R Mealor added a comment - - edited

          Thanks Dan and Sam

          • as the Reporter of this I thought I would get a notification as soon as it was commented ... but I definitely have not got any updates on MDL-34848 !!!
            Maybe the Reporter does get this automatically? (seems bizarre) - but I've followed it now anyway
            Anyway, the discussion above looks good - at least the SCORM has flexibility/option to display on the /my page or not.
            Not sure if this is how you've coded it Dan, but not being displayed should be the default for a SCORM activity on the /my page, and then it will match the behaviour of all other Graded Activities
          Show
          Stuart R Mealor added a comment - - edited Thanks Dan and Sam as the Reporter of this I thought I would get a notification as soon as it was commented ... but I definitely have not got any updates on MDL-34848 !!! Maybe the Reporter does get this automatically? (seems bizarre) - but I've followed it now anyway Anyway, the discussion above looks good - at least the SCORM has flexibility/option to display on the /my page or not. Not sure if this is how you've coded it Dan, but not being displayed should be the default for a SCORM activity on the /my page, and then it will match the behaviour of all other Graded Activities
          Hide
          Dan Marsden added a comment -

          Thanks Stuart - the default setting for attemptstatus is 1 == "My home and entry page" - but people can change that in admin > plugins > SCORM, I wouldn't mind changing it to "Entry page only" by default but would probably resist setting it as "No" - feel free to create a new tracker issue to change the default setting! (hopefully you receive notifications on that issue!)

          having the attempt status display by default on the entry page seems to have cut down a lot of support requests around confusion over grades and attempts in SCORM in the moodle forums.

          Show
          Dan Marsden added a comment - Thanks Stuart - the default setting for attemptstatus is 1 == "My home and entry page" - but people can change that in admin > plugins > SCORM, I wouldn't mind changing it to "Entry page only" by default but would probably resist setting it as "No" - feel free to create a new tracker issue to change the default setting! (hopefully you receive notifications on that issue!) having the attempt status display by default on the entry page seems to have cut down a lot of support requests around confusion over grades and attempts in SCORM in the moodle forums.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (master, aka, 2.4 only), thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (master, aka, 2.4 only), thanks!
          Hide
          Ankit Agarwal added a comment -

          Sorry failing this.

          1. For "entry page only" setting it is displayed in both /my and scorm entry page
          2. in /my the message displayed is "You have SCORM packages that need attention", not sure why that message is displayed although I completed the scorm activity. Anyways its not in the scope of this bug.

          Thanks

          Show
          Ankit Agarwal added a comment - Sorry failing this. For "entry page only" setting it is displayed in both /my and scorm entry page in /my the message displayed is "You have SCORM packages that need attention", not sure why that message is displayed although I completed the scorm activity. Anyways its not in the scope of this bug. Thanks
          Hide
          Dan Marsden added a comment -

          Hi Ankit - seems to work as expected for me on qa.moodle.net

          • this is only for the "attempt status" stuff - it will still show the scorm package on the my moodle page - My Moodle appears to have changed a bit so may not operate as you expect - the stuff inside each module are collapsed by default. if you expand the "scorm packages that need attention" you will see attempt status depending on the settings made.
          • not sure if the way it expands/collapses is the same as other modules, but there are other My Moodle bugs with SCORM - (no dates/deadlines shown) - if there are other issues we should open new bugs.
          Show
          Dan Marsden added a comment - Hi Ankit - seems to work as expected for me on qa.moodle.net this is only for the "attempt status" stuff - it will still show the scorm package on the my moodle page - My Moodle appears to have changed a bit so may not operate as you expect - the stuff inside each module are collapsed by default. if you expand the "scorm packages that need attention" you will see attempt status depending on the settings made. not sure if the way it expands/collapses is the same as other modules, but there are other My Moodle bugs with SCORM - (no dates/deadlines shown) - if there are other issues we should open new bugs.
          Hide
          Ankit Agarwal added a comment - - edited

          Hi Dan,
          When we set it to "NO"
          Nothing at all appears in /my regarding the scorm packages (there is only one scorm in course)
          But when we select "Entry page only"
          "You have SCORM packages that need attention" appears but without the information

          is that expected?
          Thanks

          Show
          Ankit Agarwal added a comment - - edited Hi Dan, When we set it to "NO" Nothing at all appears in /my regarding the scorm packages (there is only one scorm in course) But when we select "Entry page only" "You have SCORM packages that need attention" appears but without the information is that expected? Thanks
          Hide
          Dan Marsden added a comment -

          I see - thanks for the explanation, that's a bug..

          easy fix though - will push one in the next 15-30min

          Show
          Dan Marsden added a comment - I see - thanks for the explanation, that's a bug.. easy fix though - will push one in the next 15-30min
          Hide
          Dan Marsden added a comment -

          The closer I looked at that function the weirder it looked - it was running 2 foreach loops "for speed" - but it didn't seem to speed anything up - if anything it was over-complicating the code and duplicating effort. Maybe in the past it was better as 2 loops, but it looks a lot better to me as a single loop.

          The rewrite also fixes the bug Ankit found - thanks Ankit!

          Show
          Dan Marsden added a comment - The closer I looked at that function the weirder it looked - it was running 2 foreach loops "for speed" - but it didn't seem to speed anything up - if anything it was over-complicating the code and duplicating effort. Maybe in the past it was better as 2 loops, but it looks a lot better to me as a single loop. The rewrite also fixes the bug Ankit found - thanks Ankit!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Fix pushed. Sending this back to testing... thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Fix pushed. Sending this back to testing... thanks!
          Hide
          Ankit Agarwal added a comment -

          Thanks for the quick fix Dan,
          This now works as expected.
          Thanks

          Show
          Ankit Agarwal added a comment - Thanks for the quick fix Dan, This now works as expected. Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          From somewhere within the clouds...

          Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao
          Hide
          Mary Cooch added a comment -

          Removing docs_required label as I don't think something that now works as it should needs documenting but please say if you disagree.

          Show
          Mary Cooch added a comment - Removing docs_required label as I don't think something that now works as it should needs documenting but please say if you disagree.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: